You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@roller.apache.org by GitBox <gi...@apache.org> on 2021/02/13 00:04:13 UTC

[GitHub] [roller] nuzayats commented on pull request #75: Ipbanlist fixes

nuzayats commented on pull request #75:
URL: https://github.com/apache/roller/pull/75#issuecomment-778521097


   Hello Michael, thanks for the review :)
   
   > volatile could be removed again if the Set is made final (and cleared + reused in loadBannedIps())
   
   In order to reuse the Set that way, I think we need to clear and populate it somehow atomically, which I'm not sure how, because otherwise it will introduce a time window where isBanned() gets called while the Set is empty which sounds like some kind of vulnerability. Based on that, I guess using volatile this way is kind of reasonable
   
   > loadBannedIpsIfNeeded is only called with forceLoad set to false -> opportunity to be simplified.
   
   Agreed. Removed at a5417a5


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org