[GitHub] [arrow-datafusion] yahoNanJing commented on a change in pull request #1810: Refactor scheduler state with different management policy for volatile and stable states

[GitBox <gi...@apache.org>]

yahoNanJing commented on a change in pull request #1810:
URL: https://github.com/apache/arrow-datafusion/pull/1810#discussion_r805449691



##########
File path: ballista/rust/executor/src/executor_server.rs
##########
@@ -164,8 +152,8 @@ impl ExecutorServer {
         // TODO Error handling
         self.scheduler
             .clone()
-            .send_heart_beat(SendHeartBeatParams {
-                metadata: Some(self.executor_meta.clone()),
+            .receive_heart_beat(HeartBeatParams {
+                executor_id: self.executor.metadata.id.clone(),
                 state: Some(self.get_executor_state().await.into()),
             })
             .await

Review comment:
       Agree. It's more clear than before.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org