You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by fi...@apache.org on 2012/04/24 01:54:38 UTC
wp7 commit: [CB-559] Cache instantiated plugins in CommandFactory
Updated Branches:
refs/heads/master 0408cd6ae -> 06dc6357e
[CB-559] Cache instantiated plugins in CommandFactory
Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-wp7/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-wp7/commit/06dc6357
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-wp7/tree/06dc6357
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-wp7/diff/06dc6357
Branch: refs/heads/master
Commit: 06dc6357e44d3e25ce18743061a03ce90cf0e9a2
Parents: 0408cd6
Author: filmaj <ma...@gmail.com>
Authored: Mon Apr 23 16:50:00 2012 -0700
Committer: filmaj <ma...@gmail.com>
Committed: Mon Apr 23 16:50:00 2012 -0700
----------------------------------------------------------------------
framework/Cordova/CommandFactory.cs | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-cordova-wp7/blob/06dc6357/framework/Cordova/CommandFactory.cs
----------------------------------------------------------------------
diff --git a/framework/Cordova/CommandFactory.cs b/framework/Cordova/CommandFactory.cs
index 308c490..1718816 100644
--- a/framework/Cordova/CommandFactory.cs
+++ b/framework/Cordova/CommandFactory.cs
@@ -42,10 +42,10 @@ namespace WP7CordovaClassLib.Cordova
private static readonly string BaseCommandNamespacePrefix = "WP7CordovaClassLib.Cordova.Commands.";
/// <summary>
- /// Performance optimization allowing more faster create already known commands.
+ /// Cache instantiated commands in a map.
/// </summary>
- private static Dictionary<string, Type> commandMap = new Dictionary<string, Type>();
+ private static Dictionary<string, BaseCommand> commandMap = new Dictionary<string, BaseCommand>();
/// <summary>
/// Creates command using command class name. Returns null for unknown commands.
@@ -95,10 +95,10 @@ namespace WP7CordovaClassLib.Cordova
return null;
}
- commandMap[service] = t;
+ commandMap[service] = Activator.CreateInstance(t) as BaseCommand;
}
- return Activator.CreateInstance(commandMap[service]) as BaseCommand;
+ return commandMap[service];
}
}
}