You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/24 12:22:22 UTC

[GitHub] [flink] 1u0 opened a new pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread

1u0 opened a new pull request #8858: [hotfix][tests] Change some StreamTask tests to create a test task in the task's thread
URL: https://github.com/apache/flink/pull/8858
 
 
   ## What is the purpose of the change
   
   The changes introduced in #8692 PR have an invariant, that the `StreamTask`'s mailbox loop is running in the same thread that set in the `taskMailboxExecutor`. Currently, the thread reference is set in `StreamTask` instantiation time, this conflicts with some `StreamTask` tests, as they were creating the task instance in a different (non task's) thread.
   
   ## Brief change log
   
   *(for example:)*
     - `StreamTaskTest` is rewritten to properly run a task under test, instead of overriding some fields via `Whitebox`;
     - the rest of tests in `flink-streaming-java` are rewritten to delegate task instance creation to the task's main thread.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   Running the tests in `flink-streaming-java` and `flink-streaming-scala` should be green. Also, running the same tests with changes in #8692 should be green.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services