You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Monika Kachhadiya via Review Board <no...@reviews.apache.org> on 2024/06/14 09:38:33 UTC
Review Request 75048: RANGER-4821 Fix bugs and code smell reported by sonarqube
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75048/
-----------------------------------------------------------
Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, Siddhesh Phatak, and Subhrat Chaudhary.
Bugs: RANGER-4821
https://issues.apache.org/jira/browse/RANGER-4821
Repository: ranger
Description
-------
Apache ranger has around 16k sonar findings. Please refer below screen print for details.
Around 300 sonarqube findings have been fixed with this patch. This will help improve code readability and maintainability.
Diffs
-----
agents-audit/src/main/java/org/apache/ranger/audit/destination/AmazonCloudWatchAuditDestination.java e8ea2bab96
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java c06002d35f
agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java f96172554d
agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 6fe92498ae
agents-audit/src/main/java/org/apache/ranger/audit/provider/AsyncAuditProvider.java 9cd613c5a2
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditWriterFactory.java 8860f1c8fd
agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 68c33c90db
agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 769b86c632
agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java 3f40861b06
agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java 91a9e75ea0
agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractRangerAuditWriter.java 0e74e3bd4b
agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java f73df2c207
agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerORCAuditWriter.java 52403bd9da
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 8714a96252
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java 8d4da5b1e7
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java c5f5fc3be6
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java 16f8afb2c2
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 462246a3e2
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 3270564317
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java aa0c801199
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 8dbc7eedd4
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java e54313403d
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerUserStoreUtil.java 70f2c66291
agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java f9816546a3
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java f8d57bcd68
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/StopEmbeddedServer.java c020c34207
hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 2d7e7b7520
jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java 308350f0e0
kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 3eb977023f
kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java a1a6f348b9
kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 1935a0185a
kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java eb8a90a712
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 1487beff0a
plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java 7fcd920333
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java c3e7d081a4
ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java 0edcf3cbdc
ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java b4bfee1bcc
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/action/filter/RangerSecurityActionFilter.java 945d6a17e4
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/authc/user/UsernamePasswordToken.java c1df938db7
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/rest/filter/RangerSecurityRestFilter.java 92215e5a78
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java e509578608
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java cafa1a3bb9
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPluginPerfTester.java efcc39c14b
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 47d00b1c19
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2aed957d8c
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 738d92e48f
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 75371f4b25
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 102ae5b94f
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java f98d009020
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java fcef33269b
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 61cb98308b
security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java f910e92ee5
security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 8af4448b5d
security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 595598ad7d
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 883a22dd6e
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 091918dc1c
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 6de3b7448a
security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java 708f92e342
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 6a74381406
security-admin/src/main/java/org/apache/ranger/service/AuthSessionService.java b12984de6c
security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java 2733fd0990
security-admin/src/main/java/org/apache/ranger/service/XAssetService.java f1fc54b455
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java e2abd6e406
security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java 4f8a3c9c37
security-admin/src/main/java/org/apache/ranger/service/XUserService.java c31404e74b
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 9ba7bbd4d7
ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java 9c951a6685
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java fecd96de01
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java e226662e16
Diff: https://reviews.apache.org/r/75048/diff/1/
Testing
-------
Sanity test of CRUD policies/users/groups from ranger UI
Verified existing junits test cases are working as expected
Thanks,
Monika Kachhadiya
Re: Review Request 75048: RANGER-4821 Fix bugs and code smell reported by sonarqube
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75048/#review226572
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On June 17, 2024, 11:20 a.m., Monika Kachhadiya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75048/
> -----------------------------------------------------------
>
> (Updated June 17, 2024, 11:20 a.m.)
>
>
> Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, Siddhesh Phatak, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4821
> https://issues.apache.org/jira/browse/RANGER-4821
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Apache ranger has around 16k sonar findings. Please refer below screen print for details.
> Around 300 sonarqube findings have been fixed with this patch. This will help improve code readability and maintainability.
> Blockers have been reduced from 287 to 226
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/destination/AmazonCloudWatchAuditDestination.java e8ea2bab96
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java c06002d35f
> agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java f96172554d
> agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 2d26139410
> agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 6fe92498ae
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AsyncAuditProvider.java 9cd613c5a2
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditWriterFactory.java 8860f1c8fd
> agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 68c33c90db
> agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 769b86c632
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java 3f40861b06
> agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java 91a9e75ea0
> agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java f73df2c207
> agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerORCAuditWriter.java 52403bd9da
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 8714a96252
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java 8d4da5b1e7
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java c5f5fc3be6
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java 16f8afb2c2
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 462246a3e2
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java aa0c801199
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 8dbc7eedd4
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java e54313403d
> agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java f9816546a3
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java f8d57bcd68
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/StopEmbeddedServer.java c020c34207
> hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 2d7e7b7520
> jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java 308350f0e0
> kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 3eb977023f
> kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java a1a6f348b9
> kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 1935a0185a
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java eb8a90a712
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 1487beff0a
> plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java 7fcd920333
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java c3e7d081a4
> ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java 0edcf3cbdc
> ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java b4bfee1bcc
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java e509578608
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java cafa1a3bb9
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPluginPerfTester.java efcc39c14b
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 47d00b1c19
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2aed957d8c
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 738d92e48f
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 75371f4b25
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 102ae5b94f
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java f98d009020
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java fcef33269b
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 61cb98308b
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 595598ad7d
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 883a22dd6e
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 091918dc1c
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 6de3b7448a
> security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java 708f92e342
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 6a74381406
> security-admin/src/main/java/org/apache/ranger/service/AuthSessionService.java b12984de6c
> security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java 2733fd0990
> security-admin/src/main/java/org/apache/ranger/service/XAssetService.java f1fc54b455
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java e2abd6e406
> security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java 4f8a3c9c37
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java c31404e74b
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 9ba7bbd4d7
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java 9c951a6685
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java fecd96de01
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java e226662e16
>
>
> Diff: https://reviews.apache.org/r/75048/diff/3/
>
>
> Testing
> -------
>
> Sanity test of CRUD policies/users/groups from ranger UI
> Verified existing junits test cases are working as expected
>
>
> Thanks,
>
> Monika Kachhadiya
>
>
Re: Review Request 75048: RANGER-4821 Fix bugs and code smell reported by sonarqube
Posted by Monika Kachhadiya via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75048/
-----------------------------------------------------------
(Updated June 17, 2024, 11:20 a.m.)
Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, Siddhesh Phatak, and Subhrat Chaudhary.
Changes
-------
addressed review comments
Bugs: RANGER-4821
https://issues.apache.org/jira/browse/RANGER-4821
Repository: ranger
Description
-------
Apache ranger has around 16k sonar findings. Please refer below screen print for details.
Around 300 sonarqube findings have been fixed with this patch. This will help improve code readability and maintainability.
Blockers have been reduced from 287 to 226
Diffs (updated)
-----
agents-audit/src/main/java/org/apache/ranger/audit/destination/AmazonCloudWatchAuditDestination.java e8ea2bab96
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java c06002d35f
agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java f96172554d
agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java 2d26139410
agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 6fe92498ae
agents-audit/src/main/java/org/apache/ranger/audit/provider/AsyncAuditProvider.java 9cd613c5a2
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditWriterFactory.java 8860f1c8fd
agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 68c33c90db
agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 769b86c632
agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java 3f40861b06
agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java 91a9e75ea0
agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java f73df2c207
agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerORCAuditWriter.java 52403bd9da
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 8714a96252
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java 8d4da5b1e7
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java c5f5fc3be6
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java 16f8afb2c2
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 462246a3e2
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java aa0c801199
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 8dbc7eedd4
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java e54313403d
agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java f9816546a3
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java f8d57bcd68
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/StopEmbeddedServer.java c020c34207
hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 2d7e7b7520
jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java 308350f0e0
kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 3eb977023f
kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java a1a6f348b9
kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 1935a0185a
kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java eb8a90a712
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 1487beff0a
plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java 7fcd920333
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java c3e7d081a4
ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java 0edcf3cbdc
ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java b4bfee1bcc
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java e509578608
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java cafa1a3bb9
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPluginPerfTester.java efcc39c14b
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 47d00b1c19
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2aed957d8c
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 738d92e48f
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 75371f4b25
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 102ae5b94f
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java f98d009020
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java fcef33269b
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 61cb98308b
security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 595598ad7d
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 883a22dd6e
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 091918dc1c
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 6de3b7448a
security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java 708f92e342
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 6a74381406
security-admin/src/main/java/org/apache/ranger/service/AuthSessionService.java b12984de6c
security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java 2733fd0990
security-admin/src/main/java/org/apache/ranger/service/XAssetService.java f1fc54b455
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java e2abd6e406
security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java 4f8a3c9c37
security-admin/src/main/java/org/apache/ranger/service/XUserService.java c31404e74b
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 9ba7bbd4d7
ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java 9c951a6685
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java fecd96de01
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java e226662e16
Diff: https://reviews.apache.org/r/75048/diff/3/
Changes: https://reviews.apache.org/r/75048/diff/2-3/
Testing
-------
Sanity test of CRUD policies/users/groups from ranger UI
Verified existing junits test cases are working as expected
Thanks,
Monika Kachhadiya
Re: Review Request 75048: RANGER-4821 Fix bugs and code smell reported by sonarqube
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75048/#review226551
-----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java
Line 113 (original), 106 (patched)
<https://reviews.apache.org/r/75048/#comment314813>
+ should be replaced with a comma.
agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java
Line 242 (original), 232 (patched)
<https://reviews.apache.org/r/75048/#comment314814>
+ should be replaced with a comma.
agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java
Line 428 (original), 428 (patched)
<https://reviews.apache.org/r/75048/#comment314815>
To be consistent, consider replacing the message string with FAILED_TO_LOG_AUDIT_EVENT. Same for line #489 as well.
agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java
Line 846 (original), 777 (patched)
<https://reviews.apache.org/r/75048/#comment314816>
- + should be replaced with a comma.
- CONSUMER seems unnecessary here
agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java
Line 884 (original), 812 (patched)
<https://reviews.apache.org/r/75048/#comment314817>
Consider replacing string concat with parameterized message. Same in line #830 as well.
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java
Line 62 (original), 66 (patched)
<https://reviews.apache.org/r/75048/#comment314818>
I suggest to revert all whitespace changes in this file.
- Madhan Neethiraj
On June 14, 2024, 9:44 p.m., Monika Kachhadiya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75048/
> -----------------------------------------------------------
>
> (Updated June 14, 2024, 9:44 p.m.)
>
>
> Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, Siddhesh Phatak, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4821
> https://issues.apache.org/jira/browse/RANGER-4821
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Apache ranger has around 16k sonar findings. Please refer below screen print for details.
> Around 300 sonarqube findings have been fixed with this patch. This will help improve code readability and maintainability.
> Blockers have been reduced from 287 to 226
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/destination/AmazonCloudWatchAuditDestination.java e8ea2bab96
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java c06002d35f
> agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java f96172554d
> agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 6fe92498ae
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AsyncAuditProvider.java 9cd613c5a2
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditWriterFactory.java 8860f1c8fd
> agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 68c33c90db
> agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 769b86c632
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java 3f40861b06
> agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java 91a9e75ea0
> agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java f73df2c207
> agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerORCAuditWriter.java 52403bd9da
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 8714a96252
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java 8d4da5b1e7
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java c5f5fc3be6
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java 16f8afb2c2
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 462246a3e2
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java aa0c801199
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 8dbc7eedd4
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java e54313403d
> agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java f9816546a3
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java f8d57bcd68
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/StopEmbeddedServer.java c020c34207
> hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 2d7e7b7520
> jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java 308350f0e0
> kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 3eb977023f
> kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java a1a6f348b9
> kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 1935a0185a
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java eb8a90a712
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 1487beff0a
> plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java 7fcd920333
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java c3e7d081a4
> ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java 0edcf3cbdc
> ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java b4bfee1bcc
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java e509578608
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java cafa1a3bb9
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPluginPerfTester.java efcc39c14b
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 47d00b1c19
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2aed957d8c
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 738d92e48f
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 75371f4b25
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 102ae5b94f
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java f98d009020
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java fcef33269b
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 61cb98308b
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 595598ad7d
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 883a22dd6e
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 091918dc1c
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 6de3b7448a
> security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java 708f92e342
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 6a74381406
> security-admin/src/main/java/org/apache/ranger/service/AuthSessionService.java b12984de6c
> security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java 2733fd0990
> security-admin/src/main/java/org/apache/ranger/service/XAssetService.java f1fc54b455
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java e2abd6e406
> security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java 4f8a3c9c37
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java c31404e74b
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 9ba7bbd4d7
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java 9c951a6685
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java fecd96de01
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java e226662e16
>
>
> Diff: https://reviews.apache.org/r/75048/diff/2/
>
>
> Testing
> -------
>
> Sanity test of CRUD policies/users/groups from ranger UI
> Verified existing junits test cases are working as expected
>
>
> Thanks,
>
> Monika Kachhadiya
>
>
Re: Review Request 75048: RANGER-4821 Fix bugs and code smell reported by sonarqube
Posted by Monika Kachhadiya via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75048/
-----------------------------------------------------------
(Updated June 14, 2024, 9:44 p.m.)
Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, Siddhesh Phatak, and Subhrat Chaudhary.
Changes
-------
addressed review comments
Bugs: RANGER-4821
https://issues.apache.org/jira/browse/RANGER-4821
Repository: ranger
Description
-------
Apache ranger has around 16k sonar findings. Please refer below screen print for details.
Around 300 sonarqube findings have been fixed with this patch. This will help improve code readability and maintainability.
Blockers have been reduced from 287 to 226
Diffs (updated)
-----
agents-audit/src/main/java/org/apache/ranger/audit/destination/AmazonCloudWatchAuditDestination.java e8ea2bab96
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java c06002d35f
agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java f96172554d
agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 6fe92498ae
agents-audit/src/main/java/org/apache/ranger/audit/provider/AsyncAuditProvider.java 9cd613c5a2
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditWriterFactory.java 8860f1c8fd
agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 68c33c90db
agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 769b86c632
agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java 3f40861b06
agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java 91a9e75ea0
agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java f73df2c207
agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerORCAuditWriter.java 52403bd9da
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 8714a96252
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java 8d4da5b1e7
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java c5f5fc3be6
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java 16f8afb2c2
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 462246a3e2
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java aa0c801199
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 8dbc7eedd4
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java e54313403d
agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java f9816546a3
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java f8d57bcd68
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/StopEmbeddedServer.java c020c34207
hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 2d7e7b7520
jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java 308350f0e0
kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 3eb977023f
kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java a1a6f348b9
kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 1935a0185a
kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java eb8a90a712
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 1487beff0a
plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java 7fcd920333
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java c3e7d081a4
ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java 0edcf3cbdc
ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java b4bfee1bcc
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java e509578608
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java cafa1a3bb9
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPluginPerfTester.java efcc39c14b
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 47d00b1c19
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2aed957d8c
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 738d92e48f
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 75371f4b25
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 102ae5b94f
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java f98d009020
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java fcef33269b
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 61cb98308b
security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 595598ad7d
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 883a22dd6e
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 091918dc1c
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 6de3b7448a
security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java 708f92e342
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 6a74381406
security-admin/src/main/java/org/apache/ranger/service/AuthSessionService.java b12984de6c
security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java 2733fd0990
security-admin/src/main/java/org/apache/ranger/service/XAssetService.java f1fc54b455
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java e2abd6e406
security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java 4f8a3c9c37
security-admin/src/main/java/org/apache/ranger/service/XUserService.java c31404e74b
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 9ba7bbd4d7
ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java 9c951a6685
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java fecd96de01
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java e226662e16
Diff: https://reviews.apache.org/r/75048/diff/2/
Changes: https://reviews.apache.org/r/75048/diff/1-2/
Testing
-------
Sanity test of CRUD policies/users/groups from ranger UI
Verified existing junits test cases are working as expected
Thanks,
Monika Kachhadiya
Re: Review Request 75048: RANGER-4821 Fix bugs and code smell reported by sonarqube
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75048/#review226549
-----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java
Line 181 (original), 182 (patched)
<https://reviews.apache.org/r/75048/#comment314808>
Consider using SLF4J's parameterized logging:
logger.error("Error on closing log writter. Exception will be ignored. name={}, fileName={}", getName(), currentFileName);
Consider similar updates for other log statements in this file.
agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
Line 168 (original), 168 (patched)
<https://reviews.apache.org/r/75048/#comment314807>
Instead of introducing a new try block, consider using the exising try in the previous line.
Same applies for the update in line #193 below.
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java
Line 59 (original), 63 (patched)
<https://reviews.apache.org/r/75048/#comment314811>
Renaming existing public members will break users of ranger-plugins-common library that refer to these members. Please review and revert all such renamings.
plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java
Lines 94 (patched)
<https://reviews.apache.org/r/75048/#comment314812>
Good catch!
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java
Line 51 (original), 51 (patched)
<https://reviews.apache.org/r/75048/#comment314810>
HashMap<String, String> => HashMap<>
ArrayList<String> ==> ArrayList<>
security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java
Line 413 (original), 413 (patched)
<https://reviews.apache.org/r/75048/#comment314809>
Consider using existing try instead of introducing a new try block.
Same applies for line #437 below.
- Madhan Neethiraj
On June 14, 2024, 9:49 a.m., Monika Kachhadiya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75048/
> -----------------------------------------------------------
>
> (Updated June 14, 2024, 9:49 a.m.)
>
>
> Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, Siddhesh Phatak, and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4821
> https://issues.apache.org/jira/browse/RANGER-4821
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Apache ranger has around 16k sonar findings. Please refer below screen print for details.
> Around 300 sonarqube findings have been fixed with this patch. This will help improve code readability and maintainability.
> Blockers have been reduced from 287 to 226
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/destination/AmazonCloudWatchAuditDestination.java e8ea2bab96
> agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java c06002d35f
> agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java f96172554d
> agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 6fe92498ae
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AsyncAuditProvider.java 9cd613c5a2
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditWriterFactory.java 8860f1c8fd
> agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 68c33c90db
> agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 769b86c632
> agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java 3f40861b06
> agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java 91a9e75ea0
> agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractRangerAuditWriter.java 0e74e3bd4b
> agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java f73df2c207
> agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerORCAuditWriter.java 52403bd9da
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 8714a96252
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java 8d4da5b1e7
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java c5f5fc3be6
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java 16f8afb2c2
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 462246a3e2
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 3270564317
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java aa0c801199
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 8dbc7eedd4
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java e54313403d
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerUserStoreUtil.java 70f2c66291
> agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java f9816546a3
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java f8d57bcd68
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/StopEmbeddedServer.java c020c34207
> hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 2d7e7b7520
> jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java 308350f0e0
> kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 3eb977023f
> kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java a1a6f348b9
> kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 1935a0185a
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java eb8a90a712
> kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 1487beff0a
> plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java 7fcd920333
> plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java c3e7d081a4
> ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java 0edcf3cbdc
> ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java b4bfee1bcc
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/action/filter/RangerSecurityActionFilter.java 945d6a17e4
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/authc/user/UsernamePasswordToken.java c1df938db7
> ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/rest/filter/RangerSecurityRestFilter.java 92215e5a78
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java e509578608
> ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java cafa1a3bb9
> ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPluginPerfTester.java efcc39c14b
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 47d00b1c19
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2aed957d8c
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 738d92e48f
> security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 75371f4b25
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 102ae5b94f
> security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java f98d009020
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java fcef33269b
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 61cb98308b
> security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java f910e92ee5
> security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 8af4448b5d
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 595598ad7d
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 883a22dd6e
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 091918dc1c
> security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 6de3b7448a
> security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java 708f92e342
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 6a74381406
> security-admin/src/main/java/org/apache/ranger/service/AuthSessionService.java b12984de6c
> security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java 2733fd0990
> security-admin/src/main/java/org/apache/ranger/service/XAssetService.java f1fc54b455
> security-admin/src/main/java/org/apache/ranger/service/XResourceService.java e2abd6e406
> security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java 4f8a3c9c37
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java c31404e74b
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 9ba7bbd4d7
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java 9c951a6685
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java fecd96de01
> unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java e226662e16
>
>
> Diff: https://reviews.apache.org/r/75048/diff/1/
>
>
> Testing
> -------
>
> Sanity test of CRUD policies/users/groups from ranger UI
> Verified existing junits test cases are working as expected
>
>
> Thanks,
>
> Monika Kachhadiya
>
>
Re: Review Request 75048: RANGER-4821 Fix bugs and code smell reported by sonarqube
Posted by Monika Kachhadiya via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75048/
-----------------------------------------------------------
(Updated June 14, 2024, 9:49 a.m.)
Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, Siddhesh Phatak, and Subhrat Chaudhary.
Bugs: RANGER-4821
https://issues.apache.org/jira/browse/RANGER-4821
Repository: ranger
Description (updated)
-------
Apache ranger has around 16k sonar findings. Please refer below screen print for details.
Around 300 sonarqube findings have been fixed with this patch. This will help improve code readability and maintainability.
Blockers have been reduced from 287 to 226
Diffs
-----
agents-audit/src/main/java/org/apache/ranger/audit/destination/AmazonCloudWatchAuditDestination.java e8ea2bab96
agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java c06002d35f
agents-audit/src/main/java/org/apache/ranger/audit/destination/FileAuditDestination.java f96172554d
agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java 6fe92498ae
agents-audit/src/main/java/org/apache/ranger/audit/provider/AsyncAuditProvider.java 9cd613c5a2
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditWriterFactory.java 8860f1c8fd
agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java 68c33c90db
agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 769b86c632
agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java 3f40861b06
agents-audit/src/main/java/org/apache/ranger/audit/test/TestEvents.java 91a9e75ea0
agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractRangerAuditWriter.java 0e74e3bd4b
agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java f73df2c207
agents-audit/src/main/java/org/apache/ranger/audit/utils/RangerORCAuditWriter.java 52403bd9da
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 8714a96252
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java 8d4da5b1e7
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java c5f5fc3be6
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java 16f8afb2c2
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 462246a3e2
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 3270564317
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java aa0c801199
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 8dbc7eedd4
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java e54313403d
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerUserStoreUtil.java 70f2c66291
agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java f9816546a3
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java f8d57bcd68
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/StopEmbeddedServer.java c020c34207
hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java 2d7e7b7520
jisql/src/main/java/org/apache/util/sql/MySQLPLRunner.java 308350f0e0
kms/src/main/java/org/apache/hadoop/crypto/key/AzureKeyVaultClientAuthenticator.java 3eb977023f
kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java a1a6f348b9
kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java 1935a0185a
kms/src/main/java/org/apache/hadoop/crypto/key/RangerSafenetKeySecure.java eb8a90a712
kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java 1487beff0a
plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java 7fcd920333
plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java c3e7d081a4
ranger-common-ha/src/main/java/org/apache/ranger/ha/CuratorFactory.java 0edcf3cbdc
ranger-common-ha/src/main/java/org/apache/ranger/ha/ServiceState.java b4bfee1bcc
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/action/filter/RangerSecurityActionFilter.java 945d6a17e4
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/authc/user/UsernamePasswordToken.java c1df938db7
ranger-elasticsearch-plugin-shim/src/main/java/org/apache/ranger/authorization/elasticsearch/plugin/rest/filter/RangerSecurityRestFilter.java 92215e5a78
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestClient.java e509578608
ranger-tools/src/main/java/org/apache/ranger/policyengine/PerfTestEngine.java cafa1a3bb9
ranger-tools/src/main/java/org/apache/ranger/policyengine/RangerPluginPerfTester.java efcc39c14b
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 47d00b1c19
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2aed957d8c
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 738d92e48f
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 75371f4b25
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 102ae5b94f
security-admin/src/main/java/org/apache/ranger/common/PropertiesUtil.java f98d009020
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java fcef33269b
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 61cb98308b
security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java f910e92ee5
security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 8af4448b5d
security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java 595598ad7d
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 883a22dd6e
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java 091918dc1c
security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java 6de3b7448a
security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java 708f92e342
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerUsernamePasswordAuthenticationFilter.java 6a74381406
security-admin/src/main/java/org/apache/ranger/service/AuthSessionService.java b12984de6c
security-admin/src/main/java/org/apache/ranger/service/RangerAuditedModelService.java 2733fd0990
security-admin/src/main/java/org/apache/ranger/service/XAssetService.java f1fc54b455
security-admin/src/main/java/org/apache/ranger/service/XResourceService.java e2abd6e406
security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java 4f8a3c9c37
security-admin/src/main/java/org/apache/ranger/service/XUserService.java c31404e74b
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 9ba7bbd4d7
ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java 9c951a6685
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java fecd96de01
unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java e226662e16
Diff: https://reviews.apache.org/r/75048/diff/1/
Testing
-------
Sanity test of CRUD policies/users/groups from ranger UI
Verified existing junits test cases are working as expected
Thanks,
Monika Kachhadiya