You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2021/07/08 03:31:24 UTC

[GitHub] [incubator-age] rhizome-ai edited a comment on pull request #87: Adding AGType parsers and driver supports for Python & Go

rhizome-ai edited a comment on pull request #87:
URL: https://github.com/apache/incubator-age/pull/87#issuecomment-875598823


   Thank you, Shoaib.  Thanks to good comments from you and Josh, I could easily spot important points.
   So I reviewed some alternatives, and revised the structure and API of Python driver.
   
   1. Type converter was fixed to type extension api of Psycopg2. (Psycopg2 is widely used among Python developers, so I don't think this tight coupling will be a big problem.) And I added a usage sample (Jupyter note) for developers familiar with Psycopg2.
   
   2. The execution API is simplified to match the characteristics of the Psycopg2 transaction API. The 'queryCypher' was removed and merged into execCypher. 
      In using Psycopg driver,
      - You must explicitly commit after executing the data changing statements.
      - When an error occurred while a statement is executed (even though data retrieving), the session is blocked before rollback called. 
   
   3. I added **numeric annotation**, **multiple column return**, **multiple hop paths**. 
   
   Refactoring of Golang driver will be made next week. Due to the characteristics of PG drivers that follow Golang's sql standard, different approaches are required from Python.
   
   
   ps. Commit history is not viewed in this page. go to [Commits Page](https://github.com/apache/incubator-age/pull/87/commits)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org