You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/19 12:54:10 UTC

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #323: [FLINK-28207] Improve webhook helm configuration

gyfora opened a new pull request, #323:
URL: https://github.com/apache/flink-kubernetes-operator/pull/323

   ## What is the purpose of the change
   
   Improve and clarify webhook configuraiton in helm chart.
   
   ## Brief change log
   
     - webhook.create provides the default enable/disable flag for both mutating and validating webhook
     - webhook.mutator/validator.create can optionally override this setting
     - Upgrade cert-manager 1.8.0 -> 1.8.2
   
   ## Verifying this change
   
   Manually tested on minikube
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #323: [FLINK-28207] Improve webhook helm configuration

Posted by GitBox <gi...@apache.org>.
gyfora merged PR #323:
URL: https://github.com/apache/flink-kubernetes-operator/pull/323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #323: [FLINK-28207] Improve webhook helm configuration

Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #323:
URL: https://github.com/apache/flink-kubernetes-operator/pull/323#issuecomment-1189180965

   +1 LGTM, tested locally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #323: [FLINK-28207] Improve webhook helm configuration

Posted by GitBox <gi...@apache.org>.
morhidi commented on code in PR #323:
URL: https://github.com/apache/flink-kubernetes-operator/pull/323#discussion_r924632811


##########
helm/flink-kubernetes-operator/values.yaml:
##########
@@ -83,8 +83,10 @@ webhookSecurityContext: {}
 
 webhook:
   create: true
-  mutator:
-    create: true
+  # validator:
+  #   create: true
+  # mutator:
+  #   create: false

Review Comment:
   to me this suggests the mutator default is false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #323: [FLINK-28207] Improve webhook helm configuration

Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #323:
URL: https://github.com/apache/flink-kubernetes-operator/pull/323#discussion_r924644841


##########
helm/flink-kubernetes-operator/values.yaml:
##########
@@ -83,8 +83,10 @@ webhookSecurityContext: {}
 
 webhook:
   create: true
-  mutator:
-    create: true
+  # validator:
+  #   create: true
+  # mutator:
+  #   create: false

Review Comment:
   my mistake :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org