You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "olaky (via GitHub)" <gi...@apache.org> on 2023/02/22 12:31:20 UTC
[GitHub] [spark] olaky opened a new pull request, #40124: [SPARK-37980] Access row_index via _metadata if possible in tests
olaky opened a new pull request, #40124:
URL: https://github.com/apache/spark/pull/40124
### What changes were proposed in this pull request?
Use '_metadata.row_index' in tests when that is possible, given that this is the preferred way to access Row Index.
### Why are the changes needed?
To add test coverage for reading '_metadata.row_index'
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Just test changes here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] olaky commented on pull request #40124: [SPARK-37980][SQL] Access row_index via _metadata if possible in tests
Posted by "olaky (via GitHub)" <gi...@apache.org>.
olaky commented on PR #40124:
URL: https://github.com/apache/spark/pull/40124#issuecomment-1448303753
@HyukjinKwon can you review this please / find a reviewer for me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #40124: [SPARK-37980][SQL] Access row_index via _metadata if possible in tests
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #40124:
URL: https://github.com/apache/spark/pull/40124#issuecomment-1496815727
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #40124: [SPARK-37980][SQL] Access row_index via _metadata if possible in tests
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #40124: [SPARK-37980][SQL] Access row_index via _metadata if possible in tests
URL: https://github.com/apache/spark/pull/40124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] olaky commented on pull request #40124: [SPARK-37980][SQL] Access row_index via _metadata if possible in tests
Posted by "olaky (via GitHub)" <gi...@apache.org>.
olaky commented on PR #40124:
URL: https://github.com/apache/spark/pull/40124#issuecomment-1493874156
@cloud-fan can this be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org