You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (JIRA)" <ji...@apache.org> on 2012/07/18 19:31:34 UTC

[jira] [Created] (HBASE-6420) Gracefully shutdown logsyncer

Jimmy Xiang created HBASE-6420:
----------------------------------

             Summary: Gracefully shutdown logsyncer
                 Key: HBASE-6420
                 URL: https://issues.apache.org/jira/browse/HBASE-6420
             Project: HBase
          Issue Type: Bug
          Components: wal
            Reporter: Jimmy Xiang


Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417944#comment-13417944 ] 

Hudson commented on HBASE-6420:
-------------------------------

Integrated in HBase-TRUNK #3146 (See [https://builds.apache.org/job/HBase-TRUNK/3146/])
    HBASE-6420 Gracefully shutdown logsyncer (Revision 1363180)

     Result = SUCCESS
jxiang : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java

                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang reassigned HBASE-6420:
----------------------------------

    Assignee: Jimmy Xiang
    
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418474#comment-13418474 ] 

Hudson commented on HBASE-6420:
-------------------------------

Integrated in HBase-0.94 #340 (See [https://builds.apache.org/job/HBase-0.94/340/])
    HBASE-6420 Gracefully shutdown logsyncer (Revision 1363416)

     Result = FAILURE
jxiang : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java

                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417822#comment-13417822 ] 

Jimmy Xiang commented on HBASE-6420:
------------------------------------

I removed logSyncerThread.interrupt(); in the HLog.close() method.  Any other place I missed?
                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl closed HBASE-6420.
--------------------------------

    
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.94.1, 0.96.0
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6420:
-------------------------------

    Attachment: 6420-trunk.patch
    
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417824#comment-13417824 ] 

Hadoop QA commented on HBASE-6420:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12537082/6420-trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

    -1 findbugs.  The patch appears to introduce 12 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2403//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2403//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2403//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2403//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2403//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2403//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2403//console

This message is automatically generated.
                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428730#comment-13428730 ] 

Hudson commented on HBASE-6420:
-------------------------------

Integrated in HBase-0.94-security-on-Hadoop-23 #6 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/6/])
    HBASE-6420 Gracefully shutdown logsyncer (Revision 1363416)

     Result = FAILURE
jxiang : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java

                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418063#comment-13418063 ] 

Lars Hofhansl commented on HBASE-6420:
--------------------------------------

Is this needed in 0.94?
                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418504#comment-13418504 ] 

Lars Hofhansl commented on HBASE-6420:
--------------------------------------

Thanks Jimmy.
                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417817#comment-13417817 ] 

stack commented on HBASE-6420:
------------------------------

How does this fix it Jimmy?  I don't see your remove of our interrupting a sync'ing thread.


                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418058#comment-13418058 ] 

ramkrishna.s.vasudevan commented on HBASE-6420:
-----------------------------------------------

@Jimmy
{code}
 while(!this.isInterrupted() && !closeLogSyncer.get()) {
{code}
!this.isInterrupted() is it still needed now? Because from the patch i see we are not interrupting the thread.
                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6420:
-------------------------------

       Resolution: Fixed
    Fix Version/s: 0.96.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Integrated to trunk.  Thank Stack for reviewing it.
                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418420#comment-13418420 ] 

Jimmy Xiang commented on HBASE-6420:
------------------------------------

@Ram, !this.isInterrupted() probably is not needed any more.  But it doesn't hurt so I didn't remove it.

@Lars, I just integrated it to 0.94.
                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418226#comment-13418226 ] 

Hudson commented on HBASE-6420:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #99 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/99/])
    HBASE-6420 Gracefully shutdown logsyncer (Revision 1363180)

     Result = FAILURE
jxiang : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java

                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419653#comment-13419653 ] 

Hudson commented on HBASE-6420:
-------------------------------

Integrated in HBase-0.94-security #44 (See [https://builds.apache.org/job/HBase-0.94-security/44/])
    HBASE-6420 Gracefully shutdown logsyncer (Revision 1363416)

     Result = FAILURE
jxiang : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java

                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417829#comment-13417829 ] 

stack commented on HBASE-6420:
------------------------------

I missed that.

+1
                
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6420:
-------------------------------

    Status: Patch Available  (was: Open)
    
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6420) Gracefully shutdown logsyncer

Posted by "Jimmy Xiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-6420:
-------------------------------

    Fix Version/s: 0.94.1
    
> Gracefully shutdown logsyncer
> -----------------------------
>
>                 Key: HBASE-6420
>                 URL: https://issues.apache.org/jira/browse/HBASE-6420
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: 6420-trunk.patch
>
>
> Currently, in closing a HLog, logSyncerThread is interrupted. logSyncer could be in the middle to sync the writer.  We should avoid interrupting the sync.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira