Re: svn commit: r1785464 - in /jmeter/trunk: src/core/org/apache/jmeter/reporters/ResultCollector.java xdocs/changes.xml

[Philippe Mouawad <ph...@gmail.com>]

Hi sebb,
Is it a regression ?
It's strange I never faced issue until now with high number of threads.

How do we explain it ?

Thanks

On Saturday, March 4, 2017, <fs...@apache.org> wrote:

> Author: fschumacher
> Date: Sat Mar  4 10:55:15 2017
> New Revision: 1785464
>
> URL: http://svn.apache.org/viewvc?rev=1785464&view=rev
> Log:
> Synchronize file access while writing CSV data.
>
> Bugzilla Id: 60818
>
> Modified:
>     jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
>     jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/reporters/
> ResultCollector.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> apache/jmeter/reporters/ResultCollector.java?rev=
> 1785464&r1=1785463&r2=1785464&view=diff
> ============================================================
> ==================
> --- jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
> Sat Mar  4 10:55:15 2017
> @@ -544,7 +544,9 @@ public class ResultCollector extends Abs
>                          SaveService.saveSampleResult(event, out);
>                      } else { // !saveAsXml
>                          String savee = CSVSaveService.
> resultToDelimitedString(event);
> -                        out.println(savee);
> +                        synchronized (LOCK) {
> +                            out.println(savee);
> +                        }
>                      }
>                  } catch (Exception err) {
>                      log.error("Error trying to record a sample", err); //
> should throw exception back to caller
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
> xml?rev=1785464&r1=1785463&r2=1785464&view=diff
> ============================================================
> ==================
> --- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
> +++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Mar  4 10:55:15 2017
> @@ -338,6 +338,7 @@ This affects configuration and 3rd party
>      <li><bug>60621</bug>The "<code>report-template</code>" folder is
> missing from <code>ApacheJMeter_config-3.1.jar</code> in maven
> central</li>
>      <li><bug>60744</bug>GUI elements are not cleaned up when reused
> during load of Test Plan which can lead them to be partially initialized
> with a previous state for a new Test Element</li>
>      <li><bug>60812</bug>JMeterThread does not honor contract of
> JMeterStopTestNowException</li>
> +    <li><bug>60818</bug>Synchronize file access while writing CSV
> data.</li>
>  </ul>
>
>   <!--  =================== Thanks =================== -->
>
>
>

-- 
Cordialement.
Philippe Mouawad.