You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Bill Stoddard <st...@raleigh.ibm.com> on 2000/02/22 15:40:29 UTC
Apache 2.0 chunked encoding broken
Size of actual data is 2 bytes larger than chunk size indicates. I will not
be able to investigate until later this week or perhaps next week. FYI in
case someone is itching for something to do :-)
________________________________________________
Bill Stoddard stoddard@raleigh.ibm.com
Come to the first official Apache Software Foundation
Conference! <http://ApacheCon.Com/>
Re: Apache 2.0 chunked encoding broken
Posted by Manoj Kasichainula <ma...@io.com>.
On Tue, Feb 22, 2000 at 09:40:29AM -0500, Bill Stoddard wrote:
> Size of actual data is 2 bytes larger than chunk size indicates.
Back when I unerrnoed buff, I don't think there were any dynamic
content modules working, so I didn't test chunking. I'm guessing that
I broke something. I'm looking at those changes now.
Re: [PATCH] Fix 2.0 chunking. Needs review.
Posted by Manoj Kasichainula <ma...@io.com>.
> > 15k file so far; I'll test more later.
I've tested with output of a few different sizes from 2k and up (with
mod_include), and everything seems to be working fine.
> > The patch worries me a bit,
> > because I don't know why the change is required.
On Thu, Mar 02, 2000 at 01:21:17AM -0500, Bill Stoddard wrote:
> Errr, then -1. Come back when you know exactly what's happening :-)
Well, I should clarify what I meant. The changes I made have the
effect I expect, and I think I understand what's going on now. But the
2.0 code before my fix looks like the 1.3 code, and I have no idea why
the 1.3 code looks like it does. :)
I still want someone who understands the buff code better than I do to
review it, though.
Re: [PATCH] Fix 2.0 chunking. Needs review.
Posted by Bill Stoddard <st...@raleigh.ibm.com>.
> 15k file so far; I'll test more later. The patch worries me a bit,
> because I don't know why the change is required.
Errr, then -1. Come back when you know exactly what's happening :-)
Bill
[PATCH] Fix 2.0 chunking. Needs review.
Posted by Manoj Kasichainula <ma...@io.com>.
On Wed, Mar 01, 2000 at 09:53:31PM -0600, Me at IO wrote:
> Yup, the problem is that an extra CRLF is getting tacked on. I'm still
> looking into it, I promise.
Here's a patch that seems to fix things. I've only tested it with a
15k file so far; I'll test more later. The patch worries me a bit,
because I don't know why the change is required. I don't understand
the chunking code very well, but this seems to be the most symmetric
solution.
Re: Apache 2.0 chunked encoding broken
Posted by Manoj Kasichainula <ma...@io.com>.
On Tue, Feb 22, 2000 at 09:40:29AM -0500, Bill Stoddard wrote:
> Size of actual data is 2 bytes larger than chunk size indicates. I will not
> be able to investigate until later this week or perhaps next week. FYI in
> case someone is itching for something to do :-)
Yup, the problem is that an extra CRLF is getting tacked on. I'm still
looking into it, I promise.