You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2023/05/31 12:43:34 UTC

[GitHub] [yunikorn-k8shim] FrankYang0529 opened a new pull request, #606: [YUNIKORN-1775] add namespaces permission to admission cluster role

FrankYang0529 opened a new pull request, #606:
URL: https://github.com/apache/yunikorn-k8shim/pull/606

   ### What is this PR for?
   
   Admission cluster role doesn't have enough permission to run admission.
   
   ### What type of PR is it?
   * [X] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/browse/YUNIKORN-1775
   
   ### How should this be tested?
   
   Using a new cluster to deploy the admission controller. It should not have any error.
   
   ```
   kubectl create namespace yunikorn
   kubectl apply -f deployments/scheduler/admission-controller-rbac.yaml --namespace yunikorn
   kubectl apply -f deployments/scheduler/admission-controller-secrets.yaml --namespace yunikorn
   kubectl apply -f deployments/scheduler/admission-controller.yaml --namespace yunikorn
   ```
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-k8shim] craigcondit closed pull request #606: [YUNIKORN-1775] add namespaces permission to admission cluster role

Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #606: [YUNIKORN-1775] add namespaces permission to admission cluster role
URL: https://github.com/apache/yunikorn-k8shim/pull/606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org