[jira] [Commented] (CALCITE-6895) Change JdbcTest.testVersion to strictly match minor version in gradle.properties

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936009#comment-17936009 ] 

Stamatis Zampetakis commented on CALCITE-6895:
----------------------------------------------

Previously whenever this failure occurred during the release the RM was bumping up upper bound by +10 but this does not make much sense. Either we remove the check altogether or we make it strict as proposed in the PR. 

> Change JdbcTest.testVersion to strictly match minor version in gradle.properties
> --------------------------------------------------------------------------------
>
>                 Key: CALCITE-6895
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6895
>             Project: Calcite
>          Issue Type: Task
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.40.0
>
>
> A [recent bump|https://github.com/apache/calcite/commit/f0195df7fe18b8d99d5e1d259a3e35834e4c77e2] of calcite.version to 1.40.0 broke {{JdbcTest.test}} version cause the following condition was no longer true.
> {code:java}
>     assertTrue(driverMinor >= 0 && driverMinor < 40);
> {code}
> If we want to test that versions in properties really match those in JDBC it makes more sense to have strict equality instead of range. The drawback is that we have to update the test after every version bump.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)