You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2024/10/27 08:00:18 UTC

[PR] testing/cmocka: shuffling test sequence and pass seed arg [nuttx-apps]

xiaoxiang781216 opened a new pull request, #2783:
URL: https://github.com/apache/nuttx-apps/pull/2783

   ## Summary
   
   set CMOCKA_SHUFFLE_SEED environment variable
   
   ## Impact
   
   cmocka launcher
   
   ## Testing
   
   ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] testing/cmocka: shuffling test sequence and pass seed arg [nuttx-apps]

Posted by "GUIDINGLI (via GitHub)" <gi...@apache.org>.
GUIDINGLI merged PR #2783:
URL: https://github.com/apache/nuttx-apps/pull/2783


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] testing/cmocka: shuffling test sequence and pass seed arg [nuttx-apps]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2783:
URL: https://github.com/apache/nuttx-apps/pull/2783#issuecomment-2439897759

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   This PR appears to be **missing critical information** according to the NuttX requirements. 
   
   **Here's what's lacking and needs clarification:**
   
   * **Summary:**
       * **Why is this change necessary?**  What problem does setting CMOCKA_SHUFFLE_SEED solve? Is it a bug fix, performance improvement, or new feature?
       * **What exactly changes?** How does setting this environment variable affect the cmocka launcher's behavior? 
   * **Impact:**
       * **Be specific about the impact.**  "cmocka launcher" is too vague. Does this affect all users of cmocka? Only specific configurations?  Will existing tests behave differently?
       * **Address all impact points:**  The template asks about build process, hardware, documentation, security, compatibility. Even if the answer is "NO," state it explicitly for each.
   * **Testing:**
       * **"ci" is not sufficient testing information.** 
           * Which CI environments were used?  List specific architectures and boards.
           *  Provide relevant snippets of the logs demonstrating the change in behavior. What were the results before and after the change?
   
   **Recommendation:**
   
   Expand on each section with specific details. This will help reviewers understand the purpose and scope of your change, leading to a faster and smoother review process. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org