You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by contradictioned <gi...@git.apache.org> on 2018/10/26 09:23:45 UTC
[GitHub] storm pull request #2896: Storm 3261
GitHub user contradictioned opened a pull request:
https://github.com/apache/storm/pull/2896
Storm 3261
As I wrote in the [issue](https://issues.apache.org/jira/browse/STORM-3261) I found that some pages were not generated due to missing YAML headers. Since the files are linked from the index page, I belive they are intended to be rendered.
I added them and by the way also fixed some broken links.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/contradictioned/storm STORM-3261
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2896.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2896
----
commit e996abce19ce535599dab1bb90977d0056a9ad97
Author: Manuel Dossinger <ma...@...>
Date: 2018-10-26T09:18:03Z
Added missing YAML headers, so jekyll generates the html files.
commit 64ce3e0853531e550f31280fe4285f16aaebda1f
Author: Manuel Dossinger <ma...@...>
Date: 2018-10-26T09:18:27Z
Fixed broken links
----
---
[GitHub] storm issue #2896: Storm 3261
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2896
@d2r You can test this by checking out https://github.com/apache/storm-site and following the guide for publishing the documentation
---
[GitHub] storm issue #2896: Storm 3261
Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2896
@contradictioned Great work, BTW, can we rename the title to "[Storm-3261] intent of this PR" format ?
---
[GitHub] storm pull request #2896: Storm 3261
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2896#discussion_r228595224
--- Diff: docs/storm-sql-reference.md ---
@@ -189,7 +189,7 @@ may refer to tables in the FROM clause of an enclosing query.
*selectWithoutFrom* is equivalent to VALUES,
but is not standard SQL and is only allowed in certain
-[conformance levels]({{ site.apiRoot }}/org/apache/calcite/sql/validate/SqlConformance.html#isFromRequired--).
+[conformance levels](https://calcite.apache.org/apidocs/org/apache/calcite/sql/validate/SqlConformance.html#isFromRequired--).
--- End diff --
Right, makes sense.
---
[GitHub] storm pull request #2896: Storm 3261
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2896#discussion_r228547067
--- Diff: docs/storm-sql-reference.md ---
@@ -189,7 +189,7 @@ may refer to tables in the FROM clause of an enclosing query.
*selectWithoutFrom* is equivalent to VALUES,
but is not standard SQL and is only allowed in certain
-[conformance levels]({{ site.apiRoot }}/org/apache/calcite/sql/validate/SqlConformance.html#isFromRequired--).
+[conformance levels](https://calcite.apache.org/apidocs/org/apache/calcite/sql/validate/SqlConformance.html#isFromRequired--).
--- End diff --
Can we avoid hard-coding the host?
---
[GitHub] storm pull request #2896: [Storm-3261] Fix broken links in documentation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2896
---
[GitHub] storm pull request #2896: Storm 3261
Posted by contradictioned <gi...@git.apache.org>.
Github user contradictioned commented on a diff in the pull request:
https://github.com/apache/storm/pull/2896#discussion_r228593608
--- Diff: docs/storm-sql-reference.md ---
@@ -189,7 +189,7 @@ may refer to tables in the FROM clause of an enclosing query.
*selectWithoutFrom* is equivalent to VALUES,
but is not standard SQL and is only allowed in certain
-[conformance levels]({{ site.apiRoot }}/org/apache/calcite/sql/validate/SqlConformance.html#isFromRequired--).
+[conformance levels](https://calcite.apache.org/apidocs/org/apache/calcite/sql/validate/SqlConformance.html#isFromRequired--).
--- End diff --
In other instances, there is just a link beginning with `javadocs` leading to the local copy of generated javadoc (e.g., to http://storm.apache.org/releases/1.2.2/javadocs/... ), but `org.apache.calcite.sql` is not included there. So I don't think so.
---