[jira] [Commented] (YARN-10342) [UI1] Provide a way to hide Tools section in Web UIv1

["Bilwa S T (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171655#comment-17171655 ] 

Bilwa S T commented on YARN-10342:
----------------------------------

Thanks [~gandras] for the patch.
I have a following comments
1. NavBlock in Nodemanager package already has a conf object. No need to create conf object again.
2. Instead of creating conf object everytime . You can inject it like below in the constructor

{code:java}
@Inject
  public NavBlock(Configuration conf) {
	 this.conf = conf;
  }
{code}


> [UI1] Provide a way to hide Tools section in Web UIv1
> -----------------------------------------------------
>
>                 Key: YARN-10342
>                 URL: https://issues.apache.org/jira/browse/YARN-10342
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Minor
>         Attachments: Screenshot 2020-07-09 at 14.13.19.png, YARN-10342.001.patch, YARN-10342.002.patch
>
>
> The Tools section in web UI1 might contain sensitive information, which should ideally be hidden from end users. We should provide a configurable value to hide it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org