You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/15 06:09:57 UTC

[GitHub] [airflow] dstandish commented on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql

dstandish commented on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecation warning for pymssql
URL: https://github.com/apache/airflow/pull/6850#issuecomment-613837077
 
 
   one reason i thought it would be nice to cherry pick this is so that users could switch to odbc (from pymssql) ahead of, and independent of, the 2.0 upgrade.
   
   i suspect that the reason you guys did not want to cherry pick is because it introduces deprecation of the pymssql-based mssqlhook, and therefore, without intervention, implicitly deprecates MSSQLToGCSOperator and MsSqlToHiveTransfer?
   
   if so, @gflores1023, this is another way you contribute and help move this along.  the only thing that needs to be sorted out is the type map --- from the pyodbc return types to gcs / hive.  then these operators can be adapted to work with odbc hook also, in the same manner as was done with MsSqlOperator.
   
   but i dunno maybe there was also some unrelated ambivalence about deprecating pymssql spport, or other unrelated concerns with the hook?
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services