You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by si...@apache.org on 2013/12/09 22:42:36 UTC
svn commit: r1549689 - in /lucene/dev/branches/branch_4x: ./ lucene/
lucene/test-framework/
lucene/test-framework/src/java/org/apache/lucene/search/RandomSimilarityProvider.java
Author: simonw
Date: Mon Dec 9 21:42:36 2013
New Revision: 1549689
URL: http://svn.apache.org/r1549689
Log:
Fix RandomSimilarityProvider Math#abs can return negative value for Integer.MIN_VALUE
Modified:
lucene/dev/branches/branch_4x/ (props changed)
lucene/dev/branches/branch_4x/lucene/ (props changed)
lucene/dev/branches/branch_4x/lucene/test-framework/ (props changed)
lucene/dev/branches/branch_4x/lucene/test-framework/src/java/org/apache/lucene/search/RandomSimilarityProvider.java
Modified: lucene/dev/branches/branch_4x/lucene/test-framework/src/java/org/apache/lucene/search/RandomSimilarityProvider.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/lucene/test-framework/src/java/org/apache/lucene/search/RandomSimilarityProvider.java?rev=1549689&r1=1549688&r2=1549689&view=diff
==============================================================================
--- lucene/dev/branches/branch_4x/lucene/test-framework/src/java/org/apache/lucene/search/RandomSimilarityProvider.java (original)
+++ lucene/dev/branches/branch_4x/lucene/test-framework/src/java/org/apache/lucene/search/RandomSimilarityProvider.java Mon Dec 9 21:42:36 2013
@@ -103,7 +103,7 @@ public class RandomSimilarityProvider ex
assert field != null;
Similarity sim = previousMappings.get(field);
if (sim == null) {
- sim = knownSims.get(Math.abs(perFieldSeed ^ field.hashCode()) % knownSims.size());
+ sim = knownSims.get(Math.max(0, Math.abs(perFieldSeed ^ field.hashCode())) % knownSims.size());
previousMappings.put(field, sim);
}
return sim;