You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/07/19 19:40:50 UTC

Review Request 36604: Preemptively fail tests if previous invocations failed.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36604/
-----------------------------------------------------------

Review request for mesos, Ian Downes and Timothy Chen.


Bugs: MESOS-3079
    https://issues.apache.org/jira/browse/MESOS-3079


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a 

Diff: https://reviews.apache.org/r/36604/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request 36604: Preemptively fail tests if previous invocations failed.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36604/#review92214
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On July 19, 2015, 5:54 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36604/
> -----------------------------------------------------------
> 
> (Updated July 19, 2015, 5:54 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-3079
>     https://issues.apache.org/jira/browse/MESOS-3079
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a 
> 
> Diff: https://reviews.apache.org/r/36604/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 36604: Preemptively fail tests if previous invocations failed.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36604/
-----------------------------------------------------------

(Updated July 19, 2015, 5:54 p.m.)


Review request for mesos, Ian Downes and Timothy Chen.


Bugs: MESOS-3079
    https://issues.apache.org/jira/browse/MESOS-3079


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a 

Diff: https://reviews.apache.org/r/36604/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request 36604: Preemptively fail tests if previous invocations failed.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36604/#review92209
-----------------------------------------------------------

Ship it!


Doesn't solve the underlying problem but helps understand what is happening and how to fix it manually.

- Joerg Schad


On July 19, 2015, 5:40 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36604/
> -----------------------------------------------------------
> 
> (Updated July 19, 2015, 5:40 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Timothy Chen.
> 
> 
> Bugs: MESOS-3079
>     https://issues.apache.org/jira/browse/MESOS-3079
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a 
> 
> Diff: https://reviews.apache.org/r/36604/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>