You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/21 08:16:16 UTC
[GitHub] [trafficserver] maskit opened a new pull request #7959: Implement TLSBasicSupport for QUICNetVC
maskit opened a new pull request #7959:
URL: https://github.com/apache/trafficserver/pull/7959
This makes `TSVConnSslCipherGet`, `TSVConnSslProtocolGet`, and `TSVConnSslCurveGet` available on QUIC connections. The APIs themselves have already been modified to use TLSBasicSupport on #7556.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7959: Implement TLSBasicSupport for QUICNetVC
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on a change in pull request #7959:
URL: https://github.com/apache/trafficserver/pull/7959#discussion_r655685523
##########
File path: iocore/net/QUICNetVConnection.cc
##########
@@ -2412,6 +2418,26 @@ QUICNetVConnection::_handle_periodic_ack_event()
}
}
+SSL *
+QUICNetVConnection::_get_ssl_object() const
+{
+ auto tls = dynamic_cast<QUICTLS *>(this->_hs_protocol);
Review comment:
Can this be anything other than `QUICTLS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #7959: Implement TLSBasicSupport for QUICNetVC
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on a change in pull request #7959:
URL: https://github.com/apache/trafficserver/pull/7959#discussion_r655685523
##########
File path: iocore/net/QUICNetVConnection.cc
##########
@@ -2412,6 +2418,26 @@ QUICNetVConnection::_handle_periodic_ack_event()
}
}
+SSL *
+QUICNetVConnection::_get_ssl_object() const
+{
+ auto tls = dynamic_cast<QUICTLS *>(this->_hs_protocol);
Review comment:
Can this be anything other than `QUICTLS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on a change in pull request #7959: Implement TLSBasicSupport for QUICNetVC
Posted by GitBox <gi...@apache.org>.
maskit commented on a change in pull request #7959:
URL: https://github.com/apache/trafficserver/pull/7959#discussion_r655801881
##########
File path: iocore/net/QUICNetVConnection.cc
##########
@@ -2412,6 +2418,26 @@ QUICNetVConnection::_handle_periodic_ack_event()
}
}
+SSL *
+QUICNetVConnection::_get_ssl_object() const
+{
+ auto tls = dynamic_cast<QUICTLS *>(this->_hs_protocol);
Review comment:
No, it's always `QUICTLS` at the moment because QUIC version 1 depends on TLS 1.3. QUIC version 2 may use something else.
I was thinking it's better to use `dynamic_cast` because version 2 may not use TLS, but on second thought, we should have another netvc type if version 2 doesn't use TLS. Because having TLSBasicSupport doesn't make sense if it doesn't use TLS. It would be tricky if version 2 supported multiple handshake protocols, but that wouldn't happen soon.
I'm going to change it to static_cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #7959: Implement TLSBasicSupport for QUICNetVC
Posted by GitBox <gi...@apache.org>.
maskit merged pull request #7959:
URL: https://github.com/apache/trafficserver/pull/7959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on a change in pull request #7959: Implement TLSBasicSupport for QUICNetVC
Posted by GitBox <gi...@apache.org>.
maskit commented on a change in pull request #7959:
URL: https://github.com/apache/trafficserver/pull/7959#discussion_r655801881
##########
File path: iocore/net/QUICNetVConnection.cc
##########
@@ -2412,6 +2418,26 @@ QUICNetVConnection::_handle_periodic_ack_event()
}
}
+SSL *
+QUICNetVConnection::_get_ssl_object() const
+{
+ auto tls = dynamic_cast<QUICTLS *>(this->_hs_protocol);
Review comment:
No, it's always `QUICTLS` at the moment because QUIC version 1 depends on TLS 1.3. QUIC version 2 may use something else.
I was thinking it's better to use `dynamic_cast` because version 2 may not use TLS, but on second thought, we should have another netvc type if version 2 doesn't use TLS. Because having TLSBasicSupport doesn't make sense if it doesn't use TLS. It would be tricky if version 2 supported multiple handshake protocols, but that wouldn't happen soon.
I'm going to change it to static_cast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org