[GitHub] [superset] ktmud edited a comment on issue #12631: [discuss]Should we remove the "+" icon for single metric control?

[GitBox <gi...@apache.org>]

ktmud edited a comment on issue #12631:
URL: https://github.com/apache/superset/issues/12631#issuecomment-768118614


   Hi, @srinify and @villebro , thanks for the inputs! Most of my UX suggestions are based on my intuition, and sometimes I may have not explained myself too well. It's nice to see someone else articulate the benefits of a proposed design better than me.
   
   I agree we don't have to implemented this right away and I never expected it to be. The whole thing is just a proposal and if 
   there are strong reasons of objections or better alternatives, I'd be happy to drop it.
   
   But I don't believe this particular proposal is blocked by design resources as the proposal is pretty clear/simple and basically just an extension of the existing design. As an open source project, a lot of discussions for Superset happens asynchronously like this on Github issues. "Proper design review" would be a luxury for most cases. I'd be happy to hear designers' opinion on this, but sometimes we should not have to wait, exactly because how severely constrained the design resources are.
   
   Also comment on these two points:
   
   > 1. Original design is proposed by Cartel in SIP 34 with a fair amount of research went it. it has served as a design Northstar in the product
   
   IMO, SIP-34 is more like a north star for design atheistic, rather than every detail of all the UX. Nothing is set on stone. It's quite natural that issues come up when a design mockup is being actually implemented. We should be more flexible here and open to changes. Plus, I could be wrong, but SIP-34 mockup doesn't even have an empty state for these controls, indicating this area was probably not carefully considered to begin with.
   
   > Superset design system guidelines are not fully baked yet. Until they are ready, we try to avoid changing back and forth
   
   IMO this is a step forward, not back. Unless we believe the "+" icon will have to come back at some point, it's relatively low-risk. It's true introducing new UX patterns may break user habits they just got used to, but his particular proposal is not a new pattern as users would be quite familiar with the ghost button anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org