You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jiacai2050 (via GitHub)" <gi...@apache.org> on 2023/02/02 04:11:55 UTC
[GitHub] [arrow-datafusion] jiacai2050 opened a new pull request, #5155: chore: add object_name_to_table_reference in SqlToRel
jiacai2050 opened a new pull request, #5155:
URL: https://github.com/apache/arrow-datafusion/pull/5155
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
This is a followup PR for #5124, which add add method in SqlToRel to simplify calls to `object_name_to_table_reference`.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
- Add method: `object_name_to_table_reference`
- Update docs to include `sql_parser` options
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
CI itself.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5155: chore: add object_name_to_table_reference in SqlToRel
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5155:
URL: https://github.com/apache/arrow-datafusion/pull/5155#issuecomment-1416413204
Benchmark runs are scheduled for baseline = 953d16ba8f89d99650e3a29cd2da29de1daf5493 and contender = c323721192ba2733a56c4201b2255a36b1eaa859. c323721192ba2733a56c4201b2255a36b1eaa859 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b31dce71a8ad43888bdb848f5f1f72c1...fb1588fe0bec4b61ac38265b228821ac/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/58304e7e266e4bde98a38f8b451e6539...381d426b86d946c2bba0b37310c5eaea/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a38cf8316a1a4bacb6a5a78a171525ea...24ebc55924634fc5a8c0385fe0f1e33b/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d91cc79f9a3644508bbd6774113494e3...7d37363f60d842a68b2b85509fc8dc1d/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5155: chore: add object_name_to_table_reference in SqlToRel
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5155:
URL: https://github.com/apache/arrow-datafusion/pull/5155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5155: chore: add object_name_to_table_reference in SqlToRel
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5155:
URL: https://github.com/apache/arrow-datafusion/pull/5155#discussion_r1094817267
##########
datafusion/sql/src/relation/mod.rs:
##########
@@ -33,10 +31,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let (plan, alias) = match relation {
TableFactor::Table { name, alias, .. } => {
// normalize name and alias
- let table_ref = object_name_to_table_reference(
- name,
- self.options.enable_ident_normalization,
- )?;
+ let table_ref = self.object_name_to_table_reference(name)?;
Review Comment:
👍
##########
docs/source/user-guide/configs.md:
##########
@@ -69,3 +69,5 @@ Environment variables are read during `SessionConfig` initialisation so they mus
| datafusion.optimizer.hash_join_single_partition_threshold | 1048576 | The maximum estimated size in bytes for one input side of a HashJoin will be collected into a single partition |
| datafusion.explain.logical_plan_only | false | When set to true, the explain statement will only print logical plans |
| datafusion.explain.physical_plan_only | false | When set to true, the explain statement will only print physical plans |
+| datafusion.sql_parser.parse_float_as_decimal | false | When set to true, sql parser will parse float as decimal type |
Review Comment:
Thank you for this too 👍
##########
datafusion/common/src/config.rs:
##########
@@ -181,10 +181,10 @@ config_namespace! {
config_namespace! {
/// Options related to SQL parser
pub struct SqlParserOptions {
- /// Whether to parse float as decimal
+ /// When set to true, sql parser will parse float as decimal type
pub parse_float_as_decimal: bool, default = false
- /// Whether to normalize ident
+ /// When set to true, sql parser will normalize ident(convert ident to lowercase when not quoted)
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org