You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/31 04:32:06 UTC

[GitHub] [arrow-datafusion] viirya commented on a change in pull request #1506: Fix ORDER BY on aggregate

viirya commented on a change in pull request #1506:
URL: https://github.com/apache/arrow-datafusion/pull/1506#discussion_r776923224



##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1317,6 +1319,83 @@ pub fn normalize_cols(
         .collect()
 }
 
+/// Rewrite sort on aggregate expressions to sort on the column of aggregate output
+#[inline]

Review comment:
       Hmm, I saw there is `#[inline]` for `normalize_cols` above. `rewrite_sort_cols_by_aggs`'s looks similar (i.e., `into_iter().map().collect()`), so I added it too here. Should I remove it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org