You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dead-1ine (via GitHub)" <gi...@apache.org> on 2023/11/14 02:23:31 UTC
[PR] [MINOR][DOCS] Correct additional Conda documentation URL to fix 404 errors [spark]
dead-1ine opened a new pull request, #43794:
URL: https://github.com/apache/spark/pull/43794
- Remove trailing slash from Conda cheat sheet URL in 'Using Conda' section.
- Correct the Miniconda documentation URL by removing the trailing slash.
### What changes were proposed in this pull request?
In addition to removing the trailing slash from the Conda cheat sheet URL in the 'Using Conda' section, this update also corrects the Miniconda documentation URL in the same section by removing the trailing slash. These modifications are intended to resolve the 404 errors that occur when the current URLs with the trailing slashes are accessed.
### Why are the changes needed?
The changes are necessary because the existing URLs with trailing slashes lead to 404 errors, hindering users' access to the Conda cheat sheet and Miniconda documentation. Removing the slashes will ensure the links direct users to the correct webpages, improving the documentation's usability.
### Does this PR introduce _any_ user-facing change?
No. This change only affects the documentation and does not alter the functionality of the Spark software itself.
### How was this patch tested?
Both documentation fixes were visually inspected to ensure the corrected URLs resolve to the intended webpages without 404 errors. No additional code testing is necessary as these changes are strictly within the documentation.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Correct additional Conda documentation URL to fix 404 errors [spark]
Posted by "dead-1ine (via GitHub)" <gi...@apache.org>.
dead-1ine commented on PR #43794:
URL: https://github.com/apache/spark/pull/43794#issuecomment-1809557443
I'll check again... :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Correct additional Conda documentation URL to fix 404 errors [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43794:
URL: https://github.com/apache/spark/pull/43794#issuecomment-1811694428
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Correct additional Conda documentation URL to fix 404 errors [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43794:
URL: https://github.com/apache/spark/pull/43794#issuecomment-1811694361
I locally verified this change.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Correct additional Conda documentation URL to fix 404 errors [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43794:
URL: https://github.com/apache/spark/pull/43794#issuecomment-1809690097
I don't think the test failures are related. Mind retriggering at https://github.com/dead-1ine/spark/runs/18649023754?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Correct additional Conda documentation URL to fix 404 errors [spark]
Posted by "dead-1ine (via GitHub)" <gi...@apache.org>.
dead-1ine commented on PR #43794:
URL: https://github.com/apache/spark/pull/43794#issuecomment-1811789159
Thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Correct additional Conda documentation URL to fix 404 errors [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43794: [MINOR][DOCS] Correct additional Conda documentation URL to fix 404 errors
URL: https://github.com/apache/spark/pull/43794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org