You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/24 03:29:44 UTC
[GitHub] [skywalking] wankai123 opened a new pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
wankai123 opened a new pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608
### Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [X] Update the documentation to include this new feature.
- [X] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
Since K8s metrics collector can't provide the relationship between pods and services. I collector these info from `K8s API Server`, then we can add specific labels to the samples to build the relationship.
`k8sTagServiceByPodName(podName,serviceName)`.Add a sevice Label to the sample that already has a pod name.
For example:
```
container_cpu_usage_seconds_total{container=my-nginx, cpu=total, pod=my-nginx-5dc4865748-mbczh} 2
```
Expression:
```
container_cpu_usage_seconds_total.k8sTagServiceByPodName('pod' , 'service')
```
Output:
```
container_cpu_usage_seconds_total{container=my-nginx, cpu=total, pod=my-nginx-5dc4865748-mbczh, service='default:nginx-service'} 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `7.11%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 57.07% +7.11%
- Complexity 3645 4078 +433
============================================
Files 1010 998 -12
Lines 24979 25038 +59
Branches 2433 2439 +6
============================================
+ Hits 12479 14290 +1811
+ Misses 11433 9496 -1937
- Partials 1067 1252 +185
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.07% <0.00%> (+6.53%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [149 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `1.63%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 49.95% 48.31% -1.64%
+ Complexity 3645 3570 -75
============================================
Files 1010 998 -12
Lines 24979 24880 -99
Branches 2433 2429 -4
============================================
- Hits 12479 12022 -457
- Misses 11433 11817 +384
+ Partials 1067 1041 -26
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `3.52%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 55.37% -3.53%
+ Complexity 4185 3972 -213
============================================
Files 997 998 +1
Lines 24973 24895 -78
Branches 2436 2425 -11
============================================
- Hits 14710 13786 -924
- Misses 8976 9930 +954
+ Partials 1287 1179 -108
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [72 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `18.17%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 40.72% -18.18%
+ Complexity 4185 2511 -1674
=============================================
Files 997 844 -153
Lines 24973 21140 -3833
Branches 2436 2016 -420
=============================================
- Hits 14710 8609 -6101
- Misses 8976 11864 +2888
+ Partials 1287 667 -620
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.84% <0.00%> (-9.54%)` | `56.00 <0.00> (-7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [390 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `15.72%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 43.17% -15.73%
+ Complexity 4185 2664 -1521
=============================================
Files 997 843 -154
Lines 24973 21143 -3830
Branches 2436 2016 -420
=============================================
- Hits 14710 9129 -5581
- Misses 8976 11316 +2340
+ Partials 1287 698 -589
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [371 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `0.48%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 50.43% +0.48%
- Complexity 3645 3668 +23
============================================
Files 1010 998 -12
Lines 24979 24880 -99
Branches 2433 2429 -4
============================================
+ Hits 12479 12549 +70
+ Misses 11433 11230 -203
- Partials 1067 1101 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [132 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `9.50%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head bf8ada5. Consider uploading reports for the commit bf8ada5 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 49.39% -9.51%
+ Complexity 4185 3632 -553
============================================
Files 997 998 +1
Lines 24973 24863 -110
Branches 2436 2423 -13
============================================
- Hits 14710 12282 -2428
- Misses 8976 11517 +2541
+ Partials 1287 1064 -223
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [177 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...bf8ada5](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `7.65%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 51.24% -7.66%
+ Complexity 4185 3604 -581
============================================
Files 997 967 -30
Lines 24973 23930 -1043
Branches 2436 2335 -101
============================================
- Hits 14710 12263 -2447
- Misses 8976 10634 +1658
+ Partials 1287 1033 -254
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [195 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600189746
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
+ private final Map<String/* ip */, V1Pod> ipPodMap = new ConcurrentHashMap<>();
+ private final Map<String/* ip */, String/* namespace:serviceName */> ipServiceMap = new ConcurrentHashMap<>();
+ private final Map<String/* podName */, String /* namespace:serviceName*/> podServiceMap = new ConcurrentHashMap<>();
+ private ExecutorService executor;
+
+ public static K8sInfoRegistry getInstance() {
+ return INSTANCE;
+ }
+
+ private void init() {
+ executor = Executors.newCachedThreadPool(
+ new ThreadFactoryBuilder()
+ .setNameFormat("K8sInfoRegistry-%d")
+ .setDaemon(true)
+ .build()
+ );
+ }
+
+ @SneakyThrows
+ public void start(Rule rule) {
+ if (isStarted.compareAndSet(false, true)) {
+ if (!matchFunc2Start(rule)) {
+ return;
+ }
+ init();
+ final ApiClient apiClient = Config.defaultClient();
+ apiClient.setHttpClient(apiClient.getHttpClient()
+ .newBuilder()
+ .readTimeout(0, TimeUnit.SECONDS)
+ .build());
+ Configuration.setDefaultApiClient(apiClient);
+
+ final CoreV1Api coreV1Api = new CoreV1Api();
+ final SharedInformerFactory factory = new SharedInformerFactory(executor);
+
+ listenEndpointsEvents(coreV1Api, factory);
+ listenPodEvents(coreV1Api, factory);
+ factory.startAllRegisteredInformers();
+ }
+ }
+
+ private boolean matchFunc2Start(Rule rule) {
+ for (String mf : matchedFunc) {
+ return rule.getMetricsRules().stream().anyMatch(r -> r.getExp().split(mf).length > 1);
+
+ }
+ return false;
+ }
+
+ private void listenEndpointsEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listEndpointsForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Endpoints.class,
+ V1EndpointsList.class
+ ).addEventHandler(new ResourceEventHandler<V1Endpoints>() {
+ @Override
+ public void onAdd(final V1Endpoints endpoints) {
+ addEndpoints(endpoints);
+ }
+
+ @Override
+ public void onUpdate(final V1Endpoints oldEndpoints, final V1Endpoints newEndpoints) {
+ addEndpoints(newEndpoints);
+ }
+
+ @Override
+ public void onDelete(final V1Endpoints endpoints, final boolean deletedFinalStateUnknown) {
+ removeEndpoints(endpoints);
+ }
+ });
+ }
+
+ private void listenPodEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listPodForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Pod.class,
+ V1PodList.class
+ ).addEventHandler(new ResourceEventHandler<V1Pod>() {
+ @Override
+ public void onAdd(final V1Pod pod) {
+ addPod(pod);
+ }
+
+ @Override
+ public void onUpdate(final V1Pod oldPod, final V1Pod newPod) {
+ addPod(newPod);
+ }
+
+ @Override
+ public void onDelete(final V1Pod pod, final boolean deletedFinalStateUnknown) {
+ removePod(pod);
+ }
+ });
+ }
+
+ private void addPod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.put(status.getPodIP(), pod)
+ );
+
+ recompose();
+ }
+
+ private void removePod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.remove(status.getPodIP())
+ );
+ }
+
+ private void addEndpoints(final V1Endpoints endpoints) {
+ V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
+ if (isNull(endpointsMetadata)) {
+ log.error("Endpoints metadata is null: {}", endpoints);
+ return;
+ }
+
+ final String namespace = endpointsMetadata.getNamespace();
Review comment:
ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `2.84%`.
> The diff coverage is `11.82%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 38.98% 36.14% -2.85%
+ Complexity 2765 2183 -582
============================================
Files 1005 812 -193
Lines 24880 20078 -4802
Branches 2423 1898 -525
============================================
- Hits 9700 7257 -2443
+ Misses 14427 12266 -2161
+ Partials 753 555 -198
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `34.70% <0.00%> (-18.85%)` | `32.00 <0.00> (-23.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `12.82% <12.82%> (ø)` | `6.00 <6.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `6.84% <100.00%> (-83.43%)` | `2.00 <0.00> (-19.00)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...erver/storage/plugin/jdbc/h2/dao/H2MetricsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTWV0cmljc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [347 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `4.94%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 43.92% +4.94%
+ Complexity 2765 2701 -64
============================================
Files 1005 843 -162
Lines 24880 21153 -3727
Branches 2423 2018 -405
============================================
- Hits 9700 9292 -408
+ Misses 14427 11139 -3288
+ Partials 753 722 -31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.23% <0.00%> (-1.31%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [253 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `0.09%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 51.69% -0.10%
- Complexity 3754 3793 +39
============================================
Files 1010 997 -13
Lines 24989 24956 -33
Branches 2434 2433 -1
============================================
- Hits 12942 12902 -40
- Misses 10937 10956 +19
+ Partials 1110 1098 -12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.13% <18.18%> (+7.58%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [197 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `21.68%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 37.22% -21.69%
+ Complexity 4185 2318 -1867
=============================================
Files 997 844 -153
Lines 24973 21100 -3873
Branches 2436 2015 -421
=============================================
- Hits 14710 7854 -6856
- Misses 8976 12651 +3675
+ Partials 1287 595 -692
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [418 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `2.19%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 56.70% -2.20%
+ Complexity 4185 4094 -91
============================================
Files 997 999 +2
Lines 24973 25041 +68
Branches 2436 2442 +6
============================================
- Hits 14710 14200 -510
- Misses 8976 9631 +655
+ Partials 1287 1210 -77
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (-3.29%)` | `23.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.38% <0.00%> (-3.01%)` | `62.00 <0.00> (-1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [53 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `9.50%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head dd66816. Consider uploading reports for the commit dd66816 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 49.39% -9.51%
+ Complexity 4185 3632 -553
============================================
Files 997 998 +1
Lines 24973 24863 -110
Branches 2436 2423 -13
============================================
- Hits 14710 12282 -2428
- Misses 8976 11517 +2541
+ Partials 1287 1064 -223
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [177 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...dd66816](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `3.56%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 55.33% -3.57%
+ Complexity 4185 3966 -219
============================================
Files 997 998 +1
Lines 24973 24895 -78
Branches 2436 2425 -11
============================================
- Hits 14710 13776 -934
- Misses 8976 9940 +964
+ Partials 1287 1179 -108
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [77 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `8.39%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 50.50% -8.40%
+ Complexity 4185 3689 -496
============================================
Files 997 998 +1
Lines 24973 24833 -140
Branches 2436 2423 -13
============================================
- Hits 14710 12543 -2167
- Misses 8976 11242 +2266
+ Partials 1287 1048 -239
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [181 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600153886
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
+ private final Map<String/* ip */, V1Pod> ipPodMap = new ConcurrentHashMap<>();
+ private final Map<String/* ip */, String/* namespace:serviceName */> ipServiceMap = new ConcurrentHashMap<>();
+ private final Map<String/* podName */, String /* namespace:serviceName*/> podServiceMap = new ConcurrentHashMap<>();
+ private ExecutorService executor;
+
+ public static K8sInfoRegistry getInstance() {
+ return INSTANCE;
+ }
+
+ private void init() {
+ executor = Executors.newCachedThreadPool(
+ new ThreadFactoryBuilder()
+ .setNameFormat("K8sInfoRegistry-%d")
+ .setDaemon(true)
+ .build()
+ );
+ }
+
+ @SneakyThrows
+ public void start(Rule rule) {
+ if (isStarted.compareAndSet(false, true)) {
+ if (!matchFunc2Start(rule)) {
+ return;
+ }
+ init();
+ final ApiClient apiClient = Config.defaultClient();
+ apiClient.setHttpClient(apiClient.getHttpClient()
+ .newBuilder()
+ .readTimeout(0, TimeUnit.SECONDS)
+ .build());
+ Configuration.setDefaultApiClient(apiClient);
+
+ final CoreV1Api coreV1Api = new CoreV1Api();
+ final SharedInformerFactory factory = new SharedInformerFactory(executor);
+
+ listenEndpointsEvents(coreV1Api, factory);
+ listenPodEvents(coreV1Api, factory);
+ factory.startAllRegisteredInformers();
+ }
+ }
+
+ private boolean matchFunc2Start(Rule rule) {
+ for (String mf : matchedFunc) {
+ return rule.getMetricsRules().stream().anyMatch(r -> r.getExp().split(mf).length > 1);
+
+ }
+ return false;
+ }
+
+ private void listenEndpointsEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listEndpointsForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Endpoints.class,
+ V1EndpointsList.class
+ ).addEventHandler(new ResourceEventHandler<V1Endpoints>() {
+ @Override
+ public void onAdd(final V1Endpoints endpoints) {
+ addEndpoints(endpoints);
+ }
+
+ @Override
+ public void onUpdate(final V1Endpoints oldEndpoints, final V1Endpoints newEndpoints) {
+ addEndpoints(newEndpoints);
+ }
+
+ @Override
+ public void onDelete(final V1Endpoints endpoints, final boolean deletedFinalStateUnknown) {
+ removeEndpoints(endpoints);
+ }
+ });
+ }
+
+ private void listenPodEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listPodForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Pod.class,
+ V1PodList.class
+ ).addEventHandler(new ResourceEventHandler<V1Pod>() {
+ @Override
+ public void onAdd(final V1Pod pod) {
+ addPod(pod);
+ }
+
+ @Override
+ public void onUpdate(final V1Pod oldPod, final V1Pod newPod) {
+ addPod(newPod);
+ }
+
+ @Override
+ public void onDelete(final V1Pod pod, final boolean deletedFinalStateUnknown) {
+ removePod(pod);
+ }
+ });
+ }
+
+ private void addPod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.put(status.getPodIP(), pod)
+ );
+
+ recompose();
+ }
+
+ private void removePod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.remove(status.getPodIP())
+ );
+ }
+
+ private void addEndpoints(final V1Endpoints endpoints) {
+ V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
+ if (isNull(endpointsMetadata)) {
+ log.error("Endpoints metadata is null: {}", endpoints);
+ return;
+ }
+
+ final String namespace = endpointsMetadata.getNamespace();
Review comment:
*NULL_DEREFERENCE:* object `endpointsMetadata` last assigned on line 187 could be null and is dereferenced at line 193.
(at-me [in a reply](https://docs.muse.dev/docs/talk-to-muse/) with `help` or `ignore`)
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
+ private final Map<String/* ip */, V1Pod> ipPodMap = new ConcurrentHashMap<>();
+ private final Map<String/* ip */, String/* namespace:serviceName */> ipServiceMap = new ConcurrentHashMap<>();
+ private final Map<String/* podName */, String /* namespace:serviceName*/> podServiceMap = new ConcurrentHashMap<>();
+ private ExecutorService executor;
+
+ public static K8sInfoRegistry getInstance() {
+ return INSTANCE;
+ }
+
+ private void init() {
+ executor = Executors.newCachedThreadPool(
+ new ThreadFactoryBuilder()
+ .setNameFormat("K8sInfoRegistry-%d")
+ .setDaemon(true)
+ .build()
+ );
+ }
+
+ @SneakyThrows
+ public void start(Rule rule) {
+ if (isStarted.compareAndSet(false, true)) {
+ if (!matchFunc2Start(rule)) {
+ return;
+ }
+ init();
+ final ApiClient apiClient = Config.defaultClient();
+ apiClient.setHttpClient(apiClient.getHttpClient()
+ .newBuilder()
+ .readTimeout(0, TimeUnit.SECONDS)
+ .build());
+ Configuration.setDefaultApiClient(apiClient);
+
+ final CoreV1Api coreV1Api = new CoreV1Api();
+ final SharedInformerFactory factory = new SharedInformerFactory(executor);
+
+ listenEndpointsEvents(coreV1Api, factory);
+ listenPodEvents(coreV1Api, factory);
+ factory.startAllRegisteredInformers();
+ }
+ }
+
+ private boolean matchFunc2Start(Rule rule) {
+ for (String mf : matchedFunc) {
+ return rule.getMetricsRules().stream().anyMatch(r -> r.getExp().split(mf).length > 1);
+
+ }
+ return false;
+ }
+
+ private void listenEndpointsEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listEndpointsForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Endpoints.class,
+ V1EndpointsList.class
+ ).addEventHandler(new ResourceEventHandler<V1Endpoints>() {
+ @Override
+ public void onAdd(final V1Endpoints endpoints) {
+ addEndpoints(endpoints);
+ }
+
+ @Override
+ public void onUpdate(final V1Endpoints oldEndpoints, final V1Endpoints newEndpoints) {
+ addEndpoints(newEndpoints);
+ }
+
+ @Override
+ public void onDelete(final V1Endpoints endpoints, final boolean deletedFinalStateUnknown) {
+ removeEndpoints(endpoints);
+ }
+ });
+ }
+
+ private void listenPodEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listPodForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Pod.class,
+ V1PodList.class
+ ).addEventHandler(new ResourceEventHandler<V1Pod>() {
+ @Override
+ public void onAdd(final V1Pod pod) {
+ addPod(pod);
+ }
+
+ @Override
+ public void onUpdate(final V1Pod oldPod, final V1Pod newPod) {
+ addPod(newPod);
+ }
+
+ @Override
+ public void onDelete(final V1Pod pod, final boolean deletedFinalStateUnknown) {
+ removePod(pod);
+ }
+ });
+ }
+
+ private void addPod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.put(status.getPodIP(), pod)
+ );
+
+ recompose();
+ }
+
+ private void removePod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.remove(status.getPodIP())
+ );
+ }
+
+ private void addEndpoints(final V1Endpoints endpoints) {
+ V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
+ if (isNull(endpointsMetadata)) {
+ log.error("Endpoints metadata is null: {}", endpoints);
+ return;
+ }
+
+ final String namespace = endpointsMetadata.getNamespace();
+ final String name = endpointsMetadata.getName();
+
+ ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
+ subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
+ address -> ipServiceMap.put(address.getIp(), namespace + ":" + name)
+ ))
+ ));
+
+ recompose();
+ }
+
+ private void removeEndpoints(final V1Endpoints endpoints) {
+ ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
+ subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
+ address -> ipServiceMap.remove(address.getIp())
+ ))
+ ));
+ }
+
+ private void recompose() {
+ ipPodMap.forEach((ip, pod) -> {
+ final String namespaceService = ipServiceMap.get(ip);
+ if (isNullOrEmpty(namespaceService)) {
+ return;
+ }
+
+ final V1ObjectMeta podMetadata = pod.getMetadata();
+ if (isNull(podMetadata)) {
+ log.warn("Pod metadata is null, {}", pod);
+ return;
+ }
+
+ podServiceMap.put(pod.getMetadata().getName(), namespaceService);
Review comment:
*NULL_DEREFERENCE:* object returned by `pod.getMetadata()` could be null and is dereferenced at line 226.
(at-me [in a reply](https://docs.muse.dev/docs/talk-to-muse/) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `0.66%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 51.12% -0.67%
- Complexity 3754 3770 +16
============================================
Files 1010 997 -13
Lines 24989 24956 -33
Branches 2434 2433 -1
============================================
- Hits 12942 12759 -183
- Misses 10937 11133 +196
+ Partials 1110 1064 -46
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.13% <18.18%> (+7.58%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [195 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `8.15%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 58.11% +8.15%
- Complexity 3645 4147 +502
============================================
Files 1010 998 -12
Lines 24979 25038 +59
Branches 2433 2439 +6
============================================
+ Hits 12479 14550 +2071
+ Misses 11433 9229 -2204
- Partials 1067 1259 +192
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.07% <0.00%> (+6.53%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [181 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `6.22%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head dd66816. Consider uploading reports for the commit dd66816 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 52.67% -6.23%
+ Complexity 4185 3855 -330
============================================
Files 997 998 +1
Lines 24973 24900 -73
Branches 2436 2424 -12
============================================
- Hits 14710 13116 -1594
- Misses 8976 10637 +1661
+ Partials 1287 1147 -140
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [125 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...dd66816](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `4.92%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 46.86% -4.93%
+ Complexity 3754 3462 -292
============================================
Files 1010 997 -13
Lines 24989 24790 -199
Branches 2434 2419 -15
============================================
- Hits 12942 11618 -1324
- Misses 10937 12178 +1241
+ Partials 1110 994 -116
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-3.10%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-1.47%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `10.15%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head bf8ada5. Consider uploading reports for the commit bf8ada5 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 48.75% -10.16%
+ Complexity 4185 3586 -599
=============================================
Files 997 998 +1
Lines 24973 24863 -110
Branches 2436 2423 -13
=============================================
- Hits 14710 12121 -2589
- Misses 8976 11690 +2714
+ Partials 1287 1052 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [185 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...bf8ada5](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `13.22%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 45.67% -13.23%
+ Complexity 4185 3403 -782
=============================================
Files 997 998 +1
Lines 24973 24832 -141
Branches 2436 2422 -14
=============================================
- Hits 14710 11343 -3367
- Misses 8976 12511 +3535
+ Partials 1287 978 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `51.90% <0.00%> (-11.48%)` | `55.00 <0.00> (-8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [228 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (789391c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `29.55%`.
> The diff coverage is `5.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 29.35% -29.56%
+ Complexity 4185 1821 -2364
=============================================
Files 997 811 -186
Lines 24973 19957 -5016
Branches 2436 1861 -575
=============================================
- Hits 14710 5858 -8852
- Misses 8976 13688 +4712
+ Partials 1287 411 -876
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `50.45% <0.00%> (-32.12%)` | `18.00 <0.00> (-6.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `32.83% <18.18%> (-30.56%)` | `23.00 <0.00> (-40.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [536 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.78%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.11% -5.79%
+ Complexity 4185 3811 -374
============================================
Files 997 998 +1
Lines 24973 24893 -80
Branches 2436 2425 -11
============================================
- Hits 14710 13223 -1487
- Misses 8976 10577 +1601
+ Partials 1287 1093 -194
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [120 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `4.20%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 47.58% -4.21%
+ Complexity 3754 3392 -362
============================================
Files 1010 966 -44
Lines 24989 23887 -1102
Branches 2434 2331 -103
============================================
- Hits 12942 11367 -1575
- Misses 10937 11545 +608
+ Partials 1110 975 -135
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-3.10%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-1.47%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [171 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600140019
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
Review comment:
```suggestion
private final List<String> k8sRelativeFuncs = Arrays.asList(".k8sTagServiceByPodName");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `2.32%`.
> The diff coverage is `13.33%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head 4a17c39. Consider uploading reports for the commit 4a17c39 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 54.11% +2.32%
- Complexity 3754 4192 +438
============================================
Files 1010 1792 +782
Lines 24989 38464 +13475
Branches 2434 4233 +1799
============================================
+ Hits 12942 20815 +7873
- Misses 10937 16672 +5735
+ Partials 1110 977 -133
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.96% <0.00%> (+7.42%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `14.44% <14.44%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `60.00% <0.00%> (-40.00%)` | `3.00% <0.00%> (-2.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00% <0.00%> (ø%)` | |
| [...server/core/alarm/EndpointRelationMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRSZWxhdGlvbk1ldGFJbkFsYXJtLmphdmE=) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-2.00%)` | |
| ... and [1300 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...4a17c39](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600142134
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,25 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+
+#### k8sTagServiceByPodName
+`k8sTagServiceByPodName(podName,serviceName)`. Add a sevice Label to the sample that already has a pod name.
Review comment:
I think base on your description, this should be renamed to
```suggestion
`relabelByK8sMeta(newLabelName, type, existingLabelName)`. Add a new label to the sample family based on an existing label's value. Provide several internal converting types, including
- Pod2Service
```
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,25 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+
+#### k8sTagServiceByPodName
+`k8sTagServiceByPodName(podName,serviceName)`. Add a sevice Label to the sample that already has a pod name.
Review comment:
Does this look better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `7.60%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 44.18% -7.61%
+ Complexity 3754 3141 -613
============================================
Files 1010 1792 +782
Lines 24989 38392 +13403
Branches 2434 4226 +1792
============================================
+ Hits 12942 16964 +4022
- Misses 10937 20441 +9504
+ Partials 1110 987 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.64% <0.00%> (-1.92%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (+1.49%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [1345 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `3.73%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 48.05% -3.74%
+ Complexity 3754 3555 -199
============================================
Files 1010 1792 +782
Lines 24989 38394 +13405
Branches 2434 4226 +1792
============================================
+ Hits 12942 18452 +5510
- Misses 10937 18951 +8014
+ Partials 1110 991 -119
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.42% <0.00%> (-0.14%)` | `22.00 <0.00> (ø)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (+1.49%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1303 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.86%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head dd66816. Consider uploading reports for the commit dd66816 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.03% -5.87%
+ Complexity 4185 3876 -309
============================================
Files 997 998 +1
Lines 24973 24900 -73
Branches 2436 2424 -12
============================================
- Hits 14710 13206 -1504
- Misses 8976 10521 +1545
+ Partials 1287 1173 -114
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [115 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...dd66816](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600190199
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
Review comment:
Take a look at `Analyzer#build`. I think you could leverage the build/parser process rather than `string` match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `6.39%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 52.50% -6.40%
+ Complexity 4185 3787 -398
============================================
Files 997 998 +1
Lines 24973 24893 -80
Branches 2436 2425 -11
============================================
- Hits 14710 13070 -1640
- Misses 8976 10729 +1753
+ Partials 1287 1094 -193
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [126 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `10.84%`.
> The diff coverage is `22.22%`.
> :exclamation: Current head e08122a differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 48.05% -10.85%
+ Complexity 4185 3555 -630
=============================================
Files 997 1792 +795
Lines 24973 38394 +13421
Branches 2436 4226 +1790
=============================================
+ Hits 14710 18452 +3742
- Misses 8976 18951 +9975
+ Partials 1287 991 -296
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.42% <0.00%> (-11.15%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (-8.35%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1306 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `11.10%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 47.79% -11.11%
+ Complexity 4185 3524 -661
=============================================
Files 997 998 +1
Lines 24973 24821 -152
Branches 2436 2419 -17
=============================================
- Hits 14710 11864 -2846
- Misses 8976 11919 +2943
+ Partials 1287 1038 -249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.84% <0.00%> (-9.54%)` | `56.00 <0.00> (-7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [192 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `0.00%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=========================================
Coverage 49.95% 49.95%
+ Complexity 3645 3638 -7
=========================================
Files 1010 998 -12
Lines 24979 24880 -99
Branches 2433 2429 -4
=========================================
- Hits 12479 12430 -49
+ Misses 11433 11362 -71
- Partials 1067 1088 +21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [140 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `15.66%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 43.24% -15.67%
+ Complexity 4185 3250 -935
=============================================
Files 997 998 +1
Lines 24973 24832 -141
Branches 2436 2422 -14
=============================================
- Hits 14710 10738 -3972
- Misses 8976 13180 +4204
+ Partials 1287 914 -373
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `51.90% <0.00%> (-11.48%)` | `55.00 <0.00> (-8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [245 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600198384
##########
File path: oap-server/analyzer/meter-analyzer/src/test/java/org/apache/skywalking/oap/meter/analyzer/dsl/K8sTagTest.java
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.dsl;
+
+import com.google.common.collect.ImmutableMap;
+import java.util.Arrays;
+import java.util.Collection;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.k8s.K8sInfoRegistry;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.mockito.Mockito;
+import org.powermock.reflect.Whitebox;
+
+import static com.google.common.collect.ImmutableMap.of;
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.fail;
+import static org.mockito.Mockito.when;
+
+@Slf4j
+@RunWith(Parameterized.class)
+public class K8sTagTest {
+
+ @Parameterized.Parameter
+ public String name;
+
+ @Parameterized.Parameter(1)
+ public ImmutableMap<String, SampleFamily> input;
+
+ @Parameterized.Parameter(2)
+ public String expression;
+
+ @Parameterized.Parameter(3)
+ public Result want;
+
+ @Parameterized.Parameter(4)
+ public boolean isThrow;
+
+ @Parameterized.Parameters(name = "{index}: {0}")
+ public static Collection<Object[]> data() {
+ return Arrays.asList(new Object[][] {
+ {
Review comment:
Could you add more test cases to verify:
1. A pod doesn't belong to any service.
2. The pod doesn't exist(After rolling up, the old pod would be terminated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600142134
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,25 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+
+#### k8sTagServiceByPodName
+`k8sTagServiceByPodName(podName,serviceName)`. Add a sevice Label to the sample that already has a pod name.
Review comment:
I think base on your description, this should be renamed to
```suggestion
`retagByK8sMeta(newLabelName, type, existingLabelName)`. Add a new label to the sample family based on an existing label's value. Provide several internal converting types, including
- Pod2Service
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `5.09%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 46.69% -5.10%
+ Complexity 3754 3336 -418
============================================
Files 1010 966 -44
Lines 24989 23887 -1102
Branches 2434 2331 -103
============================================
- Hits 12942 11155 -1787
- Misses 10937 11763 +826
+ Partials 1110 969 -141
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-3.10%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-1.47%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [184 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601201779
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,28 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+#### retagByK8sMeta
+`retagByK8sMeta(newLabelName, K8sRetagType, existingLabelName)`. Add a new label to the sample family based on an existing label's value. Provide several internal converting types, including
+- K8sRetagType.Pod2Service
+
+Add a sevice Label to the sample that already has a pod name.
Review comment:
```suggestion
Add a tag to the sample by using `service` as the key, `serviceName.namespace` as the value, by the given value of the tag key, which represents the name of a pod.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (789391c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `6.47%`.
> The diff coverage is `5.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 52.42% -6.48%
+ Complexity 4185 3168 -1017
============================================
Files 997 843 -154
Lines 24973 21343 -3630
Branches 2436 2037 -399
============================================
- Hits 14710 11189 -3521
- Misses 8976 9262 +286
+ Partials 1287 892 -395
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.98% <0.00%> (-0.59%)` | `24.00 <0.00> (ø)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (-1.88%)` | `63.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [240 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `11.08%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 47.81% -11.09%
+ Complexity 4185 3526 -659
=============================================
Files 997 998 +1
Lines 24973 24832 -141
Branches 2436 2422 -14
=============================================
- Hits 14710 11874 -2836
- Misses 8976 11948 +2972
+ Partials 1287 1010 -277
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `51.90% <0.00%> (-11.48%)` | `55.00 <0.00> (-8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [200 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.70%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 55.65% +5.70%
- Complexity 3645 3983 +338
============================================
Files 1010 998 -12
Lines 24979 24934 -45
Branches 2433 2431 -2
============================================
+ Hits 12479 13878 +1399
+ Misses 11433 9838 -1595
- Partials 1067 1218 +151
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [125 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `8.04%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 57.99% +8.04%
- Complexity 3645 4137 +492
============================================
Files 1010 998 -12
Lines 24979 25038 +59
Branches 2433 2439 +6
============================================
+ Hits 12479 14522 +2043
+ Misses 11433 9258 -2175
- Partials 1067 1258 +191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.07% <0.00%> (+6.53%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [173 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.53%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.37% -5.54%
+ Complexity 4185 3867 -318
============================================
Files 997 998 +1
Lines 24973 24861 -112
Branches 2436 2425 -11
============================================
- Hits 14710 13269 -1441
- Misses 8976 10467 +1491
+ Partials 1287 1125 -162
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [138 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `4.60%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 49.95% 45.35% -4.61%
+ Complexity 3645 2769 -876
============================================
Files 1010 843 -167
Lines 24979 21157 -3822
Branches 2433 2022 -411
============================================
- Hits 12479 9596 -2883
+ Misses 11433 10817 -616
+ Partials 1067 744 -323
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [297 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (0708407) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `16.98%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 0708407 differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 41.92% -16.99%
+ Complexity 4185 3053 -1132
=============================================
Files 997 968 -29
Lines 24973 23920 -1053
Branches 2436 2334 -102
=============================================
- Hits 14710 10028 -4682
- Misses 8976 13019 +4043
+ Partials 1287 873 -414
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [288 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `0.28%`.
> The diff coverage is `11.82%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 39.27% +0.28%
+ Complexity 2765 2440 -325
============================================
Files 1005 843 -162
Lines 24880 20990 -3890
Branches 2423 1986 -437
============================================
- Hits 9700 8244 -1456
+ Misses 14427 12129 -2298
+ Partials 753 617 -136
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `34.70% <0.00%> (-18.85%)` | `32.00 <0.00> (-23.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `12.82% <12.82%> (ø)` | `6.00 <6.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `6.84% <100.00%> (-83.43%)` | `2.00 <0.00> (-19.00)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [286 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601086067
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -572,7 +591,31 @@ private static boolean doubleComp(CompType compType, double a, double b) {
}
}
+ private static class K8sRetagOps {
+
+ private static Sample[] pod2Service(Sample[] ss, String serviceNameLabel, String podNameLabel) {
Review comment:
Merge this in the implementation of `Pod2Service`, as https://github.com/apache/skywalking/pull/6608/files#r601085683 mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601085683
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -310,6 +311,24 @@ public SampleFamily tag(Closure<?> cl) {
);
}
+ /* k8s add Tags*/
+ public SampleFamily retagByK8sMeta(String newLabelName, K8sRetagType type, String existingLabelName) {
+ Preconditions.checkArgument(!Strings.isNullOrEmpty(newLabelName));
+ Preconditions.checkArgument(!Strings.isNullOrEmpty(existingLabelName));
+ ExpressionParsingContext.get().ifPresent(ctx -> ctx.isRetagByK8sMeta = true);
+ if (this == EMPTY) {
+ return EMPTY;
+ }
+ switch (type) {
+ case Pod2Service:
+ return SampleFamily.build(this.context, K8sRetagOps.pod2Service(samples, newLabelName, existingLabelName));
+
+ default:
+ throw new UnsupportedOperationException(
+ "Unsupported type: " + type + " in retagByK8sMeta() " + this.toString());
+ }
+ }
Review comment:
Please consider K8sRetagType as an interface implementation. Then you could have `type.cover(param1, param2)` directly, rather than this switch case and throw an exception in the runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `8.63%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 58.59% +8.63%
- Complexity 3645 4191 +546
============================================
Files 1010 998 -12
Lines 24979 25066 +87
Branches 2433 2444 +11
============================================
+ Hits 12479 14687 +2208
+ Misses 11433 9106 -2327
- Partials 1067 1273 +206
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.07% <0.00%> (+6.53%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [192 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `1.66%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 53.45% +1.66%
- Complexity 3754 3891 +137
============================================
Files 1010 997 -13
Lines 24989 24967 -22
Branches 2434 2438 +4
============================================
+ Hits 12942 13346 +404
+ Misses 10937 10493 -444
- Partials 1110 1128 +18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.98% <0.00%> (+10.42%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (+7.96%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `3.44%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 55.23% +3.44%
- Complexity 3754 3987 +233
============================================
Files 1010 997 -13
Lines 24989 24986 -3
Branches 2434 2438 +4
============================================
+ Hits 12942 13801 +859
+ Misses 10937 10019 -918
- Partials 1110 1166 +56
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.98% <0.00%> (+10.42%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (+7.96%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [155 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `17.82%`.
> The diff coverage is `5.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 51.79% 33.96% -17.83%
+ Complexity 3754 2636 -1118
=============================================
Files 1010 996 -14
Lines 24989 24581 -408
Branches 2434 2378 -56
=============================================
- Hits 12942 8349 -4593
- Misses 10937 15494 +4557
+ Partials 1110 738 -372
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-3.10%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-1.47%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [298 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.18%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.71% -5.19%
+ Complexity 4185 3843 -342
============================================
Files 997 998 +1
Lines 24973 24893 -80
Branches 2436 2425 -11
============================================
- Hits 14710 13372 -1338
- Misses 8976 10399 +1423
+ Partials 1287 1122 -165
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [109 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.13%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.77% -5.14%
+ Complexity 4185 3887 -298
============================================
Files 997 998 +1
Lines 24973 24861 -112
Branches 2436 2425 -11
============================================
- Hits 14710 13368 -1342
- Misses 8976 10344 +1368
+ Partials 1287 1149 -138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [127 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `9.05%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 42.73% -9.06%
+ Complexity 3754 2996 -758
============================================
Files 1010 1792 +782
Lines 24989 38392 +13403
Branches 2434 4226 +1792
============================================
+ Hits 12942 16408 +3466
- Misses 10937 20998 +10061
+ Partials 1110 986 -124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.64% <0.00%> (-1.92%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (+1.49%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [1356 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `7.18%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 44.60% -7.19%
+ Complexity 3754 3169 -585
============================================
Files 1010 1792 +782
Lines 24989 38392 +13403
Branches 2434 4226 +1792
============================================
+ Hits 12942 17125 +4183
- Misses 10937 20280 +9343
+ Partials 1110 987 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.64% <0.00%> (-1.92%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (+1.49%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [1348 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `22.71%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 36.18% -22.72%
+ Complexity 4185 2273 -1912
=============================================
Files 997 844 -153
Lines 24973 21100 -3873
Branches 2436 2015 -421
=============================================
- Hits 14710 7636 -7074
- Misses 8976 12887 +3911
+ Partials 1287 577 -710
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [428 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `4.98%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.91% -4.99%
+ Complexity 4185 3850 -335
============================================
Files 997 998 +1
Lines 24973 24893 -80
Branches 2436 2425 -11
============================================
- Hits 14710 13421 -1289
- Misses 8976 10341 +1365
+ Partials 1287 1131 -156
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [107 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `8.53%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 50.36% -8.54%
+ Complexity 4185 3674 -511
============================================
Files 997 998 +1
Lines 24973 24833 -140
Branches 2436 2423 -13
============================================
- Hits 14710 12507 -2203
- Misses 8976 11274 +2298
+ Partials 1287 1052 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [169 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `8.82%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 50.07% -8.83%
+ Complexity 4185 3628 -557
============================================
Files 997 998 +1
Lines 24973 24890 -83
Branches 2436 2425 -11
============================================
- Hits 14710 12464 -2246
- Misses 8976 11362 +2386
+ Partials 1287 1064 -223
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [182 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `0.09%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 51.69% -0.10%
- Complexity 3754 3793 +39
============================================
Files 1010 997 -13
Lines 24989 24956 -33
Branches 2434 2433 -1
============================================
- Hits 12942 12902 -40
- Misses 10937 10956 +19
+ Partials 1110 1098 -12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.13% <18.18%> (+7.58%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [197 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `11.11%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 47.78% -11.12%
+ Complexity 4185 3393 -792
=============================================
Files 997 967 -30
Lines 24973 23860 -1113
Branches 2436 2327 -109
=============================================
- Hits 14710 11402 -3308
- Misses 8976 11486 +2510
+ Partials 1287 972 -315
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [224 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `22.69%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 36.20% -22.70%
+ Complexity 4185 2274 -1911
=============================================
Files 997 844 -153
Lines 24973 21100 -3873
Branches 2436 2015 -421
=============================================
- Hits 14710 7640 -7070
- Misses 8976 12885 +3909
+ Partials 1287 575 -712
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [427 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601201779
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,28 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+#### retagByK8sMeta
+`retagByK8sMeta(newLabelName, K8sRetagType, existingLabelName)`. Add a new label to the sample family based on an existing label's value. Provide several internal converting types, including
+- K8sRetagType.Pod2Service
+
+Add a sevice Label to the sample that already has a pod name.
Review comment:
```suggestion
Add a tag to the sample by using `service` as the key, `$serviceName.$namespace` as the value, by the given value of the tag key, which represents the name of a pod.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `3.18%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 55.72% -3.19%
+ Complexity 4185 4023 -162
============================================
Files 997 999 +2
Lines 24973 24937 -36
Branches 2436 2434 -2
============================================
- Hits 14710 13895 -815
- Misses 8976 9856 +880
+ Partials 1287 1186 -101
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (-92.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [69 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.18%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.71% -5.19%
+ Complexity 4185 3879 -306
============================================
Files 997 998 +1
Lines 24973 24861 -112
Branches 2436 2425 -11
============================================
- Hits 14710 13354 -1356
- Misses 8976 10358 +1382
+ Partials 1287 1149 -138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [133 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.76%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 44.75% +5.76%
+ Complexity 2765 2747 -18
============================================
Files 1005 843 -162
Lines 24880 21153 -3727
Branches 2423 2018 -405
============================================
- Hits 9700 9467 -233
+ Misses 14427 10952 -3475
+ Partials 753 734 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.23% <0.00%> (-1.31%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [266 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.69%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head dd66816. Consider uploading reports for the commit dd66816 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.20% -5.70%
+ Complexity 4185 3884 -301
============================================
Files 997 998 +1
Lines 24973 24900 -73
Branches 2436 2424 -12
============================================
- Hits 14710 13248 -1462
- Misses 8976 10472 +1496
+ Partials 1287 1180 -107
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [112 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...dd66816](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `0.52%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 51.26% -0.53%
- Complexity 3754 3775 +21
============================================
Files 1010 997 -13
Lines 24989 24956 -33
Branches 2434 2433 -1
============================================
- Hits 12942 12793 -149
- Misses 10937 11088 +151
+ Partials 1110 1075 -35
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.13% <18.18%> (+7.58%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [196 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `9.41%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head dd66816. Consider uploading reports for the commit dd66816 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 49.49% -9.42%
+ Complexity 4185 3638 -547
============================================
Files 997 998 +1
Lines 24973 24863 -110
Branches 2436 2423 -13
============================================
- Hits 14710 12305 -2405
- Misses 8976 11494 +2518
+ Partials 1287 1064 -223
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [176 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...dd66816](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (789391c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `10.64%`.
> The diff coverage is `5.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 48.26% -10.65%
+ Complexity 4185 2963 -1222
=============================================
Files 997 843 -154
Lines 24973 21304 -3669
Branches 2436 2036 -400
=============================================
- Hits 14710 10282 -4428
- Misses 8976 10202 +1226
+ Partials 1287 820 -467
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.98% <0.00%> (-0.59%)` | `24.00 <0.00> (ø)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (-1.88%)` | `63.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [292 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601203170
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,28 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
Review comment:
```suggestion
### Tag manipulator
MAL provides tag manipulators to change(add/delete/update) tags and their values.
#### K8s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `21.68%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 37.22% -21.69%
+ Complexity 4185 2318 -1867
=============================================
Files 997 844 -153
Lines 24973 21100 -3873
Branches 2436 2015 -421
=============================================
- Hits 14710 7854 -6856
- Misses 8976 12651 +3675
+ Partials 1287 595 -692
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [418 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.69%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head a6b5930. Consider uploading reports for the commit a6b5930 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.20% -5.70%
+ Complexity 4185 3884 -301
============================================
Files 997 998 +1
Lines 24973 24900 -73
Branches 2436 2424 -12
============================================
- Hits 14710 13248 -1462
- Misses 8976 10472 +1496
+ Partials 1287 1180 -107
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [112 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...a6b5930](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600140126
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
Review comment:
`.k8sTagServiceByPodName` please remove the `.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `6.21%`.
> The diff coverage is `11.82%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 38.98% 32.77% -6.22%
+ Complexity 2765 2001 -764
============================================
Files 1005 812 -193
Lines 24880 20025 -4855
Branches 2423 1891 -532
============================================
- Hits 9700 6563 -3137
+ Misses 14427 12966 -1461
+ Partials 753 496 -257
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `34.70% <0.00%> (-18.85%)` | `32.00 <0.00> (-23.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `12.82% <12.82%> (ø)` | `6.00 <6.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `6.84% <100.00%> (-83.43%)` | `2.00 <0.00> (-19.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvU1FMRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [370 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `7.54%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 44.24% -7.55%
+ Complexity 3754 3145 -609
============================================
Files 1010 1792 +782
Lines 24989 38392 +13403
Branches 2434 4226 +1792
============================================
+ Hits 12942 16988 +4046
- Misses 10937 20417 +9480
+ Partials 1110 987 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.64% <0.00%> (-1.92%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (+1.49%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [1346 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `12.72%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 46.17% -12.73%
+ Complexity 4185 2780 -1405
=============================================
Files 997 843 -154
Lines 24973 21167 -3806
Branches 2436 2018 -418
=============================================
- Hits 14710 9774 -4936
- Misses 8976 10648 +1672
+ Partials 1287 745 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [349 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `12.34%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 46.55% -12.35%
+ Complexity 4185 3472 -713
=============================================
Files 997 998 +1
Lines 24973 24818 -155
Branches 2436 2419 -17
=============================================
- Hits 14710 11554 -3156
- Misses 8976 12259 +3283
+ Partials 1287 1005 -282
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.84% <0.00%> (-9.54%)` | `56.00 <0.00> (-7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [211 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `3.46%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 53.42% +3.46%
- Complexity 3645 3811 +166
============================================
Files 1010 998 -12
Lines 24979 24916 -63
Branches 2433 2430 -3
============================================
+ Hits 12479 13311 +832
+ Misses 11433 10459 -974
- Partials 1067 1146 +79
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lyzer/agent/kafka/KafkaFetcherHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9LYWZrYUZldGNoZXJIYW5kbGVyUmVnaXN0ZXIuamF2YQ==) | `0.00% <0.00%> (-77.03%)` | `0.00% <0.00%> (-10.00%)` | |
| [...gent/kafka/provider/handler/JVMMetricsHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY3NIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (-76.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [103 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (789391c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `31.86%`.
> The diff coverage is `3.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 27.04% -31.87%
+ Complexity 4185 1696 -2489
=============================================
Files 997 811 -186
Lines 24973 19811 -5162
Branches 2436 1842 -594
=============================================
- Hits 14710 5357 -9353
- Misses 8976 14080 +5104
+ Partials 1287 374 -913
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.01% <0.00%> (-64.56%)` | `4.00 <0.00> (-20.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `8.96% <0.00%> (-54.42%)` | `9.00 <0.00> (-54.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [561 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d828434) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `21.84%`.
> The diff coverage is `15.05%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 49.95% 28.10% -21.85%
+ Complexity 3645 1815 -1830
=============================================
Files 1010 841 -169
Lines 24979 20858 -4121
Branches 2433 1971 -462
=============================================
- Hits 12479 5863 -6616
- Misses 11433 14549 +3116
+ Partials 1067 446 -621
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `50.74% <0.00%> (-2.80%)` | `55.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [426 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.17%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.73% -5.18%
+ Complexity 4185 3881 -304
============================================
Files 997 998 +1
Lines 24973 24861 -112
Branches 2436 2425 -11
============================================
- Hits 14710 13358 -1352
- Misses 8976 10354 +1378
+ Partials 1287 1149 -138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [132 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `2.83%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 52.78% +2.83%
- Complexity 3645 3784 +139
============================================
Files 1010 998 -12
Lines 24979 24916 -63
Branches 2433 2430 -3
============================================
+ Hits 12479 13153 +674
+ Misses 11433 10624 -809
- Partials 1067 1139 +72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `16.12% <0.00%> (-77.42%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [109 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.46%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.43% -5.47%
+ Complexity 4185 3869 -316
============================================
Files 997 998 +1
Lines 24973 24861 -112
Branches 2436 2425 -11
============================================
- Hits 14710 13285 -1425
- Misses 8976 10444 +1468
+ Partials 1287 1132 -155
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [137 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `18.26%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 40.63% -18.27%
+ Complexity 4185 2406 -1779
=============================================
Files 997 813 -184
Lines 24973 20153 -4820
Branches 2436 1920 -516
=============================================
- Hits 14710 8189 -6521
- Misses 8976 11339 +2363
+ Partials 1287 625 -662
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [419 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `4.24%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 47.55% -4.25%
+ Complexity 3754 3517 -237
============================================
Files 1010 997 -13
Lines 24989 24799 -190
Branches 2434 2419 -15
============================================
- Hits 12942 11792 -1150
- Misses 10937 12007 +1070
+ Partials 1110 1000 -110
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-3.10%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-1.47%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [138 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.72%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 44.70% +5.72%
+ Complexity 2765 2742 -23
============================================
Files 1005 843 -162
Lines 24880 21153 -3727
Branches 2423 2018 -405
============================================
- Hits 9700 9457 -243
+ Misses 14427 10964 -3463
+ Partials 753 732 -21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.23% <0.00%> (-1.31%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [265 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600173571
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
Review comment:
I use `.` to mark it's a function name, to distinguish between function and other words in the expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `1.27%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 50.51% -1.28%
+ Complexity 3754 3720 -34
============================================
Files 1010 997 -13
Lines 24989 24934 -55
Branches 2434 2432 -2
============================================
- Hits 12942 12596 -346
- Misses 10937 11300 +363
+ Partials 1110 1038 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (+7.71%)` | `23.00 <0.00> (+1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.62% <18.18%> (+6.07%)` | `62.00 <0.00> (+7.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [183 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `1.12%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 50.66% -1.13%
+ Complexity 3754 3735 -19
============================================
Files 1010 997 -13
Lines 24989 24934 -55
Branches 2434 2432 -2
============================================
- Hits 12942 12633 -309
- Misses 10937 11255 +318
+ Partials 1110 1046 -64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (+7.71%)` | `23.00 <0.00> (+1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.62% <18.18%> (+6.07%)` | `62.00 <0.00> (+7.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [187 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `8.01%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head dd66816. Consider uploading reports for the commit dd66816 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 50.88% -8.02%
+ Complexity 4185 3759 -426
============================================
Files 997 998 +1
Lines 24973 24881 -92
Branches 2436 2424 -12
============================================
- Hits 14710 12661 -2049
- Misses 8976 11111 +2135
+ Partials 1287 1109 -178
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...dd66816](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `25.61%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 33.29% -25.62%
+ Complexity 4185 2507 -1678
=============================================
Files 997 966 -31
Lines 24973 23771 -1202
Branches 2436 2318 -118
=============================================
- Hits 14710 7914 -6796
- Misses 8976 15168 +6192
+ Partials 1287 689 -598
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `51.90% <0.00%> (-11.48%)` | `55.00 <0.00> (-8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [437 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.75%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 44.74% +5.75%
+ Complexity 2765 2747 -18
============================================
Files 1005 843 -162
Lines 24880 21153 -3727
Branches 2423 2018 -405
============================================
- Hits 9700 9465 -235
+ Misses 14427 10953 -3474
+ Partials 753 735 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.23% <0.00%> (-1.31%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [267 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (789391c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `19.74%`.
> The diff coverage is `5.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 39.15% -19.75%
+ Complexity 4185 2464 -1721
=============================================
Files 997 843 -154
Lines 24973 21119 -3854
Branches 2436 1995 -441
=============================================
- Hits 14710 8269 -6441
- Misses 8976 12237 +3261
+ Partials 1287 613 -674
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `64.86% <0.00%> (-17.71%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `48.30% <18.18%> (-15.09%)` | `42.00 <0.00> (-21.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [398 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `21.06%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 37.83% -21.07%
+ Complexity 4185 2361 -1824
=============================================
Files 997 844 -153
Lines 24973 21131 -3842
Branches 2436 2016 -420
=============================================
- Hits 14710 7995 -6715
- Misses 8976 12522 +3546
+ Partials 1287 614 -673
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.84% <0.00%> (-9.54%)` | `56.00 <0.00> (-7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [407 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `4.53%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 54.37% -4.54%
+ Complexity 4185 3921 -264
============================================
Files 997 998 +1
Lines 24973 24864 -109
Branches 2436 2425 -11
============================================
- Hits 14710 13519 -1191
- Misses 8976 10191 +1215
+ Partials 1287 1154 -133
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [110 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `6.86%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 56.82% +6.86%
- Complexity 3645 4061 +416
============================================
Files 1010 998 -12
Lines 24979 25038 +59
Branches 2433 2439 +6
============================================
+ Hits 12479 14228 +1749
+ Misses 11433 9557 -1876
- Partials 1067 1253 +186
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.07% <0.00%> (+6.53%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| ... and [142 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `4.41%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 49.95% 45.54% -4.42%
+ Complexity 3645 2775 -870
============================================
Files 1010 843 -167
Lines 24979 21157 -3822
Branches 2433 2022 -411
============================================
- Hits 12479 9636 -2843
+ Misses 11433 10768 -665
+ Partials 1067 753 -314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [296 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `7.04%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 51.85% -7.05%
+ Complexity 4185 3739 -446
============================================
Files 997 998 +1
Lines 24973 24843 -130
Branches 2436 2424 -12
============================================
- Hits 14710 12882 -1828
- Misses 8976 10885 +1909
+ Partials 1287 1076 -211
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [170 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.09%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.81% -5.10%
+ Complexity 4185 3918 -267
============================================
Files 997 998 +1
Lines 24973 24903 -70
Branches 2436 2424 -12
============================================
- Hits 14710 13401 -1309
- Misses 8976 10318 +1342
+ Partials 1287 1184 -103
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.07% <0.00%> (-10.50%)` | `23.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (789391c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `29.57%`.
> The diff coverage is `5.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 29.33% -29.58%
+ Complexity 4185 1819 -2366
=============================================
Files 997 811 -186
Lines 24973 19957 -5016
Branches 2436 1861 -575
=============================================
- Hits 14710 5854 -8856
- Misses 8976 13692 +4716
+ Partials 1287 411 -876
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `50.45% <0.00%> (-32.12%)` | `18.00 <0.00> (-6.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `32.83% <18.18%> (-30.56%)` | `23.00 <0.00> (-40.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [537 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600393068
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
+ private final Map<String/* ip */, V1Pod> ipPodMap = new ConcurrentHashMap<>();
+ private final Map<String/* ip */, String/* namespace:serviceName */> ipServiceMap = new ConcurrentHashMap<>();
+ private final Map<String/* podName */, String /* namespace:serviceName*/> podServiceMap = new ConcurrentHashMap<>();
+ private ExecutorService executor;
+
+ public static K8sInfoRegistry getInstance() {
+ return INSTANCE;
+ }
+
+ private void init() {
+ executor = Executors.newCachedThreadPool(
+ new ThreadFactoryBuilder()
+ .setNameFormat("K8sInfoRegistry-%d")
+ .setDaemon(true)
+ .build()
+ );
+ }
+
+ @SneakyThrows
+ public void start(Rule rule) {
+ if (isStarted.compareAndSet(false, true)) {
Review comment:
If the first rule doesn’t satisfy `matchFunc2Start(rule)`, the `isStarted` is set to true anyway, and later rules that satisfy won’t enable the registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `4.76%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 47.02% -4.77%
+ Complexity 3754 3482 -272
============================================
Files 1010 997 -13
Lines 24989 24799 -190
Branches 2434 2419 -15
============================================
- Hits 12942 11661 -1281
- Misses 10937 12146 +1209
+ Partials 1110 992 -118
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-3.10%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-1.47%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [145 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `6.99%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 51.90% -7.00%
+ Complexity 4185 3743 -442
============================================
Files 997 998 +1
Lines 24973 24843 -130
Branches 2436 2424 -12
============================================
- Hits 14710 12895 -1815
- Misses 8976 10872 +1896
+ Partials 1287 1076 -211
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [168 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `3.64%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 55.43% +3.64%
- Complexity 3754 4003 +249
============================================
Files 1010 998 -12
Lines 24989 25031 +42
Branches 2434 2442 +8
============================================
+ Hits 12942 13876 +934
+ Misses 10937 9979 -958
- Partials 1110 1176 +66
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.98% <0.00%> (+10.42%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (+7.96%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [145 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `22.16%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 36.74% -22.17%
+ Complexity 4185 2207 -1978
=============================================
Files 997 813 -184
Lines 24973 20144 -4829
Branches 2436 1920 -516
=============================================
- Hits 14710 7401 -7309
- Misses 8976 12164 +3188
+ Partials 1287 579 -708
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [446 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `11.28%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 47.61% -11.29%
+ Complexity 4185 3518 -667
=============================================
Files 997 998 +1
Lines 24973 24832 -141
Branches 2436 2422 -14
=============================================
- Hits 14710 11824 -2886
- Misses 8976 11999 +3023
+ Partials 1287 1009 -278
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `51.90% <0.00%> (-11.48%)` | `55.00 <0.00> (-8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [202 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d828434) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `23.03%`.
> The diff coverage is `15.05%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 50.03% 27.00% -23.04%
+ Complexity 3645 1766 -1879
=============================================
Files 1008 841 -167
Lines 24942 20858 -4084
Branches 2427 1971 -456
=============================================
- Hits 12479 5632 -6847
- Misses 11396 14797 +3401
+ Partials 1067 429 -638
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `50.74% <0.00%> (-2.80%)` | `55.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [434 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.66%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.23% -5.67%
+ Complexity 4185 3814 -371
============================================
Files 997 998 +1
Lines 24973 24893 -80
Branches 2436 2425 -11
============================================
- Hits 14710 13252 -1458
- Misses 8976 10539 +1563
+ Partials 1287 1102 -185
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [119 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `11.64%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 47.25% -11.65%
+ Complexity 4185 3489 -696
=============================================
Files 997 998 +1
Lines 24973 24832 -141
Branches 2436 2422 -14
=============================================
- Hits 14710 11735 -2975
- Misses 8976 12095 +3119
+ Partials 1287 1002 -285
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `51.90% <0.00%> (-11.48%)` | `55.00 <0.00> (-8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [210 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `8.65%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 58.61% +8.65%
- Complexity 3645 4192 +547
============================================
Files 1010 998 -12
Lines 24979 25066 +87
Branches 2433 2444 +11
============================================
+ Hits 12479 14692 +2213
+ Misses 11433 9101 -2332
- Partials 1067 1273 +206
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.07% <0.00%> (+6.53%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [194 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.34%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.56% -5.35%
+ Complexity 4185 3873 -312
============================================
Files 997 998 +1
Lines 24973 24861 -112
Branches 2436 2425 -11
============================================
- Hits 14710 13316 -1394
- Misses 8976 10403 +1427
+ Partials 1287 1142 -145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601149943
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -575,4 +588,31 @@ private static boolean doubleComp(CompType compType, double a, double b) {
private enum CompType {
EQUAL, NOT_EQUAL, LESS, LESS_EQUAL, GREATER, GREATER_EQUAL
}
+
+ private interface Retag {
+ Sample[] execute(Sample[] ss, String newLabelName, String existingLabelName);
+ }
+
+ protected enum K8sRetagType implements Retag {
Review comment:
Let's move this into another file. SampleFamily is big enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `4.89%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 56.68% +4.89%
- Complexity 3754 4053 +299
============================================
Files 1010 998 -12
Lines 24989 25048 +59
Branches 2434 2443 +9
============================================
+ Hits 12942 14199 +1257
+ Misses 10937 9667 -1270
- Partials 1110 1182 +72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.98% <0.00%> (+10.42%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (+7.96%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyRXZlbnRRdWVyeURBTy5qYXZh) | `1.58% <0.00%> (-46.04%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `60.00% <0.00%> (-40.00%)` | `3.00% <0.00%> (-2.00%)` | |
| ... and [134 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `1.60%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 50.18% -1.61%
+ Complexity 3754 3700 -54
============================================
Files 1010 997 -13
Lines 24989 24934 -55
Branches 2434 2432 -2
============================================
- Hits 12942 12513 -429
- Misses 10937 11379 +442
+ Partials 1110 1042 -68
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (+7.71%)` | `23.00 <0.00> (+1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.62% <18.18%> (+6.07%)` | `62.00 <0.00> (+7.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [175 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `6.53%`.
> The diff coverage is `18.43%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 52.37% -6.54%
+ Complexity 4185 3972 -213
============================================
Files 997 1795 +798
Lines 24973 38431 +13458
Branches 2436 4229 +1793
============================================
+ Hits 14710 20127 +5417
- Misses 8976 17314 +8338
+ Partials 1287 990 -297
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/plugin/hbase/HTable100Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUxMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable200Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable220Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMjBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/apm/plugin/hbase/HTableInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGVJbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.42% <0.00%> (-11.15%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (-8.35%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `17.25%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 41.65% -17.26%
+ Complexity 4185 2455 -1730
=============================================
Files 997 813 -184
Lines 24973 20153 -4820
Branches 2436 1920 -516
=============================================
- Hits 14710 8394 -6316
- Misses 8976 11126 +2150
+ Partials 1287 633 -654
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [406 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `2.32%`.
> The diff coverage is `13.33%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head 58b9272. Consider uploading reports for the commit 58b9272 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 54.11% +2.32%
- Complexity 3754 4192 +438
============================================
Files 1010 1792 +782
Lines 24989 38464 +13475
Branches 2434 4233 +1799
============================================
+ Hits 12942 20815 +7873
- Misses 10937 16672 +5735
+ Partials 1110 977 -133
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.96% <0.00%> (+7.42%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `14.44% <14.44%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `60.00% <0.00%> (-40.00%)` | `3.00% <0.00%> (-2.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00% <0.00%> (ø%)` | |
| [...server/core/alarm/EndpointRelationMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRSZWxhdGlvbk1ldGFJbkFsYXJtLmphdmE=) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-2.00%)` | |
| ... and [1300 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...58b9272](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `15.92%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 42.97% -15.93%
+ Complexity 4185 2530 -1655
=============================================
Files 997 813 -184
Lines 24973 20162 -4811
Branches 2436 1920 -516
=============================================
- Hits 14710 8665 -6045
- Misses 8976 10842 +1866
+ Partials 1287 655 -632
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [391 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601084517
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/ExpressionParsingContext.java
##########
@@ -72,6 +72,8 @@ static ExpressionParsingContext create() {
ScopeType scopeType;
+ boolean isRetagByK8sMeta;
Review comment:
Please add a comment about what does this mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `16.02%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 42.88% -16.03%
+ Complexity 4185 3219 -966
=============================================
Files 997 998 +1
Lines 24973 24832 -141
Branches 2436 2422 -14
=============================================
- Hits 14710 10648 -4062
- Misses 8976 13276 +4300
+ Partials 1287 908 -379
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `51.90% <0.00%> (-11.48%)` | `55.00 <0.00> (-8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [264 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.94%`.
> The diff coverage is `17.51%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 52.95% -5.95%
+ Complexity 4185 4112 -73
============================================
Files 997 1796 +799
Lines 24973 38497 +13524
Branches 2436 4237 +1801
============================================
+ Hits 14710 20388 +5678
- Misses 8976 17133 +8157
+ Partials 1287 976 -311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/plugin/hbase/HTable100Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUxMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable200Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable220Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMjBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/apm/plugin/hbase/HTableInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGVJbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.35% <0.00%> (-2.22%)` | `23.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.30% <0.00%> (-2.09%)` | `62.00 <0.00> (-1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.30% <92.30%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| ... and [1259 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.96%`.
> The diff coverage is `17.51%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 52.93% -5.97%
+ Complexity 4185 4111 -74
============================================
Files 997 1796 +799
Lines 24973 38497 +13524
Branches 2436 4237 +1801
============================================
+ Hits 14710 20380 +5670
- Misses 8976 17141 +8165
+ Partials 1287 976 -311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/plugin/hbase/HTable100Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUxMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable200Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable220Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMjBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/apm/plugin/hbase/HTableInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGVJbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.35% <0.00%> (-2.22%)` | `23.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.30% <0.00%> (-2.09%)` | `62.00 <0.00> (-1.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `92.30% <92.30%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| ... and [1259 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `18.34%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 40.56% -18.35%
+ Complexity 4185 2506 -1679
=============================================
Files 997 844 -153
Lines 24973 21140 -3833
Branches 2436 2016 -420
=============================================
- Hits 14710 8575 -6135
- Misses 8976 11909 +2933
+ Partials 1287 656 -631
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.84% <0.00%> (-9.54%)` | `56.00 <0.00> (-7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [391 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601213603
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,30 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### Tag manipulator
+MAL provides tag manipulators to change(add/delete/update) tags and their values.
+
+#### K8s
+MAL supports using the metadata of k8s to manipulate the tags and their values.
+This feature requires OAP Server to have the authority to access the K8s's `API Server`.
+#### retagByK8sMeta
Review comment:
```suggestion
##### retagByK8sMeta
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `10.38%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head bf8ada5. Consider uploading reports for the commit bf8ada5 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 48.51% -10.39%
+ Complexity 4185 3577 -608
=============================================
Files 997 998 +1
Lines 24973 24863 -110
Branches 2436 2423 -13
=============================================
- Hits 14710 12063 -2647
- Misses 8976 11759 +2783
+ Partials 1287 1041 -246
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [186 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...bf8ada5](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `6.53%`.
> The diff coverage is `18.43%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 52.37% -6.54%
+ Complexity 4185 3972 -213
============================================
Files 997 1795 +798
Lines 24973 38431 +13458
Branches 2436 4229 +1793
============================================
+ Hits 14710 20127 +5417
- Misses 8976 17314 +8338
+ Partials 1287 990 -297
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/plugin/hbase/HTable100Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUxMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable200Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable220Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMjBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/apm/plugin/hbase/HTableInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGVJbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.42% <0.00%> (-11.15%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (-8.35%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601195953
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -575,4 +588,31 @@ private static boolean doubleComp(CompType compType, double a, double b) {
private enum CompType {
EQUAL, NOT_EQUAL, LESS, LESS_EQUAL, GREATER, GREATER_EQUAL
}
+
+ private interface Retag {
+ Sample[] execute(Sample[] ss, String newLabelName, String existingLabelName);
+ }
+
+ protected enum K8sRetagType implements Retag {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `7.79%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 51.10% -7.80%
+ Complexity 4185 3710 -475
============================================
Files 997 998 +1
Lines 24973 24833 -140
Branches 2436 2423 -13
============================================
- Hits 14710 12691 -2019
- Misses 8976 11085 +2109
+ Partials 1287 1057 -230
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [177 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601144170
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/DSL.java
##########
@@ -37,6 +38,9 @@
public static Expression parse(final String expression) {
CompilerConfiguration cc = new CompilerConfiguration();
cc.setScriptBaseClass(DelegatingScript.class.getName());
+ ImportCustomizer icz = new ImportCustomizer();
+ icz.addImport("K8sRetagType", "org.apache.skywalking.oap.meter.analyzer.dsl.SampleFamily.K8sRetagType");
Review comment:
done
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -572,7 +591,31 @@ private static boolean doubleComp(CompType compType, double a, double b) {
}
}
+ private static class K8sRetagOps {
+
+ private static Sample[] pod2Service(Sample[] ss, String serviceNameLabel, String podNameLabel) {
Review comment:
done
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/ExpressionParsingContext.java
##########
@@ -72,6 +72,8 @@ static ExpressionParsingContext create() {
ScopeType scopeType;
+ boolean isRetagByK8sMeta;
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `4.91%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 46.87% -4.92%
+ Complexity 3754 3462 -292
============================================
Files 1010 997 -13
Lines 24989 24790 -199
Branches 2434 2419 -15
============================================
- Hits 12942 11620 -1322
- Misses 10937 12177 +1240
+ Partials 1110 993 -117
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-3.10%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-1.47%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.39%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 55.35% +5.39%
- Complexity 3645 3969 +324
============================================
Files 1010 998 -12
Lines 24979 24934 -45
Branches 2433 2431 -2
============================================
+ Hits 12479 13801 +1322
+ Misses 11433 9929 -1504
- Partials 1067 1204 +137
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `16.42%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 51.79% 35.36% -16.43%
+ Complexity 3754 2127 -1627
=============================================
Files 1010 812 -198
Lines 24989 20114 -4875
Branches 2434 1916 -518
=============================================
- Hits 12942 7113 -5829
- Misses 10937 12470 +1533
+ Partials 1110 531 -579
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-3.10%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-1.47%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [396 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `11.07%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 47.83% -11.08%
+ Complexity 4185 3397 -788
=============================================
Files 997 967 -30
Lines 24973 23860 -1113
Branches 2436 2327 -109
=============================================
- Hits 14710 11413 -3297
- Misses 8976 11475 +2499
+ Partials 1287 972 -315
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [221 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.69%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.20% -5.70%
+ Complexity 4185 3884 -301
============================================
Files 997 998 +1
Lines 24973 24900 -73
Branches 2436 2424 -12
============================================
- Hits 14710 13248 -1462
- Misses 8976 10472 +1496
+ Partials 1287 1180 -107
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [112 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.88%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 55.83% +5.88%
- Complexity 3645 3990 +345
============================================
Files 1010 998 -12
Lines 24979 24934 -45
Branches 2433 2431 -2
============================================
+ Hits 12479 13923 +1444
+ Misses 11433 9782 -1651
- Partials 1067 1229 +162
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| ... and [126 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `15.65%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 43.25% -15.66%
+ Complexity 4185 3250 -935
=============================================
Files 997 998 +1
Lines 24973 24832 -141
Branches 2436 2422 -14
=============================================
- Hits 14710 10740 -3970
- Misses 8976 13179 +4203
+ Partials 1287 913 -374
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `51.90% <0.00%> (-11.48%)` | `55.00 <0.00> (-8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [245 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `4.20%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 54.69% -4.21%
+ Complexity 4185 3950 -235
============================================
Files 997 999 +2
Lines 24973 24909 -64
Branches 2436 2429 -7
============================================
- Hits 14710 13624 -1086
- Misses 8976 10121 +1145
+ Partials 1287 1164 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [94 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601209117
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,28 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
Review comment:
```suggestion
MAL supports using the metadata of k8s to manipulate the tags and their values.
This feature requires OAP Server to have the authority to access the K8s's `API Server`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `4.30%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 54.59% -4.31%
+ Complexity 4185 3941 -244
============================================
Files 997 999 +2
Lines 24973 24909 -64
Branches 2436 2429 -7
============================================
- Hits 14710 13600 -1110
- Misses 8976 10145 +1169
+ Partials 1287 1164 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [98 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `2.32%`.
> The diff coverage is `13.33%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 54.11% +2.32%
- Complexity 3754 4192 +438
============================================
Files 1010 1792 +782
Lines 24989 38464 +13475
Branches 2434 4233 +1799
============================================
+ Hits 12942 20815 +7873
- Misses 10937 16672 +5735
+ Partials 1110 977 -133
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.96% <0.00%> (+7.42%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `14.44% <14.44%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `60.00% <0.00%> (-40.00%)` | `3.00% <0.00%> (-2.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00% <0.00%> (ø%)` | |
| [...server/core/alarm/EndpointRelationMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRSZWxhdGlvbk1ldGFJbkFsYXJtLmphdmE=) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-2.00%)` | |
| ... and [1300 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `0.47%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 50.43% +0.47%
- Complexity 3645 3667 +22
============================================
Files 1010 998 -12
Lines 24979 24880 -99
Branches 2433 2429 -4
============================================
+ Hits 12479 12548 +69
+ Misses 11433 11231 -202
- Partials 1067 1101 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [132 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `0.77%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 49.95% 49.18% -0.78%
+ Complexity 3645 3608 -37
============================================
Files 1010 998 -12
Lines 24979 24880 -99
Branches 2433 2429 -4
============================================
- Hits 12479 12236 -243
- Misses 11433 11584 +151
+ Partials 1067 1060 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [138 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.54%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 55.50% +5.54%
- Complexity 3645 3975 +330
============================================
Files 1010 998 -12
Lines 24979 24934 -45
Branches 2433 2431 -2
============================================
+ Hits 12479 13840 +1361
+ Misses 11433 9883 -1550
- Partials 1067 1211 +144
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| ... and [126 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601022753
##########
File path: oap-server/analyzer/meter-analyzer/pom.xml
##########
@@ -42,6 +42,16 @@
<groupId>io.vavr</groupId>
<artifactId>vavr</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.kubernetes</groupId>
+ <artifactId>client-java-api</artifactId>
+ <version>10.0.0</version>
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `0.03%`.
> The diff coverage is `11.82%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 39.02% +0.03%
+ Complexity 2765 2325 -440
============================================
Files 1005 812 -193
Lines 24880 20087 -4793
Branches 2423 1898 -525
============================================
- Hits 9700 7839 -1861
+ Misses 14427 11653 -2774
+ Partials 753 595 -158
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `34.70% <0.00%> (-18.85%)` | `32.00 <0.00> (-23.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `12.82% <12.82%> (ø)` | `6.00 <6.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `6.84% <100.00%> (-83.43%)` | `2.00 <0.00> (-19.00)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/library/util/prometheus/metrics/MetricType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY1R5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...library/util/prometheus/parser/sample/Context.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9wYXJzZXIvc2FtcGxlL0NvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...telemetry/prometheus/PrometheusMetricsCreator.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NDcmVhdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [325 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601203170
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,28 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
Review comment:
```suggestion
### Tag manipulator
#### K8s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `1.96%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 56.94% -1.97%
+ Complexity 4185 4111 -74
============================================
Files 997 999 +2
Lines 24973 25041 +68
Branches 2436 2442 +6
============================================
- Hits 14710 14259 -451
- Misses 8976 9580 +604
+ Partials 1287 1202 -85
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (-3.29%)` | `23.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.38% <0.00%> (-3.01%)` | `62.00 <0.00> (-1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `5.76% <0.00%> (-63.47%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [50 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601022831
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601209423
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,28 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+#### retagByK8sMeta
+`retagByK8sMeta(newLabelName, K8sRetagType, existingLabelName)`. Add a new label to the sample family based on an existing label's value. Provide several internal converting types, including
+- K8sRetagType.Pod2Service
+
+Add a sevice Label to the sample that already has a pod name.
+The newLabelValue is `serviceName.namespace`.
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600446868
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
+ private final Map<String/* ip */, V1Pod> ipPodMap = new ConcurrentHashMap<>();
+ private final Map<String/* ip */, String/* namespace:serviceName */> ipServiceMap = new ConcurrentHashMap<>();
+ private final Map<String/* podName */, String /* namespace:serviceName*/> podServiceMap = new ConcurrentHashMap<>();
+ private ExecutorService executor;
+
+ public static K8sInfoRegistry getInstance() {
+ return INSTANCE;
+ }
+
+ private void init() {
+ executor = Executors.newCachedThreadPool(
+ new ThreadFactoryBuilder()
+ .setNameFormat("K8sInfoRegistry-%d")
+ .setDaemon(true)
+ .build()
+ );
+ }
+
+ @SneakyThrows
+ public void start(Rule rule) {
+ if (isStarted.compareAndSet(false, true)) {
Review comment:
I have asked @wankai123 to adopt the current `pre-parser` logic to check whether initialize the k8s register.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `0.70%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 52.49% +0.70%
- Complexity 3754 3846 +92
============================================
Files 1010 997 -13
Lines 24989 24957 -32
Branches 2434 2437 +3
============================================
+ Hits 12942 13102 +160
+ Misses 10937 10744 -193
- Partials 1110 1111 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (+7.96%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| ... and [186 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `8.16%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 43.62% -8.17%
+ Complexity 3754 3104 -650
============================================
Files 1010 1792 +782
Lines 24989 38392 +13403
Branches 2434 4226 +1792
============================================
+ Hits 12942 16747 +3805
- Misses 10937 20660 +9723
+ Partials 1110 985 -125
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.64% <0.00%> (-1.92%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (+1.49%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [1346 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.76%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 44.75% +5.76%
+ Complexity 2765 2747 -18
============================================
Files 1005 843 -162
Lines 24880 21153 -3727
Branches 2423 2018 -405
============================================
- Hits 9700 9466 -234
+ Misses 14427 10953 -3474
+ Partials 753 734 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.23% <0.00%> (-1.31%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [267 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `3.86%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 55.03% -3.87%
+ Complexity 4185 3980 -205
============================================
Files 997 999 +2
Lines 24973 24937 -36
Branches 2436 2434 -2
============================================
- Hits 14710 13725 -985
- Misses 8976 10042 +1066
+ Partials 1287 1170 -117
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [87 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601023238
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
+ private final Map<String/* ip */, V1Pod> ipPodMap = new ConcurrentHashMap<>();
+ private final Map<String/* ip */, String/* namespace:serviceName */> ipServiceMap = new ConcurrentHashMap<>();
+ private final Map<String/* podName */, String /* namespace:serviceName*/> podServiceMap = new ConcurrentHashMap<>();
+ private ExecutorService executor;
+
+ public static K8sInfoRegistry getInstance() {
+ return INSTANCE;
+ }
+
+ private void init() {
+ executor = Executors.newCachedThreadPool(
+ new ThreadFactoryBuilder()
+ .setNameFormat("K8sInfoRegistry-%d")
+ .setDaemon(true)
+ .build()
+ );
+ }
+
+ @SneakyThrows
+ public void start(Rule rule) {
+ if (isStarted.compareAndSet(false, true)) {
Review comment:
changed the initialize logical
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `7.02%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 51.87% -7.03%
+ Complexity 4185 3740 -445
============================================
Files 997 998 +1
Lines 24973 24843 -130
Branches 2436 2424 -12
============================================
- Hits 14710 12888 -1822
- Misses 8976 10879 +1903
+ Partials 1287 1076 -211
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [170 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600139146
##########
File path: oap-server/analyzer/meter-analyzer/pom.xml
##########
@@ -42,6 +42,16 @@
<groupId>io.vavr</groupId>
<artifactId>vavr</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.kubernetes</groupId>
+ <artifactId>client-java-api</artifactId>
+ <version>10.0.0</version>
Review comment:
Please use the version managed by the OAP root pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `9.31%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head dd66816. Consider uploading reports for the commit dd66816 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 49.58% -9.32%
+ Complexity 4185 3644 -541
============================================
Files 997 998 +1
Lines 24973 24863 -110
Branches 2436 2423 -13
============================================
- Hits 14710 12328 -2382
- Misses 8976 11472 +2496
+ Partials 1287 1063 -224
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [172 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...dd66816](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (0708407) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `11.33%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 0708407 differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 47.57% -11.34%
+ Complexity 4185 3515 -670
=============================================
Files 997 999 +2
Lines 24973 24832 -141
Branches 2436 2422 -14
=============================================
- Hits 14710 11813 -2897
- Misses 8976 12010 +3034
+ Partials 1287 1009 -278
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [204 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `8.49%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 58.44% +8.49%
- Complexity 3645 4177 +532
============================================
Files 1010 998 -12
Lines 24979 25066 +87
Branches 2433 2444 +11
============================================
+ Hits 12479 14651 +2172
+ Misses 11433 9150 -2283
- Partials 1067 1265 +198
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.07% <0.00%> (+6.53%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [187 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `7.27%`.
> The diff coverage is `17.51%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 51.62% -7.28%
+ Complexity 4185 3918 -267
============================================
Files 997 1795 +798
Lines 24973 38427 +13454
Branches 2436 4228 +1792
============================================
+ Hits 14710 19838 +5128
- Misses 8976 17607 +8631
+ Partials 1287 982 -305
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...walking/apm/plugin/hbase/HTable100Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUxMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable200Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMDBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...walking/apm/plugin/hbase/HTable220Interceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGUyMjBJbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...skywalking/apm/plugin/hbase/HTableInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vaGJhc2UtMS54LTIueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9oYmFzZS9IVGFibGVJbnRlcmNlcHRvci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.21% <0.00%> (-9.36%)` | `23.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.56% <63.15%> (-6.82%)` | `56.00 <0.00> (-7.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1277 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `13.70%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 45.20% -13.71%
+ Complexity 4185 2626 -1559
=============================================
Files 997 813 -184
Lines 24973 20181 -4792
Branches 2436 1920 -516
=============================================
- Hits 14710 9122 -5588
- Misses 8976 10367 +1391
+ Partials 1287 692 -595
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601202181
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,28 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+#### retagByK8sMeta
+`retagByK8sMeta(newLabelName, K8sRetagType, existingLabelName)`. Add a new label to the sample family based on an existing label's value. Provide several internal converting types, including
Review comment:
```suggestion
`retagByK8sMeta(newLabelName, K8sRetagType, existingLabelName)`. Add a new tag to the sample family based on an existing label's value. Provide several internal converting types, including
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `2.67%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 49.11% -2.68%
+ Complexity 3754 3639 -115
============================================
Files 1010 997 -13
Lines 24989 24931 -58
Branches 2434 2432 -2
============================================
- Hits 12942 12246 -696
- Misses 10937 11661 +724
+ Partials 1110 1024 -86
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (+7.71%)` | `23.00 <0.00> (+1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.62% <18.18%> (+6.07%)` | `62.00 <0.00> (+7.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [169 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `4.09%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 54.05% +4.09%
- Complexity 3645 3854 +209
============================================
Files 1010 998 -12
Lines 24979 24916 -63
Branches 2433 2430 -3
============================================
+ Hits 12479 13468 +989
+ Misses 11433 10290 -1143
- Partials 1067 1158 +91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| ... and [96 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `1.98%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 49.80% -1.99%
+ Complexity 3754 3682 -72
============================================
Files 1010 997 -13
Lines 24989 24931 -58
Branches 2434 2432 -2
============================================
- Hits 12942 12417 -525
- Misses 10937 11474 +537
+ Partials 1110 1040 -70
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (+7.71%)` | `23.00 <0.00> (+1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.62% <18.18%> (+6.07%)` | `62.00 <0.00> (+7.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [163 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.63%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 55.59% +5.63%
- Complexity 3645 3981 +336
============================================
Files 1010 998 -12
Lines 24979 24934 -45
Branches 2433 2431 -2
============================================
+ Hits 12479 13862 +1383
+ Misses 11433 9861 -1572
- Partials 1067 1211 +144
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.34%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 44.32% +5.34%
+ Complexity 2765 2728 -37
============================================
Files 1005 843 -162
Lines 24880 21153 -3727
Branches 2423 2018 -405
============================================
- Hits 9700 9377 -323
+ Misses 14427 11047 -3380
+ Partials 753 729 -24
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.23% <0.00%> (-1.31%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [261 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `7.79%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 57.74% +7.79%
- Complexity 3645 4121 +476
============================================
Files 1010 998 -12
Lines 24979 25038 +59
Branches 2433 2439 +6
============================================
+ Hits 12479 14459 +1980
+ Misses 11433 9310 -2123
- Partials 1067 1269 +202
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.07% <0.00%> (+6.53%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [166 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `0.30%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 50.26% +0.30%
- Complexity 3645 3654 +9
============================================
Files 1010 998 -12
Lines 24979 24880 -99
Branches 2433 2429 -4
============================================
+ Hits 12479 12505 +26
+ Misses 11433 11276 -157
- Partials 1067 1099 +32
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [133 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `7.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 59.43% +7.63%
+ Complexity 3754 849 -2905
============================================
Files 1010 175 -835
Lines 24989 4284 -20705
Branches 2434 482 -1952
============================================
- Hits 12942 2546 -10396
+ Misses 10937 1422 -9515
+ Partials 1110 316 -794
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/ServiceInstanceGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvU2VydmljZUluc3RhbmNlR2VuZXJhdG9yLmphdmE=) | `77.77% <0.00%> (-11.12%)` | `6.00% <0.00%> (ø%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `92.30% <0.00%> (-7.70%)` | `3.00% <0.00%> (-1.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `53.57% <0.00%> (-7.15%)` | `5.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/conf/SnifferConfigInitializer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9TbmlmZmVyQ29uZmlnSW5pdGlhbGl6ZXIuamF2YQ==) | `55.31% <0.00%> (-4.26%)` | `14.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <0.00%> (-2.57%)` | `8.00% <0.00%> (-1.00%)` | |
| [...ava/org/apache/skywalking/apm/util/StringUtil.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvU3RyaW5nVXRpbC5qYXZh) | `43.90% <0.00%> (-2.44%)` | `16.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/ContextManager.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlci5qYXZh) | `47.72% <0.00%> (-2.28%)` | `18.00% <0.00%> (ø%)` | |
| ... and [837 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.77%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 44.76% +5.77%
+ Complexity 2765 2747 -18
============================================
Files 1005 843 -162
Lines 24880 21154 -3726
Branches 2423 2022 -401
============================================
- Hits 9700 9469 -231
+ Misses 14427 10952 -3475
+ Partials 753 733 -20
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [268 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `12.21%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 46.68% -12.22%
+ Complexity 4185 3475 -710
=============================================
Files 997 998 +1
Lines 24973 24818 -155
Branches 2436 2419 -17
=============================================
- Hits 14710 11586 -3124
- Misses 8976 12219 +3243
+ Partials 1287 1013 -274
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.84% <0.00%> (-9.54%)` | `56.00 <0.00> (-7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [210 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `16.29%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 42.60% -16.30%
+ Complexity 4185 2516 -1669
=============================================
Files 997 813 -184
Lines 24973 20162 -4811
Branches 2436 1920 -516
=============================================
- Hits 14710 8591 -6119
- Misses 8976 10927 +1951
+ Partials 1287 644 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [395 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `13.69%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 45.20% -13.70%
+ Complexity 4185 2626 -1559
=============================================
Files 997 813 -184
Lines 24973 20182 -4791
Branches 2436 1924 -512
=============================================
- Hits 14710 9124 -5586
- Misses 8976 10367 +1391
+ Partials 1287 691 -596
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [370 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `1.51%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 53.30% +1.51%
- Complexity 3754 3884 +130
============================================
Files 1010 997 -13
Lines 24989 24967 -22
Branches 2434 2438 +4
============================================
+ Hits 12942 13309 +367
+ Misses 10937 10531 -406
- Partials 1110 1127 +17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (+7.96%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [176 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `4.15%`.
> The diff coverage is `13.33%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 54.11% +4.15%
- Complexity 3645 4192 +547
============================================
Files 1010 1792 +782
Lines 24979 38464 +13485
Branches 2433 4233 +1800
============================================
+ Hits 12479 20815 +8336
- Misses 11433 16672 +5239
+ Partials 1067 977 -90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.96% <0.00%> (+7.42%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `14.44% <14.44%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `18.51% <0.00%> (-37.04%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r600196848
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,25 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+
+#### k8sTagServiceByPodName
+`k8sTagServiceByPodName(podName,serviceName)`. Add a sevice Label to the sample that already has a pod name.
+
+For example:
+```
+container_cpu_usage_seconds_total{container=my-nginx, cpu=total, pod=my-nginx-5dc4865748-mbczh} 2
+```
+Expression:
+```
+container_cpu_usage_seconds_total.k8sTagServiceByPodName('pod' , 'service')
+```
+Output:
+```
+container_cpu_usage_seconds_total{container=my-nginx, cpu=total, pod=my-nginx-5dc4865748-mbczh, service='default:nginx-service'} 2
Review comment:
*svc*.*namespace* is the canonical format for a service, for example, `nginx-service.default`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `6.22%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 45.20% +6.22%
Complexity 2765 2765
============================================
Files 1005 843 -162
Lines 24880 21157 -3723
Branches 2423 2022 -401
============================================
- Hits 9700 9565 -135
+ Misses 14427 10856 -3571
+ Partials 753 736 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [281 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `16.46%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 42.44% -16.47%
+ Complexity 4185 2500 -1685
=============================================
Files 997 813 -184
Lines 24973 20153 -4820
Branches 2436 1920 -516
=============================================
- Hits 14710 8553 -6157
- Misses 8976 10956 +1980
+ Partials 1287 644 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [399 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `10.56%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 51.79% 41.22% -10.57%
+ Complexity 3754 2780 -974
=============================================
Files 1010 1792 +782
Lines 24989 38388 +13399
Branches 2434 4226 +1792
=============================================
+ Hits 12942 15826 +2884
- Misses 10937 21578 +10641
+ Partials 1110 984 -126
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.64% <0.00%> (-1.92%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (+1.49%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `1.55%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 53.34% +1.55%
- Complexity 3754 3885 +131
============================================
Files 1010 997 -13
Lines 24989 24967 -22
Branches 2434 2438 +4
============================================
+ Hits 12942 13319 +377
+ Misses 10937 10520 -417
- Partials 1110 1128 +18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (+7.96%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [176 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.93%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head dd66816. Consider uploading reports for the commit dd66816 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 52.97% -5.94%
+ Complexity 4185 3874 -311
============================================
Files 997 998 +1
Lines 24973 24900 -73
Branches 2436 2424 -12
============================================
- Hits 14710 13190 -1520
- Misses 8976 10544 +1568
+ Partials 1287 1166 -121
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [116 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...dd66816](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `17.47%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 41.43% -17.48%
+ Complexity 4185 2553 -1632
=============================================
Files 997 844 -153
Lines 24973 21140 -3833
Branches 2436 2016 -420
=============================================
- Hits 14710 8759 -5951
- Misses 8976 11711 +2735
+ Partials 1287 670 -617
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.84% <0.00%> (-9.54%)` | `56.00 <0.00> (-7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [380 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601199063
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,27 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+#### retagByK8sMeta
+`retagByK8sMeta(newLabelName, K8sRetagType, existingLabelName)`. Add a new label to the sample family based on an existing label's value. Provide several internal converting types, including
+- K8sRetagType.Pod2Service
Review comment:
```suggestion
- K8sRetagType.Pod2Service
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (0708407) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **increase** coverage by `0.52%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0708407 differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 58.90% 59.43% +0.52%
+ Complexity 4185 849 -3336
============================================
Files 997 175 -822
Lines 24973 4284 -20689
Branches 2436 482 -1954
============================================
- Hits 14710 2546 -12164
+ Misses 8976 1422 -7554
+ Partials 1287 316 -971
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...enhance/ClassStaticMethodsEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NTdGF0aWNNZXRob2RzRW5oYW5jZVBsdWdpbkRlZmluZS5qYXZh) | `33.33% <0.00%> (-66.67%)` | `1.00% <0.00%> (-2.00%)` | |
| [...plugin/interceptor/enhance/StaticMethodsInter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvU3RhdGljTWV0aG9kc0ludGVyLmphdmE=) | `3.84% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...gin/interceptor/enhance/MethodInterceptResult.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvTWV0aG9kSW50ZXJjZXB0UmVzdWx0LmphdmE=) | `50.00% <0.00%> (-50.00%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...lking/apm/agent/core/ServiceInstanceGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvU2VydmljZUluc3RhbmNlR2VuZXJhdG9yLmphdmE=) | `77.77% <0.00%> (-11.12%)` | `6.00% <0.00%> (ø%)` | |
| [.../interceptor/enhance/ClassEnhancePluginDefine.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2ludGVyY2VwdG9yL2VuaGFuY2UvQ2xhc3NFbmhhbmNlUGx1Z2luRGVmaW5lLmphdmE=) | `47.67% <0.00%> (-10.47%)` | `15.00% <0.00%> (-4.00%)` | |
| [...ing/apm/agent/core/context/CorrelationContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db3JyZWxhdGlvbkNvbnRleHQuamF2YQ==) | `20.63% <0.00%> (-9.53%)` | `6.00% <0.00%> (-3.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `92.30% <0.00%> (-7.70%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [828 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `10.14%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head bf8ada5. Consider uploading reports for the commit bf8ada5 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 48.76% -10.15%
+ Complexity 4185 3588 -597
=============================================
Files 997 998 +1
Lines 24973 24863 -110
Branches 2436 2423 -13
=============================================
- Hits 14710 12124 -2586
- Misses 8976 11687 +2711
+ Partials 1287 1052 -235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [184 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...bf8ada5](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `8.13%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 58.09% +8.13%
- Complexity 3645 4146 +501
============================================
Files 1010 998 -12
Lines 24979 25038 +59
Branches 2433 2439 +6
============================================
+ Hits 12479 14546 +2067
+ Misses 11433 9234 -2199
- Partials 1067 1258 +191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.07% <0.00%> (+6.53%)` | `63.00 <0.00> (+8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...r/envoy/als/k8s/K8sALSServiceMeshHTTPAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL2s4cy9LOHNBTFNTZXJ2aWNlTWVzaEhUVFBBbmFseXNpcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [178 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `2.84%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 52.80% +2.84%
- Complexity 3645 3786 +141
============================================
Files 1010 998 -12
Lines 24979 24916 -63
Branches 2433 2430 -3
============================================
+ Hits 12479 13157 +678
+ Misses 11433 10620 -813
- Partials 1067 1139 +72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `16.12% <0.00%> (-77.42%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [108 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (0708407) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `15.02%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 0708407 differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 43.87% -15.03%
+ Complexity 4185 3281 -904
=============================================
Files 997 999 +2
Lines 24973 24823 -150
Branches 2436 2422 -14
=============================================
- Hits 14710 10892 -3818
- Misses 8976 12978 +4002
+ Partials 1287 953 -334
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [241 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (789391c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.63%`.
> The diff coverage is `5.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.26% -5.64%
+ Complexity 4185 3201 -984
============================================
Files 997 843 -154
Lines 24973 21343 -3630
Branches 2436 2037 -399
============================================
- Hits 14710 11369 -3341
- Misses 8976 9058 +82
+ Partials 1287 916 -371
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.98% <0.00%> (-0.59%)` | `24.00 <0.00> (ø)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (-1.88%)` | `63.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...r/handler/JVMMetricReportServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctanZtLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2p2bS9wcm92aWRlci9oYW5kbGVyL0pWTU1ldHJpY1JlcG9ydFNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `15.84%`.
> The diff coverage is `5.37%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 51.79% 35.94% -15.85%
+ Complexity 3754 2780 -974
=============================================
Files 1010 996 -14
Lines 24989 24590 -399
Branches 2434 2378 -56
=============================================
- Hits 12942 8838 -4104
- Misses 10937 14976 +4039
+ Partials 1110 776 -334
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-3.10%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-1.47%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [275 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601022892
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,25 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+
+#### k8sTagServiceByPodName
+`k8sTagServiceByPodName(podName,serviceName)`. Add a sevice Label to the sample that already has a pod name.
Review comment:
done
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.prometheus.rule.Rule;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final List<String> matchedFunc = Arrays.asList(".k8sTagServiceByPodName");
+ private final Map<String/* ip */, V1Pod> ipPodMap = new ConcurrentHashMap<>();
+ private final Map<String/* ip */, String/* namespace:serviceName */> ipServiceMap = new ConcurrentHashMap<>();
+ private final Map<String/* podName */, String /* namespace:serviceName*/> podServiceMap = new ConcurrentHashMap<>();
+ private ExecutorService executor;
+
+ public static K8sInfoRegistry getInstance() {
+ return INSTANCE;
+ }
+
+ private void init() {
+ executor = Executors.newCachedThreadPool(
+ new ThreadFactoryBuilder()
+ .setNameFormat("K8sInfoRegistry-%d")
+ .setDaemon(true)
+ .build()
+ );
+ }
+
+ @SneakyThrows
+ public void start(Rule rule) {
+ if (isStarted.compareAndSet(false, true)) {
+ if (!matchFunc2Start(rule)) {
+ return;
+ }
+ init();
+ final ApiClient apiClient = Config.defaultClient();
+ apiClient.setHttpClient(apiClient.getHttpClient()
+ .newBuilder()
+ .readTimeout(0, TimeUnit.SECONDS)
+ .build());
+ Configuration.setDefaultApiClient(apiClient);
+
+ final CoreV1Api coreV1Api = new CoreV1Api();
+ final SharedInformerFactory factory = new SharedInformerFactory(executor);
+
+ listenEndpointsEvents(coreV1Api, factory);
+ listenPodEvents(coreV1Api, factory);
+ factory.startAllRegisteredInformers();
+ }
+ }
+
+ private boolean matchFunc2Start(Rule rule) {
+ for (String mf : matchedFunc) {
+ return rule.getMetricsRules().stream().anyMatch(r -> r.getExp().split(mf).length > 1);
+
+ }
+ return false;
+ }
+
+ private void listenEndpointsEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listEndpointsForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Endpoints.class,
+ V1EndpointsList.class
+ ).addEventHandler(new ResourceEventHandler<V1Endpoints>() {
+ @Override
+ public void onAdd(final V1Endpoints endpoints) {
+ addEndpoints(endpoints);
+ }
+
+ @Override
+ public void onUpdate(final V1Endpoints oldEndpoints, final V1Endpoints newEndpoints) {
+ addEndpoints(newEndpoints);
+ }
+
+ @Override
+ public void onDelete(final V1Endpoints endpoints, final boolean deletedFinalStateUnknown) {
+ removeEndpoints(endpoints);
+ }
+ });
+ }
+
+ private void listenPodEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listPodForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Pod.class,
+ V1PodList.class
+ ).addEventHandler(new ResourceEventHandler<V1Pod>() {
+ @Override
+ public void onAdd(final V1Pod pod) {
+ addPod(pod);
+ }
+
+ @Override
+ public void onUpdate(final V1Pod oldPod, final V1Pod newPod) {
+ addPod(newPod);
+ }
+
+ @Override
+ public void onDelete(final V1Pod pod, final boolean deletedFinalStateUnknown) {
+ removePod(pod);
+ }
+ });
+ }
+
+ private void addPod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.put(status.getPodIP(), pod)
+ );
+
+ recompose();
+ }
+
+ private void removePod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.remove(status.getPodIP())
+ );
+ }
+
+ private void addEndpoints(final V1Endpoints endpoints) {
+ V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
+ if (isNull(endpointsMetadata)) {
+ log.error("Endpoints metadata is null: {}", endpoints);
+ return;
+ }
+
+ final String namespace = endpointsMetadata.getNamespace();
+ final String name = endpointsMetadata.getName();
+
+ ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
+ subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
+ address -> ipServiceMap.put(address.getIp(), namespace + ":" + name)
+ ))
+ ));
+
+ recompose();
+ }
+
+ private void removeEndpoints(final V1Endpoints endpoints) {
+ ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
+ subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
+ address -> ipServiceMap.remove(address.getIp())
+ ))
+ ));
+ }
+
+ private void recompose() {
+ ipPodMap.forEach((ip, pod) -> {
+ final String namespaceService = ipServiceMap.get(ip);
+ if (isNullOrEmpty(namespaceService)) {
+ return;
+ }
+
+ final V1ObjectMeta podMetadata = pod.getMetadata();
+ if (isNull(podMetadata)) {
+ log.warn("Pod metadata is null, {}", pod);
+ return;
+ }
+
+ podServiceMap.put(pod.getMetadata().getName(), namespaceService);
Review comment:
ignore
##########
File path: docs/en/concepts-and-designs/mal.md
##########
@@ -57,6 +57,25 @@ For example, this filters all instance_trace_count samples for values >= 33:
```
instance_trace_count.valueGreaterEqual(33)
```
+### K8s
+MAL support add specific Labels to the samples that collect from K8s metrics collectors.
+This feature need OAP Server has the authority to access the K8s's `API Server`.
+
+#### k8sTagServiceByPodName
+`k8sTagServiceByPodName(podName,serviceName)`. Add a sevice Label to the sample that already has a pod name.
+
+For example:
+```
+container_cpu_usage_seconds_total{container=my-nginx, cpu=total, pod=my-nginx-5dc4865748-mbczh} 2
+```
+Expression:
+```
+container_cpu_usage_seconds_total.k8sTagServiceByPodName('pod' , 'service')
+```
+Output:
+```
+container_cpu_usage_seconds_total{container=my-nginx, cpu=total, pod=my-nginx-5dc4865748-mbczh, service='default:nginx-service'} 2
Review comment:
done
##########
File path: oap-server/analyzer/meter-analyzer/src/test/java/org/apache/skywalking/oap/meter/analyzer/dsl/K8sTagTest.java
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.dsl;
+
+import com.google.common.collect.ImmutableMap;
+import java.util.Arrays;
+import java.util.Collection;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.skywalking.oap.meter.analyzer.k8s.K8sInfoRegistry;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.mockito.Mockito;
+import org.powermock.reflect.Whitebox;
+
+import static com.google.common.collect.ImmutableMap.of;
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.fail;
+import static org.mockito.Mockito.when;
+
+@Slf4j
+@RunWith(Parameterized.class)
+public class K8sTagTest {
+
+ @Parameterized.Parameter
+ public String name;
+
+ @Parameterized.Parameter(1)
+ public ImmutableMap<String, SampleFamily> input;
+
+ @Parameterized.Parameter(2)
+ public String expression;
+
+ @Parameterized.Parameter(3)
+ public Result want;
+
+ @Parameterized.Parameter(4)
+ public boolean isThrow;
+
+ @Parameterized.Parameters(name = "{index}: {0}")
+ public static Collection<Object[]> data() {
+ return Arrays.asList(new Object[][] {
+ {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `2.85%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 48.93% -2.86%
+ Complexity 3754 3619 -135
============================================
Files 1010 997 -13
Lines 24989 24931 -58
Branches 2434 2432 -2
============================================
- Hits 12942 12200 -742
- Misses 10937 11702 +765
+ Partials 1110 1029 -81
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (+7.71%)` | `23.00 <0.00> (+1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.62% <18.18%> (+6.07%)` | `62.00 <0.00> (+7.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [161 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `4.20%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 43.19% +4.20%
+ Complexity 2765 2678 -87
============================================
Files 1005 843 -162
Lines 24880 21143 -3737
Branches 2423 2017 -406
============================================
- Hits 9700 9133 -567
+ Misses 14427 11305 -3122
+ Partials 753 705 -48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.23% <0.00%> (-1.31%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [248 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `0.53%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 52.32% +0.53%
- Complexity 3754 3835 +81
============================================
Files 1010 997 -13
Lines 24989 24956 -33
Branches 2434 2433 -1
============================================
+ Hits 12942 13058 +116
+ Misses 10937 10787 -150
- Partials 1110 1111 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.13% <18.18%> (+7.58%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601100202
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/DSL.java
##########
@@ -37,6 +38,9 @@
public static Expression parse(final String expression) {
CompilerConfiguration cc = new CompilerConfiguration();
cc.setScriptBaseClass(DelegatingScript.class.getName());
+ ImportCustomizer icz = new ImportCustomizer();
+ icz.addImport("K8sRetagType", "org.apache.skywalking.oap.meter.analyzer.dsl.SampleFamily.K8sRetagType");
Review comment:
```suggestion
icz.addImport("K8sRetagType", K8sRetagType.class.getName());
```
This should be safer for potential refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#discussion_r601032031
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final Map<String/* ip */, V1Pod> ipPodMap = new ConcurrentHashMap<>();
+ private final Map<String/* ip */, String/* serviceName.namespace */> ipServiceMap = new ConcurrentHashMap<>();
+ private final Map<String/* podName */, String /* serviceName.namespace */> podServiceMap = new ConcurrentHashMap<>();
+ private ExecutorService executor;
+
+ public static K8sInfoRegistry getInstance() {
+ return INSTANCE;
+ }
+
+ private void init() {
+ executor = Executors.newCachedThreadPool(
+ new ThreadFactoryBuilder()
+ .setNameFormat("K8sInfoRegistry-%d")
+ .setDaemon(true)
+ .build()
+ );
+ }
+
+ @SneakyThrows
+ public void start() {
+ if (isStarted.compareAndSet(false, true)) {
+ init();
+ final ApiClient apiClient = Config.defaultClient();
+ apiClient.setHttpClient(apiClient.getHttpClient()
+ .newBuilder()
+ .readTimeout(0, TimeUnit.SECONDS)
+ .build());
+ Configuration.setDefaultApiClient(apiClient);
+
+ final CoreV1Api coreV1Api = new CoreV1Api();
+ final SharedInformerFactory factory = new SharedInformerFactory(executor);
+
+ listenEndpointsEvents(coreV1Api, factory);
+ listenPodEvents(coreV1Api, factory);
+ factory.startAllRegisteredInformers();
+ }
+ }
+
+ private void listenEndpointsEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listEndpointsForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Endpoints.class,
+ V1EndpointsList.class
+ ).addEventHandler(new ResourceEventHandler<V1Endpoints>() {
+ @Override
+ public void onAdd(final V1Endpoints endpoints) {
+ addEndpoints(endpoints);
+ }
+
+ @Override
+ public void onUpdate(final V1Endpoints oldEndpoints, final V1Endpoints newEndpoints) {
+ addEndpoints(newEndpoints);
+ }
+
+ @Override
+ public void onDelete(final V1Endpoints endpoints, final boolean deletedFinalStateUnknown) {
+ removeEndpoints(endpoints);
+ }
+ });
+ }
+
+ private void listenPodEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listPodForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Pod.class,
+ V1PodList.class
+ ).addEventHandler(new ResourceEventHandler<V1Pod>() {
+ @Override
+ public void onAdd(final V1Pod pod) {
+ addPod(pod);
+ }
+
+ @Override
+ public void onUpdate(final V1Pod oldPod, final V1Pod newPod) {
+ addPod(newPod);
+ }
+
+ @Override
+ public void onDelete(final V1Pod pod, final boolean deletedFinalStateUnknown) {
+ removePod(pod);
+ }
+ });
+ }
+
+ private void addPod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ofNullable(status.getPodIP()).ifPresent(
+ ip -> ipPodMap.put(ip, pod))
+ );
+
+ recompose();
+ }
+
+ private void removePod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.remove(status.getPodIP())
+ );
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(pod.getMetadata().getName())
+ );
+ }
+
+ private void addEndpoints(final V1Endpoints endpoints) {
+ V1ObjectMeta endpointsMetadata = endpoints.getMetadata();
+ if (isNull(endpointsMetadata)) {
+ log.error("Endpoints metadata is null: {}", endpoints);
+ return;
+ }
+
+ final String namespace = endpointsMetadata.getNamespace();
+ final String name = endpointsMetadata.getName();
+
+ ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
+ subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
+ address -> ipServiceMap.put(address.getIp(), name + "." + namespace)
+ ))
+ ));
+
+ recompose();
+ }
+
+ private void removeEndpoints(final V1Endpoints endpoints) {
+ ofNullable(endpoints.getSubsets()).ifPresent(subsets -> subsets.forEach(
+ subset -> ofNullable(subset.getAddresses()).ifPresent(addresses -> addresses.forEach(
+ address -> ipServiceMap.remove(address.getIp())
+ ))
+ ));
+ recompose();
+ }
+
+ private void recompose() {
+ ipPodMap.forEach((ip, pod) -> {
+ final String namespaceService = ipServiceMap.get(ip);
+ if (isNullOrEmpty(namespaceService)) {
+ podServiceMap.remove(ip);
+ return;
+ }
+
+ final V1ObjectMeta podMetadata = pod.getMetadata();
+ if (isNull(podMetadata)) {
+ log.warn("Pod metadata is null, {}", pod);
+ return;
+ }
+
+ podServiceMap.put(pod.getMetadata().getName(), namespaceService);
Review comment:
*NULL_DEREFERENCE:* object returned by `pod.getMetadata()` could be null and is dereferenced at line 217.
(at-me [in a reply](https://docs.muse.dev/docs/talk-to-muse/) with `help` or `ignore`)
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java
##########
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.k8s;
+
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import io.kubernetes.client.informer.ResourceEventHandler;
+import io.kubernetes.client.informer.SharedInformerFactory;
+import io.kubernetes.client.openapi.Configuration;
+import io.kubernetes.client.openapi.apis.CoreV1Api;
+import io.kubernetes.client.openapi.models.V1Endpoints;
+import io.kubernetes.client.openapi.models.V1EndpointsList;
+import io.kubernetes.client.openapi.models.V1ObjectMeta;
+import io.kubernetes.client.openapi.models.V1PodList;
+import io.kubernetes.client.util.Config;
+import io.kubernetes.client.openapi.ApiClient;
+import io.kubernetes.client.openapi.models.V1Pod;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static java.util.Objects.isNull;
+import static java.util.Optional.ofNullable;
+
+@Slf4j
+public class K8sInfoRegistry {
+
+ private final static K8sInfoRegistry INSTANCE = new K8sInfoRegistry();
+ private final AtomicBoolean isStarted = new AtomicBoolean(false);
+ private final Map<String/* ip */, V1Pod> ipPodMap = new ConcurrentHashMap<>();
+ private final Map<String/* ip */, String/* serviceName.namespace */> ipServiceMap = new ConcurrentHashMap<>();
+ private final Map<String/* podName */, String /* serviceName.namespace */> podServiceMap = new ConcurrentHashMap<>();
+ private ExecutorService executor;
+
+ public static K8sInfoRegistry getInstance() {
+ return INSTANCE;
+ }
+
+ private void init() {
+ executor = Executors.newCachedThreadPool(
+ new ThreadFactoryBuilder()
+ .setNameFormat("K8sInfoRegistry-%d")
+ .setDaemon(true)
+ .build()
+ );
+ }
+
+ @SneakyThrows
+ public void start() {
+ if (isStarted.compareAndSet(false, true)) {
+ init();
+ final ApiClient apiClient = Config.defaultClient();
+ apiClient.setHttpClient(apiClient.getHttpClient()
+ .newBuilder()
+ .readTimeout(0, TimeUnit.SECONDS)
+ .build());
+ Configuration.setDefaultApiClient(apiClient);
+
+ final CoreV1Api coreV1Api = new CoreV1Api();
+ final SharedInformerFactory factory = new SharedInformerFactory(executor);
+
+ listenEndpointsEvents(coreV1Api, factory);
+ listenPodEvents(coreV1Api, factory);
+ factory.startAllRegisteredInformers();
+ }
+ }
+
+ private void listenEndpointsEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listEndpointsForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Endpoints.class,
+ V1EndpointsList.class
+ ).addEventHandler(new ResourceEventHandler<V1Endpoints>() {
+ @Override
+ public void onAdd(final V1Endpoints endpoints) {
+ addEndpoints(endpoints);
+ }
+
+ @Override
+ public void onUpdate(final V1Endpoints oldEndpoints, final V1Endpoints newEndpoints) {
+ addEndpoints(newEndpoints);
+ }
+
+ @Override
+ public void onDelete(final V1Endpoints endpoints, final boolean deletedFinalStateUnknown) {
+ removeEndpoints(endpoints);
+ }
+ });
+ }
+
+ private void listenPodEvents(final CoreV1Api coreV1Api, final SharedInformerFactory factory) {
+ factory.sharedIndexInformerFor(
+ params -> coreV1Api.listPodForAllNamespacesCall(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ params.resourceVersion,
+ 300,
+ params.watch,
+ null
+ ),
+ V1Pod.class,
+ V1PodList.class
+ ).addEventHandler(new ResourceEventHandler<V1Pod>() {
+ @Override
+ public void onAdd(final V1Pod pod) {
+ addPod(pod);
+ }
+
+ @Override
+ public void onUpdate(final V1Pod oldPod, final V1Pod newPod) {
+ addPod(newPod);
+ }
+
+ @Override
+ public void onDelete(final V1Pod pod, final boolean deletedFinalStateUnknown) {
+ removePod(pod);
+ }
+ });
+ }
+
+ private void addPod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ofNullable(status.getPodIP()).ifPresent(
+ ip -> ipPodMap.put(ip, pod))
+ );
+
+ recompose();
+ }
+
+ private void removePod(final V1Pod pod) {
+ ofNullable(pod.getStatus()).ifPresent(
+ status -> ipPodMap.remove(status.getPodIP())
+ );
+ ofNullable(pod.getMetadata()).ifPresent(
+ metadata -> podServiceMap.remove(pod.getMetadata().getName())
Review comment:
*NULL_DEREFERENCE:* object returned by `pod.getMetadata()` could be null and is dereferenced at line 171.
(at-me [in a reply](https://docs.muse.dev/docs/talk-to-muse/) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `0.33%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 51.45% -0.34%
- Complexity 3754 3782 +28
============================================
Files 1010 997 -13
Lines 24989 24956 -33
Branches 2434 2433 -1
============================================
- Hits 12942 12841 -101
- Misses 10937 11028 +91
+ Partials 1110 1087 -23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.13% <18.18%> (+7.58%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [196 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (179009c) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `6.89%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 179009c differs from pull request most recent head c7b8807. Consider uploading reports for the commit c7b8807 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 52.01% -6.90%
+ Complexity 4185 3749 -436
============================================
Files 997 998 +1
Lines 24973 24843 -130
Branches 2436 2424 -12
============================================
- Hits 14710 12921 -1789
- Misses 8976 10845 +1869
+ Partials 1287 1077 -210
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.69% <0.00%> (-10.70%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [166 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `5.74%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 55.70% +5.74%
- Complexity 3645 3984 +339
============================================
Files 1010 998 -12
Lines 24979 24934 -45
Branches 2433 2431 -2
============================================
+ Hits 12479 13889 +1410
+ Misses 11433 9826 -1607
- Partials 1067 1219 +152
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...zer/agent/kafka/provider/KafkaFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9LYWZrYUZldGNoZXJQcm92aWRlci5qYXZh) | `85.71% <0.00%> (-4.77%)` | `9.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/analysis/IDManager.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvSURNYW5hZ2VyLmphdmE=) | `62.74% <0.00%> (-1.84%)` | `2.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (d6acb99) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `5.52%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head d6acb99 differs from pull request most recent head 789391c. Consider uploading reports for the commit 789391c to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 58.90% 53.38% -5.53%
+ Complexity 4185 3828 -357
============================================
Files 997 998 +1
Lines 24973 24893 -80
Branches 2436 2425 -11
============================================
- Hits 14710 13288 -1422
- Misses 8976 10495 +1519
+ Partials 1287 1110 -177
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.07% <18.18%> (-11.32%)` | `55.00 <0.00> (-8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [113 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [51b60ae...789391c](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `10.57%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head bf8ada5. Consider uploading reports for the commit bf8ada5 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 48.32% -10.58%
+ Complexity 4185 3569 -616
=============================================
Files 997 998 +1
Lines 24973 24863 -110
Branches 2436 2423 -13
=============================================
- Hits 14710 12015 -2695
- Misses 8976 11819 +2843
+ Partials 1287 1029 -258
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.43% <0.00%> (-9.96%)` | `56.00 <0.00> (-7.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [188 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...bf8ada5](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `0.10%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 51.68% -0.11%
- Complexity 3754 3791 +37
============================================
Files 1010 997 -13
Lines 24989 24956 -33
Branches 2434 2433 -1
============================================
- Hits 12942 12899 -43
- Misses 10937 10959 +22
+ Partials 1110 1098 -12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.13% <18.18%> (+7.58%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [196 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (316ef34) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `30.98%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 316ef34 differs from pull request most recent head f95983d. Consider uploading reports for the commit f95983d to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 27.92% -30.99%
+ Complexity 4185 1737 -2448
=============================================
Files 997 811 -186
Lines 24973 20048 -4925
Branches 2436 1911 -525
=============================================
- Hits 14710 5598 -9112
- Misses 8976 14045 +5069
+ Partials 1287 405 -882
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `51.90% <0.00%> (-11.48%)` | `55.00 <0.00> (-8.00)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [570 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...f95983d](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `2.23%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 49.95% 52.19% +2.23%
- Complexity 3645 3763 +118
============================================
Files 1010 998 -12
Lines 24979 24916 -63
Branches 2433 2430 -3
============================================
+ Hits 12479 13005 +526
+ Misses 11433 10781 -652
- Partials 1067 1130 +63
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...lyzer/agent/kafka/provider/handler/LogHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL0xvZ0hhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.37%)` | `0.00% <0.00%> (-5.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [113 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (309bc9c) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `6.23%`.
> The diff coverage is `15.05%`.
> :exclamation: Current head 309bc9c differs from pull request most recent head d828434. Consider uploading reports for the commit d828434 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 38.98% 45.21% +6.23%
- Complexity 2765 2766 +1
============================================
Files 1005 843 -162
Lines 24880 21157 -3723
Branches 2423 2022 -401
============================================
- Hits 9700 9567 -133
+ Misses 14427 10855 -3572
+ Partials 753 735 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.61% <0.00%> (-0.94%)` | `56.00 <0.00> (+1.00)` | :arrow_down: |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `16.66% <16.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...analyzer/prometheus/PrometheusMetricConverter.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljQ29udmVydGVyLmphdmE=) | `90.41% <100.00%> (+0.13%)` | `21.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [280 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...d828434](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `4.86%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 56.65% +4.86%
- Complexity 3754 4048 +294
============================================
Files 1010 998 -12
Lines 24989 25048 +59
Branches 2434 2443 +9
============================================
+ Hits 12942 14190 +1248
+ Misses 10937 9673 -1264
- Partials 1110 1185 +75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.98% <0.00%> (+10.42%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (+7.96%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch7/query/ES7EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9FUzdFdmVudFF1ZXJ5REFPLmphdmE=) | `18.18% <0.00%> (-81.82%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9FdmVudFF1ZXJ5REFPLmphdmE=) | `1.51% <0.00%> (-60.61%)` | `1.00% <0.00%> (-6.00%)` | |
| [...ge/plugin/elasticsearch/query/ESEventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvRVNFdmVudFF1ZXJ5REFPLmphdmE=) | `3.44% <0.00%> (-55.18%)` | `1.00% <0.00%> (-3.00%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2EventQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyRXZlbnRRdWVyeURBTy5qYXZh) | `1.58% <0.00%> (-46.04%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [134 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (74b247a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **increase** coverage by `1.39%`.
> The diff coverage is `5.37%`.
> :exclamation: Current head 74b247a differs from pull request most recent head e08122a. Consider uploading reports for the commit e08122a to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
+ Coverage 51.79% 53.18% +1.39%
- Complexity 3754 3875 +121
============================================
Files 1010 997 -13
Lines 24989 24967 -22
Branches 2434 2438 +4
============================================
+ Hits 12942 13279 +337
+ Misses 10937 10561 -376
- Partials 1110 1127 +17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.08% <0.00%> (+9.52%)` | `24.00 <0.00> (+2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `61.50% <18.18%> (+7.96%)` | `63.00 <0.00> (+8.00)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.21% <0.00%> (-90.53%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.04% <0.00%> (-86.96%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function `retagByK8sMeta` and opt type `K8sRetagType.Pod2Service` in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (c7b8807) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `15.28%`.
> The diff coverage is `3.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
=============================================
- Coverage 58.90% 43.62% -15.29%
+ Complexity 4185 2682 -1503
=============================================
Files 997 844 -153
Lines 24973 21140 -3833
Branches 2436 2016 -420
=============================================
- Hits 14710 9222 -5488
- Misses 8976 11200 +2224
+ Partials 1287 718 -569
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `53.84% <0.00%> (-9.54%)` | `56.00 <0.00> (-7.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [365 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [073fbbc...c7b8807](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6608: Add function 'k8sTagServiceByPodName' in MAL for k8s to relate pods and services.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6608:
URL: https://github.com/apache/skywalking/pull/6608#issuecomment-805464966
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=h1) Report
> Merging [#6608](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=desc) (e08122a) into [master](https://codecov.io/gh/apache/skywalking/commit/f3b567160ce61675cb692c3417101162d67093de?el=desc) (f3b5671) will **decrease** coverage by `7.19%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6608 +/- ##
============================================
- Coverage 51.79% 44.59% -7.20%
+ Complexity 3754 3167 -587
============================================
Files 1010 1792 +782
Lines 24989 38392 +13403
Branches 2434 4226 +1792
============================================
+ Hits 12942 17122 +4180
- Misses 10937 20283 +9346
+ Partials 1110 987 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.64% <0.00%> (-1.92%)` | `21.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `10.11% <10.11%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.03% <60.86%> (+1.49%)` | `55.00 <0.00> (ø)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/CPMMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9DUE1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/6608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=footer). Last update [f3b5671...e08122a](https://codecov.io/gh/apache/skywalking/pull/6608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org