Re: [PR] fix(examples): replace deprecated groupby field with columns in birth_names/world_bank [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #43468:
URL: https://github.com/apache/superset/pull/43468#issuecomment-5612536762

   @eschutho thanks for chasing this one down, but I think the rename landed one layer too high. The deprecation warning is about the `QueryObject` field, and chart form data still wants `groupby`. `extractQueryFields` on the frontend ignores `columns` in aggregate mode and only translates `groupby` into the query object, so the pie, timeseries, and treemap examples would lose their dimensions with this in. CodeAnt's threads are flagging the same thing.
   
   Also, GitHub shows conflicts with `master`, though I'd hold off on the rebase until we sort out the above. Holler if you want a second set of eyes on where the warning is actually coming from.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org