You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/10/17 21:06:12 UTC
[GitHub] [fineract] vidakovic opened a new pull request #1420: FINERACT-1214: SDK Swagger Client Java API methods returning Rx Observer
vidakovic opened a new pull request #1420:
URL: https://github.com/apache/fineract/pull/1420
## Description
Was very simple, just one code generator option.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1420: FINERACT-1214: SDK Swagger Client Java API methods returning Rx Observer
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1420:
URL: https://github.com/apache/fineract/pull/1420#issuecomment-711147073
As per new conclusion in FINERACT-1214, we can temporarily change this first, and then add another client with Rx API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1420: FINERACT-1214: SDK Swagger Client Java API methods returning Rx Observer
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1420:
URL: https://github.com/apache/fineract/pull/1420#issuecomment-711080634
@Grandolf49 we'll wait with proceeding here until we hear your thoughts in the FINERACT-1214 discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1420: FINERACT-1214: SDK Swagger Client Java API methods returning Rx Observer
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1420:
URL: https://github.com/apache/fineract/pull/1420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org