You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/01 03:37:00 UTC
[jira] [Work logged] (BEAM-7434) RabbitMqIO uses a deprecated API
[ https://issues.apache.org/jira/browse/BEAM-7434?focusedWorklogId=337162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337162 ]
ASF GitHub Bot logged work on BEAM-7434:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/19 03:36
Start Date: 01/Nov/19 03:36
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #9900: [BEAM-7434] [BEAM-5895] and [BEAM-5894] Upgrade to rabbit amqp-client 5.x
URL: https://github.com/apache/beam/pull/9900#discussion_r341442028
##########
File path: sdks/java/io/rabbitmq/src/main/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIO.java
##########
@@ -462,12 +449,14 @@ public boolean start() throws IOException {
@Override
public boolean advance() throws IOException {
try {
- QueueingConsumer.Delivery delivery = consumer.nextDelivery(1000);
+ Channel channel = connectionHandler.getChannel();
+ // we consume message without autoAck (we want to do the ack ourselves)
+ GetResponse delivery = channel.basicGet(queueName, false);
Review comment:
@chamikaramj @dpmills @reuvenlax might have good guidance here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 337162)
Time Spent: 40m (was: 0.5h)
> RabbitMqIO uses a deprecated API
> --------------------------------
>
> Key: BEAM-7434
> URL: https://issues.apache.org/jira/browse/BEAM-7434
> Project: Beam
> Issue Type: Bug
> Components: io-java-rabbitmq
> Reporter: Nicolas Delsaux
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The RabbitMqIo class reader (UnboundedRabbitMqReader) uses the QueueingConsumer, which is denoted as deprecated on RabbitMq side. RabbitMqIo should replace this consumer with the DefaultConsumer provided by RabbitMq.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)