You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/13 00:56:33 UTC
[GitHub] [kafka] mjsax opened a new pull request #8865: MINOR: fix StreamsConfig parameter name variable
mjsax opened a new pull request #8865:
URL: https://github.com/apache/kafka/pull/8865
Rename `TOPOLOGY_OPTIMIZATION` to `TOPOLOGY_OPTIMIZATION_CONFIG`.
All variables in `StreamConfig` end with `_CONFIG`. We should align the variable name accordingly. This is technically a public API change. Happy to do a quick KIP for it, if we think we need one. IMHO, it's a bug and it might be ok without a KIP, too.
\cc @guozhangwang @vvcephei
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #8865: KAFKA-10168: fix StreamsConfig parameter name variable
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8865:
URL: https://github.com/apache/kafka/pull/8865#issuecomment-646863212
@vvcephei As you are +1, I am going to merge after Jenkins passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #8865: KAFKA-10168: fix StreamsConfig parameter name variable
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #8865:
URL: https://github.com/apache/kafka/pull/8865
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #8865: MINOR: fix StreamsConfig parameter name variable
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8865:
URL: https://github.com/apache/kafka/pull/8865#issuecomment-644485931
Not sure if changing KIP-295 would be a good call. We made a mistake and can be honest about it. I'll do a quick KIP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8865: MINOR: fix StreamsConfig parameter name variable
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8865:
URL: https://github.com/apache/kafka/pull/8865#issuecomment-644211672
Looks like a compile warning:
```
00:07:57.788 > Task :streams:compileJava
00:07:57.788 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:530: warning: [dep-ann] deprecated item is not annotated with @Deprecated
00:07:57.788 public static final String TOPOLOGY_OPTIMIZATION = "topology.optimization";
00:07:57.789 ^
00:07:57.789 error: warnings found and -Werror specified
```
I'm +1 on this change, and I think it would be fine to just amend KIP-295.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #8865: KAFKA-10168: fix StreamsConfig parameter name variable
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8865:
URL: https://github.com/apache/kafka/pull/8865#issuecomment-646862985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org