You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/02/01 19:04:41 UTC
[GitHub] [accumulo] jmark99 commented on a change in pull request #2447: Add errorpone profile to main Accumulo pom.
jmark99 commented on a change in pull request #2447:
URL: https://github.com/apache/accumulo/pull/2447#discussion_r796909723
##########
File path: pom.xml
##########
@@ -1622,5 +1623,62 @@
<surefire.reuseForks>${reuseForks}</surefire.reuseForks>
</properties>
</profile>
+ <profile>
+ <!-- This profile uses the Google errorprone tool to perform static code analysis at
+ compile time. Auto-generated code is not checked.
+ See: https://errorprone.info/bugpatterns for list of available bug patterns.-->
+ <id>errorprone</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <showWarnings>true</showWarnings>
+ <source>${maven.compiler.source}</source>
+ <source>${maven.compiler.target}}</source>
+ <encoding>UTF-8</encoding>
+ <compilerArgs>
+ <arg>-XDcompilePolicy=simple</arg>
+ <arg>
+ -Xplugin:ErrorProne \
+ -XepExcludedPaths:.*/(proto|thrift|generated-sources)/.* \
+ -XepDisableWarningsInGeneratedCode \
+ -XepDisableAllWarnings \
+ <!-- error/warning patterns to ignore -->
+ -Xep:Incomparable:OFF \
+ -Xep:CheckReturnValue:OFF \
+ -Xep:MustBeClosedChecker:OFF \
+ -Xep:ReturnValueIgnored:OFF \
+ <!-- error/warning patterns to specifically check -->
+ -Xep:ExpectedExceptionChecker \
+ -Xep:MissingOverride \
+ <!-- Items containing 'OFF' are currently flagged by errorprone. The 'OFF'
+ can be removed and the project recompiled to discover lcation of errors for
+ further analysis. @SuppressWarnings can be used to ignore errors if desired. -->
+ </arg>
+ <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED</arg>
+ <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</arg>
+ <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED</arg>
+ <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED</arg>
+ <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED</arg>
+ <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED</arg>
+ <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED</arg>
+ <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED</arg>
+ <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</arg>
+ <arg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</arg>
+ </compilerArgs>
+ <annotationProcessorPaths>
+ <path>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_core</artifactId>
+ <version>${errorprone.version}</version>
+ </path>
+ </annotationProcessorPaths>
Review comment:
After reading the docs a little more, it looks like this would cause issues if other annotations processor are used. It would no longer scan the compile classpath for annotation processors. They would have to be added using the annotationProcessorPaths argument.
Given that could be an issue, I'm ok closing this ticket without merging as it would be easy enough for me to run the processor every month or so on my own to see if any uncaught issues have been introduced into the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org