You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/29 09:17:14 UTC

[GitHub] [apisix] liangliang4ward commented on a change in pull request #6745: fix: hide 5xx error message from client

liangliang4ward commented on a change in pull request #6745:
URL: https://github.com/apache/apisix/pull/6745#discussion_r837248900



##########
File path: apisix/plugins/authz-keycloak.lua
##########
@@ -572,7 +572,7 @@ local function evaluate_permissions(conf, ctx, token)
     -- Ensure discovered data.
     local err = authz_keycloak_ensure_discovered_data(conf)
     if err then
-        return 500, err

Review comment:
       done

##########
File path: apisix/plugins/authz-casbin.lua
##########
@@ -110,9 +110,9 @@ end
 
 function _M.rewrite(conf, ctx)
     -- creates an enforcer when request sent for the first time
-    local ok, err = new_enforcer_if_need(conf)
+    local ok = new_enforcer_if_need(conf)

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org