You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/07/02 19:59:59 UTC

[GitHub] [zookeeper] jorgheymans commented on a change in pull request #1002: ZOOKEEPER-3453:zkcli.cmd: ZOO_LOG_FILE is missing set

jorgheymans commented on a change in pull request #1002: ZOOKEEPER-3453:zkcli.cmd: ZOO_LOG_FILE is missing set
URL: https://github.com/apache/zookeeper/pull/1002#discussion_r299660131
 
 

 ##########
 File path: bin/zkEnv.cmd
 ##########
 @@ -46,5 +46,8 @@ if not exist "%JAVA_HOME%"\bin\java.exe (
   goto :eof
 )
 
+REM strip off trailing \ from JAVA_HOME or java does not start
+if "%JAVA_HOME:~-1%" EQU "\" set "JAVA_HOME=%JAVA_HOME:~0,-1%"
+ 
 set JAVA="%JAVA_HOME%"\bin\java
 
 
 Review comment:
   i reverted the obsolete commit from the PR 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services