[jira] Created: (ZETACOMP-27) historical parameter order of implode($pieces, $glue) used

["Michael Kliewe (JIRA)" <ji...@apache.org>]

historical parameter order of implode($pieces, $glue) used
----------------------------------------------------------

                 Key: ZETACOMP-27
                 URL: https://issues.apache.org/jira/browse/ZETACOMP-27
             Project: Zeta Components
          Issue Type: Improvement
          Components: Graph, Mail
            Reporter: Michael Kliewe
            Priority: Trivial


from php.net:

string implode ( string $glue , array $pieces )

implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.

There are at the moment 7 usages in the library where the order is ($pieces, $glue) instead of ($glue, $pieces):

/Mail/src/transports/imap/imap_transport.php
2 times:
$ids = implode( $messages, ',' );

Graph/src/options/svg_driver.php
5 times:
implode( $values, ', ' )

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.