[GitHub] [ratis] kaijchen commented on pull request #808: RATIS-1769. Avoid changing priorities in TransferCommand unless necessary

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on PR #808:
URL: https://github.com/apache/ratis/pull/808#issuecomment-1432998040

   Note: sometimes transfer leadership succeeds, but the request timed out.
   This is due to the old leader hasn't received any messages from the new leader yet.
   Especially in default timeout, i.e. `TransferLeadershipRequest.timeout = 0`,
   the timeout will default to `server.randomElectionTimeout()`.
   
   This will lead to `TransferCommand` to return -1, and cause flaky test.
   So is it better to set a larger default timeout?
   
   To fix this problem, we should wait for the new leader to be elected in the shell.
   But `AbstractRatisCommand` seems didn't expect the leader to change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org