You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ji...@apache.org on 2014/09/05 16:19:30 UTC
svn commit: r1622705 - in /httpd/httpd/branches/2.4.x: ./
docs/manual/rewrite/ modules/arch/netware/ modules/core/
modules/generators/ modules/proxy/ modules/ssl/ server/ support/
Author: jim
Date: Fri Sep 5 14:19:29 2014
New Revision: 1622705
URL: http://svn.apache.org/r1622705
Log:
Merge r1597642, r1608999, r1605207, r1610366, r1610353, r1611871 from trunk:
Rename module name in doxygen + partly revert r832442 which skipped doxygen doc generation for 'mod_watchdog.h'
s/apr_pstrndup/apr_pstrmemdup/ to save a few cycles
Use ap_remove_input_filter_byhandle instead of duplicating the code.
Remove some 'register' in variable declaration.
Remove some 'register' in variable declaration.
Save a few cycles by calling 'apr_isalnum' instead of 'apr_isalpha' and 'apr_isdigit'.
Do not use deprecated define.
No change in generated code because MODULE_MAGIC_NUMBER is defined as:
#define MODULE_MAGIC_NUMBER MODULE_MAGIC_NUMBER_MAJOR
Submitted by: jailletc36
Reviewed/backported by: jim
Modified:
httpd/httpd/branches/2.4.x/ (props changed)
httpd/httpd/branches/2.4.x/STATUS
httpd/httpd/branches/2.4.x/docs/manual/rewrite/advanced.xml (props changed)
httpd/httpd/branches/2.4.x/modules/arch/netware/mod_nw_ssl.c
httpd/httpd/branches/2.4.x/modules/core/mod_watchdog.h
httpd/httpd/branches/2.4.x/modules/generators/mod_autoindex.c
httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c
httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_ftp.c
httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c
httpd/httpd/branches/2.4.x/modules/ssl/ssl_engine_vars.c
httpd/httpd/branches/2.4.x/server/util.c
httpd/httpd/branches/2.4.x/server/util_expr_eval.c
httpd/httpd/branches/2.4.x/support/htdigest.c
Propchange: httpd/httpd/branches/2.4.x/
------------------------------------------------------------------------------
Merged /httpd/httpd/trunk:r1597642,1605207,1608999,1610353,1610366,1611871
Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Fri Sep 5 14:19:29 2014
@@ -101,27 +101,6 @@ RELEASE SHOWSTOPPERS:
PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
[ start all new proposals below, under PATCHES PROPOSED. ]
- * Easy patches - synch with trunk
- - mod_watchdog: Rename module name in doxygen + partly revert r832442 which
- skipped doxygen doc generation for 'mod_watchdog.h'
- - mod_proxy: s/apr_pstrndup/apr_pstrmemdup/ to save a few cycles
- - mod_proxy_wstunnel: Use ap_remove_input_filter_byhandle instead of
- duplicating the code.
- - Remove some 'register' in variable declaration.
- - core: Remove some 'register' in variable declaration.
- Save a few cycles by calling 'apr_isalnum' instead of
- 'apr_isalpha' and 'apr_isdigit'.
- - Do not use deprecated define. s/MODULE_MAGIC_NUMBER/MODULE_MAGIC_NUMBER_MAJOR/
- trunk patch:
- http://svn.apache.org/r1597642
- http://svn.apache.org/r1608999
- http://svn.apache.org/r1605207
- http://svn.apache.org/r1610366
- http://svn.apache.org/r1610353
- http://svn.apache.org/r1611871
- 2.4.x patch: http://people.apache.org/~jailletc36/backport9.patch
- +1: jailletc36, ylavic, jim
-
* Add some missing APLOGNO.
Refactor some lines to keep APLOGNO on the same line as ap_log_error, when applicable.
Split some lines longer than 80.
Propchange: httpd/httpd/branches/2.4.x/docs/manual/rewrite/advanced.xml
------------------------------------------------------------------------------
Merged /httpd/httpd/trunk/docs/manual/rewrite/advanced.xml:r1597642,1605207,1608999,1610353,1610366,1611871
Modified: httpd/httpd/branches/2.4.x/modules/arch/netware/mod_nw_ssl.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/arch/netware/mod_nw_ssl.c?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/modules/arch/netware/mod_nw_ssl.c (original)
+++ httpd/httpd/branches/2.4.x/modules/arch/netware/mod_nw_ssl.c Fri Sep 5 14:19:29 2014
@@ -1086,7 +1086,7 @@ char *ssl_var_lookup(apr_pool_t *p, serv
else if (strcEQ(var, "SERVER_SOFTWARE"))
result = ap_get_server_banner();
else if (strcEQ(var, "API_VERSION")) {
- result = apr_itoa(p, MODULE_MAGIC_NUMBER);
+ result = apr_itoa(p, MODULE_MAGIC_NUMBER_MAJOR);
resdup = FALSE;
}
else if (strcEQ(var, "TIME_YEAR")) {
Modified: httpd/httpd/branches/2.4.x/modules/core/mod_watchdog.h
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/core/mod_watchdog.h?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/modules/core/mod_watchdog.h (original)
+++ httpd/httpd/branches/2.4.x/modules/core/mod_watchdog.h Fri Sep 5 14:19:29 2014
@@ -21,9 +21,9 @@
* @file mod_watchdog.h
* @brief Watchdog module for Apache
*
- * @defgroup MOD_WATCHDOG watchdog
+ * @defgroup MOD_WATCHDOG mod_watchdog
* @ingroup APACHE_MODS
- * \@{
+ * @{
*/
#include "httpd.h"
@@ -210,4 +210,4 @@ APR_DECLARE_EXTERNAL_HOOK(ap, AP_WD, int
#endif
#endif /* MOD_WATCHDOG_H */
-/** \@} */
+/** @} */
Modified: httpd/httpd/branches/2.4.x/modules/generators/mod_autoindex.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/generators/mod_autoindex.c?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/modules/generators/mod_autoindex.c (original)
+++ httpd/httpd/branches/2.4.x/modules/generators/mod_autoindex.c Fri Sep 5 14:19:29 2014
@@ -1416,7 +1416,7 @@ static char *terminate_description(autoi
apr_int32_t autoindex_opts, int desc_width)
{
int maxsize = desc_width;
- register int x;
+ int x;
/*
* If there's no DescriptionWidth in effect, default to the old
Modified: httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c (original)
+++ httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.c Fri Sep 5 14:19:29 2014
@@ -548,9 +548,9 @@ static const char *proxy_interpolate(req
return str;
}
/* OK, this is syntax we want to interpolate. Is there such a var ? */
- var = apr_pstrndup(r->pool, start+2, end-(start+2));
+ var = apr_pstrmemdup(r->pool, start+2, end-(start+2));
val = apr_table_get(r->subprocess_env, var);
- firstpart = apr_pstrndup(r->pool, str, (start-str));
+ firstpart = apr_pstrmemdup(r->pool, str, (start-str));
if (val == NULL) {
return apr_pstrcat(r->pool, firstpart,
@@ -1044,7 +1044,7 @@ static int proxy_handler(request_rec *r)
return HTTP_MOVED_PERMANENTLY;
}
- scheme = apr_pstrndup(r->pool, uri, p - uri);
+ scheme = apr_pstrmemdup(r->pool, uri, p - uri);
/* Check URI's destination host against NoProxy hosts */
/* Bypass ProxyRemote server lookup if configured as NoProxy */
for (direct_connect = i = 0; i < conf->dirconn->nelts &&
Modified: httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_ftp.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_ftp.c?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_ftp.c (original)
+++ httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_ftp.c Fri Sep 5 14:19:29 2014
@@ -447,7 +447,7 @@ static apr_status_t proxy_send_dir_filte
apr_bucket_brigade *out = apr_brigade_create(p, c->bucket_alloc);
apr_status_t rv;
- register int n;
+ int n;
char *dir, *path, *reldir, *site, *str, *type;
const char *pwd = apr_table_get(r->notes, "Directory-PWD");
Modified: httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c (original)
+++ httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy_wstunnel.c Fri Sep 5 14:19:29 2014
@@ -141,29 +141,6 @@ static int proxy_wstunnel_transfer(reque
return rv;
}
-/* Search thru the input filters and remove the reqtimeout one */
-static void remove_reqtimeout(ap_filter_t *next)
-{
- ap_filter_t *reqto = NULL;
- ap_filter_rec_t *filter;
-
- filter = ap_get_input_filter_handle("reqtimeout");
- if (!filter) {
- return;
- }
-
- while (next) {
- if (next->frec == filter) {
- reqto = next;
- break;
- }
- next = next->next;
- }
- if (reqto) {
- ap_remove_input_filter(reqto);
- }
-}
-
/*
* process the request and write the response.
*/
@@ -236,7 +213,7 @@ static int ap_proxy_wstunnel_request(apr
pollfd.desc.s = client_socket;
apr_pollset_add(pollset, &pollfd);
- remove_reqtimeout(c->input_filters);
+ ap_remove_input_filter_byhandle(c->input_filters, "reqtimeout");
r->output_filters = c->output_filters;
r->proto_output_filters = c->output_filters;
Modified: httpd/httpd/branches/2.4.x/modules/ssl/ssl_engine_vars.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/ssl/ssl_engine_vars.c?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/modules/ssl/ssl_engine_vars.c (original)
+++ httpd/httpd/branches/2.4.x/modules/ssl/ssl_engine_vars.c Fri Sep 5 14:19:29 2014
@@ -261,7 +261,7 @@ char *ssl_var_lookup(apr_pool_t *p, serv
else if (strcEQ(var, "SERVER_SOFTWARE"))
result = ap_get_server_banner();
else if (strcEQ(var, "API_VERSION")) {
- result = apr_itoa(p, MODULE_MAGIC_NUMBER);
+ result = apr_itoa(p, MODULE_MAGIC_NUMBER_MAJOR);
resdup = FALSE;
}
else if (strcEQ(var, "TIME_YEAR")) {
Modified: httpd/httpd/branches/2.4.x/server/util.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/server/util.c?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/server/util.c (original)
+++ httpd/httpd/branches/2.4.x/server/util.c Fri Sep 5 14:19:29 2014
@@ -252,7 +252,7 @@ AP_DECLARE(int) ap_os_is_path_absolute(a
AP_DECLARE(int) ap_is_matchexp(const char *str)
{
- register int x;
+ int x;
for (x = 0; str[x]; x++)
if ((str[x] == '*') || (str[x] == '?'))
@@ -528,7 +528,7 @@ AP_DECLARE(void) ap_getparents(char *nam
while (name[l] != '\0') {
if (name[l] == '.' && name[l + 1] == '.' && IS_SLASH(name[l + 2])
&& (l == 0 || IS_SLASH(name[l - 1]))) {
- register int m = l + 3, n;
+ int m = l + 3, n;
l = l - 2;
if (l >= 0) {
@@ -654,7 +654,7 @@ AP_DECLARE(char *) ap_make_dirstr_parent
AP_DECLARE(int) ap_count_dirs(const char *path)
{
- register int x, n;
+ int x, n;
for (x = 0, n = 0; path[x]; x++)
if (path[x] == '/')
@@ -1585,7 +1585,7 @@ AP_DECLARE(char *) ap_escape_shell_cmd(a
static char x2c(const char *what)
{
- register char digit;
+ char digit;
#if !APR_CHARSET_EBCDIC
digit = ((what[0] >= 'A') ? ((what[0] & 0xdf) - 'A') + 10
@@ -1617,7 +1617,7 @@ static char x2c(const char *what)
static int unescape_url(char *url, const char *forbid, const char *reserved)
{
- register int badesc, badpath;
+ int badesc, badpath;
char *x, *y;
badesc = 0;
@@ -2100,11 +2100,11 @@ AP_DECLARE(char *) ap_make_full_path(apr
*/
AP_DECLARE(int) ap_is_url(const char *u)
{
- register int x;
+ int x;
for (x = 0; u[x] != ':'; x++) {
if ((!u[x]) ||
- ((!apr_isalpha(u[x])) && (!apr_isdigit(u[x])) &&
+ ((!apr_isalnum(u[x])) &&
(u[x] != '+') && (u[x] != '-') && (u[x] != '.'))) {
return 0;
}
Modified: httpd/httpd/branches/2.4.x/server/util_expr_eval.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/server/util_expr_eval.c?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/server/util_expr_eval.c (original)
+++ httpd/httpd/branches/2.4.x/server/util_expr_eval.c Fri Sep 5 14:19:29 2014
@@ -1475,7 +1475,7 @@ static const char *misc_var_fn(ap_expr_e
case 8:
return ap_get_server_banner();
case 9:
- return apr_itoa(ctx->p, MODULE_MAGIC_NUMBER);
+ return apr_itoa(ctx->p, MODULE_MAGIC_NUMBER_MAJOR);
default:
ap_assert(0);
}
Modified: httpd/httpd/branches/2.4.x/support/htdigest.c
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/support/htdigest.c?rev=1622705&r1=1622704&r2=1622705&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/support/htdigest.c (original)
+++ httpd/httpd/branches/2.4.x/support/htdigest.c Fri Sep 5 14:19:29 2014
@@ -92,7 +92,7 @@ static void getword(char *word, char *li
static int get_line(char *s, int n, apr_file_t *f)
{
- register int i = 0;
+ int i = 0;
char ch;
apr_status_t rv = APR_EINVAL;