You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/07/31 00:56:54 UTC
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13961
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
---
M docs/topics/impala_connecting.xml
M docs/topics/impala_shell_options.xml
2 files changed, 64 insertions(+), 73 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/13961/1
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Reviewed-on: http://gerrit.cloudera.org:8080/13961
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Alex Rodoni <ar...@cloudera.com>
---
M docs/topics/impala_connecting.xml
M docs/topics/impala_shell_options.xml
2 files changed, 81 insertions(+), 91 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Rodoni: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/416/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 00:57:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13961
to look at the new patch set (#2).
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
---
M docs/topics/impala_connecting.xml
M docs/topics/impala_shell_options.xml
2 files changed, 80 insertions(+), 89 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/13961/2
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 20:26:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13961/3/docs/topics/impala_connecting.xml
File docs/topics/impala_connecting.xml:
http://gerrit.cloudera.org:8080/#/c/13961/3/docs/topics/impala_connecting.xml@81
PS3, Line 81: When you are
> Remove
Done
http://gerrit.cloudera.org:8080/#/c/13961/3/docs/topics/impala_connecting.xml@87
PS3, Line 87:
> remove trailing space
Done
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Aug 2019 20:13:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/424/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 18:35:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13961/3/docs/topics/impala_connecting.xml
File docs/topics/impala_connecting.xml:
http://gerrit.cloudera.org:8080/#/c/13961/3/docs/topics/impala_connecting.xml@81
PS3, Line 81: When you are
Remove
http://gerrit.cloudera.org:8080/#/c/13961/3/docs/topics/impala_connecting.xml@87
PS3, Line 87:
remove trailing space
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Aug 2019 20:11:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/417/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 01:03:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13961
to look at the new patch set (#4).
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
---
M docs/topics/impala_connecting.xml
M docs/topics/impala_shell_options.xml
2 files changed, 81 insertions(+), 91 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/13961/4
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/424/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 18:23:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/430/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Aug 2019 20:14:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_connecting.xml
File docs/topics/impala_connecting.xml:
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_connecting.xml@85
PS2, Line 85: # When you are logged onto a different host, and impalad is listening
> I think you mean, "connecting to an impalad running on a remote machine"..
Done
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_connecting.xml@87
PS2, Line 87: -p
> -- (double dash)
Done
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_connecting.xml@87
PS2, Line 87: -i
> -i should be before the <some..other..hostname>
Done
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_shell_options.xml
File docs/topics/impala_shell_options.xml:
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_shell_options.xml@573
PS2, Line 573: .<
> ..protocol. (same below too)
Done
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 18:22:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/430/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Aug 2019 20:38:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Thomas Tauber-Marshall, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13961
to look at the new patch set (#3).
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
---
M docs/topics/impala_connecting.xml
M docs/topics/impala_shell_options.xml
2 files changed, 81 insertions(+), 91 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/13961/3
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/417/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 01:12:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/416/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jul 2019 01:03:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_connecting.xml
File docs/topics/impala_connecting.xml:
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_connecting.xml@85
PS2, Line 85: # When you are logged onto a different host, and impalad is listening
I think you mean, "connecting to an impalad running on a remote machine".. or something like that. I don't think its logged onto a different host...
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_connecting.xml@87
PS2, Line 87: -i
-i should be before the <some..other..hostname>
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_connecting.xml@87
PS2, Line 87: -p
-- (double dash)
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_shell_options.xml
File docs/topics/impala_shell_options.xml:
http://gerrit.cloudera.org:8080/#/c/13961/2/docs/topics/impala_shell_options.xml@573
PS2, Line 573: .<
..protocol. (same below too)
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 02:41:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13961 )
Change subject: IMPALA-8668: [DOCS] HS2 Support for Impala-Shell connection
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4e207d247409ac3069ce8a235be3f63e616007e
Gerrit-Change-Number: 13961
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Aug 2019 21:31:31 +0000
Gerrit-HasComments: No