You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2017/05/26 20:49:54 UTC
[Bug 61128] New: Allow cluster manager mapSendOptions to be
specified with verbose, human-readable names
https://bz.apache.org/bugzilla/show_bug.cgi?id=61128
Bug ID: 61128
Summary: Allow cluster manager mapSendOptions to be specified
with verbose, human-readable names
Product: Tomcat 9
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: chris@christopherschultz.net
Target Milestone: -----
Cluster managers support "mapSendOptions" which is specified as an integer
value, bitwise-ORd from the individual bits which make-up the various options.
The default value is 8 for the DeltaManager which means "asynchronous".
It would be nice if the configuration could use human-readable options like
"async" instead of "8".
These are the channel send options available:
SEND_OPTIONS_ASYNCHRONOUS
SEND_OPTIONS_BYTE_MESSAGE
SEND_OPTIONS_MULTICAST
SEND_OPTIONS_SECURE
SEND_OPTIONS_SYNCHRONIZED_ACK
SEND_OPTIONS_UDP
SEND_OPTIONS_USE_ACK
They could be specified as human-readable strings e.g.
mapSendOptions="async,multicast" instead of mapSendOptions="72" which would
make the configuration much easier to both read and write.
For backward compatibility, the integer values should also be acceptable.
This bug is nearly the same as bug #61127, but on a different component.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 61128] Allow cluster manager mapSendOptions to be specified
with verbose, human-readable names
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61128
Igal Sapir <de...@21solutions.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dev@21solutions.net
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 61128] Allow cluster manager mapSendOptions to be specified
with verbose, human-readable names
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61128
--- Comment #1 from Igal Sapir <de...@21solutions.net> ---
Please see https://github.com/apache/tomcat/pull/56 as a WIP.
Especially given the fact that this is my first PR I would need more feedback.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 61128] Allow cluster manager mapSendOptions to be specified
with verbose, human-readable names
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61128
--- Comment #2 from Igal Sapir <de...@21solutions.net> ---
Chris,
https://github.com/apache/tomcat/pull/56/files should take care of #61127, but
where do you set "mapSendOptions"?
I see `public void setMapSendOptions(int mapSendOptions)` in 3 classes:
* BackupManager
* ClusterSingleSignOn
* ReplicatedContext
The "fix" should be to add another method that takes a String input, as
follows:
public void setMapSendOptions(String mapSendOptions) {
int value = Channel.parseChannelSendOptions(mapSendOptions);
if (value > 0)
this.setMapSendOptions(value);
}
But... Do all 3 of them use that? TBH I'm not sure and I've never set up a
Cluster in Tomcat so I don't know if I should add those or not. For example,
are those used in config elements like "Cluster" in server.xml? I can't find
anything about that.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 61128] Allow cluster manager mapSendOptions to be specified
with verbose, human-readable names
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61128
Christopher Schultz <ch...@christopherschultz.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #3 from Christopher Schultz <ch...@christopherschultz.net> ---
*** This bug has been marked as a duplicate of bug 61127 ***
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org