You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@struts.apache.org by lu...@apache.org on 2016/01/04 20:17:28 UTC
[3/4] struts git commit: A proper way to close the db connection
A proper way to close the db connection
Project: http://git-wip-us.apache.org/repos/asf/struts/repo
Commit: http://git-wip-us.apache.org/repos/asf/struts/commit/0e111125
Tree: http://git-wip-us.apache.org/repos/asf/struts/tree/0e111125
Diff: http://git-wip-us.apache.org/repos/asf/struts/diff/0e111125
Branch: refs/heads/master
Commit: 0e111125d596e3da2ac52f5317e7417d353844e8
Parents: 38da3f6
Author: Victor Sosa <vi...@gmail.com>
Authored: Sun Jan 3 08:05:03 2016 -0400
Committer: Victor Sosa <vi...@gmail.com>
Committed: Sun Jan 3 08:05:03 2016 -0400
----------------------------------------------------------------------
.../struts2/views/jasperreports/JasperReportsResult.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/struts/blob/0e111125/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java
----------------------------------------------------------------------
diff --git a/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java b/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java
index 921a010..e0ea121 100644
--- a/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java
+++ b/plugins/jasperreports/src/main/java/org/apache/struts2/views/jasperreports/JasperReportsResult.java
@@ -386,7 +386,11 @@ public class JasperReportsResult extends StrutsResultSupport implements JasperRe
LOG.error("Error producing {} report for uri {}", format, systemId, e);
throw new ServletException(e.getMessage(), e);
} finally {
- conn.close();
+ try {
+ conn.close();
+ } catch (Exception e) {
+ LOG.warn("Could not close db connection properly", e);
+ }
}
response.setContentLength(output.size());