[GitHub] [shardingsphere-elasticjob-lite] terrymanu commented on a change in pull request #1043: Maven install throw exception

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #1043:
URL: https://github.com/apache/shardingsphere-elasticjob-lite/pull/1043#discussion_r453566748



##########
File path: elasticjob-cloud/elasticjob-cloud-executor/src/main/java/org/apache/shardingsphere/elasticjob/cloud/executor/DaemonTaskScheduler.java
##########
@@ -156,10 +156,27 @@ public static void shutdown(final Protos.TaskID taskID) {
         
         @Setter
         private ExecutorDriver executorDriver;
-    
+        
         @Setter
         private Protos.TaskID taskId;
         
+        private ElasticJobExecutor jobExecutor;
+        
+        private ElasticJobExecutor getJobExecutor() {
+            if (null == jobExecutor) {

Review comment:
       It is necessary to consider about thread safe




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org