You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2026/02/09 17:25:31 UTC
(superset) 03/04: test(chart-list): delete Cypress tests covered by RTL and unit tests
This is an automated email from the ASF dual-hosted git repository.
jli pushed a commit to branch feat-chart-list-rtl-tests
in repository https://gitbox.apache.org/repos/asf/superset.git
commit d079eb7fffce7ab4ee3df49a5f256523cdb1f7f2
Author: Joe Li <jo...@preset.io>
AuthorDate: Fri Feb 6 14:50:48 2026 -0800
test(chart-list): delete Cypress tests covered by RTL and unit tests
- Delete _skip.filter.test.ts entirely (5 filter tests with no assertions)
- Delete crosslinks and card mode sort/filter tests from list.test.ts
(covered by RTL crosslinks test and hooks.test.tsx unit tests)
- Keep common actions block in list.test.ts for PR2 Playwright migration
- Clean up unused imports
Co-Authored-By: Claude Opus 4.6 <no...@anthropic.com>
---
.../cypress/e2e/chart_list/_skip.filter.test.ts | 57 ----------------------
.../cypress/e2e/chart_list/list.test.ts | 57 ----------------------
2 files changed, 114 deletions(-)
diff --git a/superset-frontend/cypress-base/cypress/e2e/chart_list/_skip.filter.test.ts b/superset-frontend/cypress-base/cypress/e2e/chart_list/_skip.filter.test.ts
deleted file mode 100644
index 5f732048516..00000000000
--- a/superset-frontend/cypress-base/cypress/e2e/chart_list/_skip.filter.test.ts
+++ /dev/null
@@ -1,57 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-import { CHART_LIST } from 'cypress/utils/urls';
-import { setGridMode, clearAllInputs } from 'cypress/utils';
-import { setFilter } from '../explore/utils';
-
-describe('Charts filters', () => {
- before(() => {
- cy.visit(CHART_LIST);
- setGridMode('card');
- });
-
- beforeEach(() => {
- clearAllInputs();
- });
-
- it('should allow filtering by "Owner"', () => {
- setFilter('Owner', 'alpha user');
- setFilter('Owner', 'admin user');
- });
-
- it('should allow filtering by "Modified by" correctly', () => {
- setFilter('Modified by', 'alpha user');
- setFilter('Modified by', 'admin user');
- });
-
- it('should allow filtering by "Type" correctly', () => {
- setFilter('Type', 'Area Chart');
- setFilter('Type', 'Bubble Chart');
- });
-
- it('should allow filtering by "Dataset" correctly', () => {
- setFilter('Dataset', 'birth_names');
- setFilter('Dataset', 'video_game_sales');
- });
-
- it('should allow filtering by "Dashboards" correctly', () => {
- setFilter('Dashboard', 'USA Births Names');
- setFilter('Dashboard', 'Video Game Sales');
- });
-});
diff --git a/superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts b/superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts
index f5405d4de11..9f507bca4ab 100644
--- a/superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts
+++ b/superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts
@@ -23,12 +23,9 @@ import {
interceptBulkDelete,
interceptUpdate,
interceptDelete,
- visitSampleChartFromList,
- saveChartToDashboard,
interceptFiltering,
interceptFavoriteStatus,
} from '../explore/utils';
-import { interceptGet as interceptDashboardGet } from '../dashboard/utils';
function orderAlphabetical() {
setFilter('Sort', 'Alphabetical');
@@ -57,60 +54,6 @@ function visitChartList() {
}
describe('Charts list', () => {
- describe('Cross-referenced dashboards', () => {
- beforeEach(() => {
- cy.createSampleDashboards([0, 1, 2, 3]);
- cy.createSampleCharts([0]);
- visitChartList();
- });
-
- // Skipped: depends on "Supported Charts Dashboard" which requires specific example loading
- it.skip('should show the cross-referenced dashboards in the table cell', () => {
- interceptDashboardGet();
- cy.getBySel('table-row')
- .first()
- .find('[data-test="table-row-cell"]')
- .find('[data-test="crosslinks"]')
- .should('be.empty');
- cy.getBySel('table-row')
- .eq(10)
- .find('[data-test="table-row-cell"]')
- .find('[data-test="crosslinks"]')
- .contains('Supported Charts Dashboard')
- .invoke('removeAttr', 'target')
- .click();
- cy.wait('@get');
- });
-
- it('should show the newly added dashboards in a tooltip', () => {
- interceptDashboardGet();
- visitSampleChartFromList('1 - Sample chart');
- saveChartToDashboard('1 - Sample chart', '1 - Sample dashboard');
- saveChartToDashboard('1 - Sample chart', '2 - Sample dashboard');
- saveChartToDashboard('1 - Sample chart', '3 - Sample dashboard');
- saveChartToDashboard('1 - Sample chart', '4 - Sample dashboard');
- visitChartList();
-
- cy.getBySel('count-crosslinks').should('be.visible');
- });
- });
-
- describe('card mode', () => {
- before(() => {
- visitChartList();
- setGridMode('card');
- });
-
- it('should preserve other filters when sorting', () => {
- // Check that we have some cards (count varies based on loaded examples)
- cy.getBySel('styled-card').should('have.length.at.least', 1);
- setFilter('Type', 'Big Number');
- setFilter('Sort', 'Least recently modified');
- // After filtering to Big Number type, we should have fewer cards
- cy.getBySel('styled-card').should('have.length.at.least', 1);
- });
- });
-
describe('common actions', () => {
beforeEach(() => {
visitChartList();