[GitHub] [incubator-echarts] pissang commented on a change in pull request #11951: feat(bar): bar background

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #11951: feat(bar): bar background
URL: https://github.com/apache/incubator-echarts/pull/11951#discussion_r363162671
 
 

 ##########
 File path: src/chart/bar/BarView.js
 ##########
 @@ -127,15 +128,50 @@ export default echarts.extendChartView({
 
         var roundCap = seriesModel.get('roundCap', true);
 
+        var backgroundModel = seriesModel.getModel('backgroundStyle');
+        var backgroundColor = backgroundModel.get('color');
+
+        // Not create background element for transparent one to improve efficiency
+        var drawBackground = backgroundColor !== 'transparent' && backgroundColor !== 'none';
+
 
 Review comment:
   Only using `backgroundColor` to determine if drawing background is not enough. Developers may want to have border only background.
   
   We can use `showBackground ` as mentioned in the previous comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org