You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/05 16:53:06 UTC
[GitHub] [airflow] eladkal opened a new pull request #20692: fix deprecation messages for SFTPHook
eladkal opened a new pull request #20692:
URL: https://github.com/apache/airflow/pull/20692
deprecation warning of some functions in SFTPHook isn't accurate. Fixing the message
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #20692: fix deprecation messages for SFTPHook
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #20692:
URL: https://github.com/apache/airflow/pull/20692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #20692: fix deprecation messages for SFTPHook
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #20692:
URL: https://github.com/apache/airflow/pull/20692#discussion_r779277322
##########
File path: airflow/providers/sftp/hooks/sftp.py
##########
@@ -102,14 +102,14 @@ def __init__(
extra_options = conn.extra_dejson
# For backward compatibility
- # TODO: remove in Airflow 2.1
+ # TODO: remove in next major provider release
Review comment:
```suggestion
# TODO: remove in the next major provider release.
```
##########
File path: airflow/providers/sftp/hooks/sftp.py
##########
@@ -121,7 +121,7 @@ def __init__(
warnings.warn(
'Extra option `ignore_hostkey_verification` is deprecated.'
'Please use `no_host_key_check` instead.'
- 'This option will be removed in Airflow 2.1',
+ 'This option will be removed in future release',
Review comment:
```suggestion
'This option will be removed in a future release.',
```
##########
File path: airflow/providers/sftp/hooks/sftp.py
##########
@@ -102,14 +102,14 @@ def __init__(
extra_options = conn.extra_dejson
# For backward compatibility
- # TODO: remove in Airflow 2.1
+ # TODO: remove in next major provider release
if 'private_key_pass' in extra_options:
warnings.warn(
'Extra option `private_key_pass` is deprecated.'
'Please use `private_key_passphrase` instead.'
'`private_key_passphrase` will precede if both options are specified.'
- 'The old option `private_key_pass` will be removed in Airflow 2.1',
+ 'The old option `private_key_pass` will be removed in future release',
Review comment:
```suggestion
'The old option `private_key_pass` will be removed in a future release.',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20692: fix deprecation messages for SFTPHook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20692:
URL: https://github.com/apache/airflow/pull/20692#issuecomment-1005937598
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org