[GitHub] [lucene-solr] nsoft commented on a change in pull request #1051: SOLR-13992: Refactor code to have collection, shard name in Replica, Slice

[GitBox <gi...@apache.org>]

nsoft commented on a change in pull request #1051: SOLR-13992: Refactor code to have collection, shard name in Replica,Slice
URL: https://github.com/apache/lucene-solr/pull/1051#discussion_r353219909
 
 

 ##########
 File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
 ##########
 @@ -944,6 +944,11 @@ public Replica getLeader(String collection, String shard) {
     return null;
   }
 
+  public boolean isNodeLive(String node) {
 
 Review comment:
   While this is potentially convenient it seems off topic for the PR/Issue. Also if it is kept, in the realm of taste/style I tend to not use get/set/is for things that are not properties of the object. maybe hasLiveNode(String node) thus someone using it might write `if (zkReader.hasLiveNode("foo")) ...` which reads quite nicely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org