You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/06/10 12:43:55 UTC

[GitHub] eolivelli opened a new pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

eolivelli opened a new pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky
URL: https://github.com/apache/bookkeeper/pull/1508
 
 
   
   
   Descriptions of the changes in this PR:
   
   
   
   ### Motivation
   The test if flaky because the Journal is putting some ForceWriteRequest in the internal queue. This test controls the journal and the queue of ForceWriteRequests, but in the end this control is lost and the final assertion can fail if the journal 'works'.
   My guess is about the flag setJournalFlushWhenQueueEmpty which is turned by default to true in tests in order t ospped up the execution.
   
   ### Changes
   
   - add debug
   - add toString to ForceWriteRequest
   - add setJournalFlushWhenQueueEmpty(false) to the flaky test
   
   Master Issue: #1490
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services