[GitHub] [submarine] jiwq commented on pull request #382: SUBMARINE-558. Define Swagger API for pre-defined template submission

[GitBox <gi...@apache.org>]

jiwq commented on pull request #382:
URL: https://github.com/apache/submarine/pull/382#issuecomment-683302819


   > > @JohnTing Thanks for your contribution. But I have a doubt "how can the user submit the experiment by template?" I saw the REST api `/api/v1/template/submit`, but I can't get its meaning. Such as 'create new template' or others? In my opinion, if we provide the template resource, the experiment resource depends on template. So we should extend the experiment api to support accepts the template id and related params to training.
   > 
   > @jiwq, Thanks for your review
   > 
   > My last PR (SUBMARINE-559)
   > [API] Define Swagger API for pre-defined template registration/delete, etc.
   > Support methods such as create new template or delete template
   > 
   > ### get template list
   > /api/v1/template
   > 
   > ### get template
   > get /api/v1/template/{templateName}
   > 
   > ### post template
   > post /api/v1/template
   > 
   > ### patch template
   > patch /api/v1/template/{templateName}
   > 
   > ### delete template
   > delete /api/v1/template/{templateName}
   > 
   > then this PR uses the registered template to submit as an experiment
   > 
   > ### submit template as an experiment
   > post /api/v1/template/submit
   > 
   > The format of the registered template includes a complete experiment, but the template maker can change some parameters into variables for template users to adjust.
   
   Got. I think `POST /api/v1/template/submit` is not a good design, extend the `POST /api/v1/experiment` is the better selected (more info see mine above comment). Any thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org