[jira] [Commented] (OFBIZ-11251) Use ‘checkstyle’ linting tool

["Jacques Le Roux (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951781#comment-16951781 ] 

Jacques Le Roux commented on OFBIZ-11251:
-----------------------------------------

Hi Mathieu,

I like the idea. We discussed about Checkstyle in the past https://ofbiz.markmail.org/search/?q=checkstyle your proposition is by far the most advanced. I tried and I believe this can be helpful. Even if we do only small changes by small changes. BTW, how much checkstyle.xml corresponds to https://svn.apache.org/repos/asf/ofbiz/tools/wiki-files/OFBizJavaFormatter.xml ?

> Use ‘checkstyle’ linting tool
> -----------------------------
>
>                 Key: OFBIZ-11251
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11251
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch
>
>
> Linting [1] is a software engineering practice which make the code
> more readable and maintainable by improving its consistency and
> avoiding potential programming mistakes.
> Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which
> provides such facility.  The lint actions are triggered when running
> ‘gradle check’.
> There are a lot reported errors that will need to be fixed
> incrementally in the future.  We ensure that new errors will not be
> introduced by defining a global threshold of “allowed” errors
> corresponding to the sum of errors currently found in the framework
> and in the official plugins.
> [1] https://en.wikipedia.org/wiki/Lint_(software)
> [2] https://checkstyle.org/
> [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)