[GitHub] [spark] viirya commented on a change in pull request #26847: [SPARK-30214][SQL] A new framework to resolve v2 commands

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #26847: [SPARK-30214][SQL]  A new framework to resolve v2 commands
URL: https://github.com/apache/spark/pull/26847#discussion_r362083461
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -720,6 +722,14 @@ class Analyzer(
     }
   }
 
+  case class ResolveNamespace(catalogManager: CatalogManager)
+    extends Rule[LogicalPlan] with LookupCatalog {
+    def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+      case UnresolvedNamespace(CatalogAndNamespace(catalog, ns)) =>
+        ResolvedNamespace(catalog.asNamespaceCatalog, ns)
+    }
 
 Review comment:
   Does it mean the `ParsedStatement` from parser will turn to use `UnresolvedNamespace`? Currently, the catalogs in statements are resolved at `ResolveCatalogs`. Will we need to refactor `ResolveCatalogs` due to this change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org