[GitHub] [pinot] Jackie-Jiang commented on pull request #10703: [WIP] Add delete support to upsert tables (Design review in progress)

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on PR #10703:
URL: https://github.com/apache/pinot/pull/10703#issuecomment-1530872871

   > Should the `queryableDocIdSnapshot` needs to be persisted as well on shutdown for this to work?
   
   We don't need to persist it because we still need to load everything in the `validDocIds` (including the deleted docs) to refresh the timestamp for the deleted docs
   
   > Also, `queryableDocId` sounds confusing because `validDocId` is also used for querying. I think we should rename it to `activeRowIds` or `undeletedRowIds`
   
   If delete is enabled (by setting the `deleteRecordColumn`), we will only look at `queryableDocIds` during query time. We can add some javadoc so that it is more clear


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org