[GitHub] joeljeske edited a comment on issue #473: CordovaWebViewImpl showWebPage can crash Android >= 7 devices

[GitBox <gi...@apache.org>]

joeljeske edited a comment on issue #473: CordovaWebViewImpl showWebPage can crash Android >= 7 devices
URL: https://github.com/apache/cordova-android/issues/473#issuecomment-417001023
 
 
   @akinzie, This is *exactly* what I am experiencing right now, and I have also just came to the same conclusion as yourself. 
   
   In my setup, this is crashing when the error url is attempted to be navigated to as that flow uses `CordovaWebViewImpl.showWebPage` instead of `CordovaWebViewImpl.loadUrlIntoView`
   
   
   Reproduction Steps: 
   
   * Create a cordova project with cordova-android 7.1.1
   * Install and run on a device with API Level 24 (probably 24+, but I am testing on 24)
   * See that the index.html page loads correctly
   * Change the config.xml `<content>` tag to a https:// address that is unreachable, and will trigger a timeout
   * Change the config.xml and add the preference `ErrorUrl`  to the index.html, using the proper file url: `<preference name="ErrorUrl" value="file:///android_asset/www/index.html" />`
   * Rebuild, reinstall
   * See that after the specified timeout or failure to contact the unavailable web address, the app crashes. The index page that should have loaded as an "error page" was not able to be loaded and the stack trace @akinzie mentioned is given in the logs. 
   
   
   If you add proper `return;`s in the same block that was linked to, the issue does not occur and the error url is able to navigated to. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org