You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2013/01/25 16:55:40 UTC
svn commit: r1438565 -
/httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/auth/GGSSchemeBase.java
Author: olegk
Date: Fri Jan 25 15:55:39 2013
New Revision: 1438565
URL: http://svn.apache.org/viewvc?rev=1438565&view=rev
Log:
HTTPCLIENT-1305: Use Base64 as a final instance variable
Modified:
httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/auth/GGSSchemeBase.java
Modified: httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/auth/GGSSchemeBase.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/auth/GGSSchemeBase.java?rev=1438565&r1=1438564&r2=1438565&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/auth/GGSSchemeBase.java (original)
+++ httpcomponents/httpclient/branches/4.2.x/httpclient/src/main/java/org/apache/http/impl/auth/GGSSchemeBase.java Fri Jan 25 15:55:39 2013
@@ -61,6 +61,7 @@ public abstract class GGSSchemeBase exte
private final Log log = LogFactory.getLog(getClass());
+ private final Base64 base64codec;
private final boolean stripPort;
/** Authentication process state */
@@ -71,8 +72,9 @@ public abstract class GGSSchemeBase exte
GGSSchemeBase(boolean stripPort) {
super();
- this.state = State.UNINITIATED;
+ this.base64codec = new Base64(0);
this.stripPort = stripPort;
+ this.state = State.UNINITIATED;
}
GGSSchemeBase() {
@@ -168,7 +170,7 @@ public abstract class GGSSchemeBase exte
throw new AuthenticationException(gsse.getMessage());
}
case TOKEN_GENERATED:
- String tokenstr = new String(Base64.encodeBase64(token, false));
+ String tokenstr = new String(base64codec.encode(token));
if (log.isDebugEnabled()) {
log.debug("Sending response '" + tokenstr + "' back to the auth server");
}